From 35131cb72c08c657d2a3389338d0c049d57e69bd Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Tue, 5 May 2026 05:20:44 -0500
Subject: refactor: rename debug-wttrin-* commands to wttrin-debug-* with
 obsolete aliases

The four interactive commands in `wttrin-debug.el` used `debug-wttrin-` as their prefix instead of the package's `wttrin-debug-` prefix. package-lint flags this as a convention violation, and it makes M-x discovery slightly less consistent for users.

Renamed:
- `debug-wttrin-show-raw`   -> `wttrin-debug-show-raw`
- `debug-wttrin-enable`     -> `wttrin-debug-enable`
- `debug-wttrin-disable`    -> `wttrin-debug-disable`
- `debug-wttrin-mode-line`  -> `wttrin-debug-mode-line`

The old names stay available as `define-obsolete-function-alias` entries marked since 0.4.0, so anyone with a keybinding or `(call-interactively 'debug-wttrin-enable)` in their config keeps working. The byte-compiler will emit an obsolescence warning to nudge migration. Aliases will be removed in a future release.

Internal caller `wttrin--debug-mode-line-info` now invokes the new name. Test files renamed to match (`test-debug-wttrin-*.el` -> `test-wttrin-debug-*.el`); inside each, ert-deftest names and function calls were updated.

Added `tests/test-wttrin-debug-aliases.el` to verify each old name resolves via `indirect-function` to the new name and carries `byte-obsolete-info` with the expected target and "0.4.0" version.
---
 tests/test-wttrin-debug-disable.el | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 tests/test-wttrin-debug-disable.el

(limited to 'tests/test-wttrin-debug-disable.el')

diff --git a/tests/test-wttrin-debug-disable.el b/tests/test-wttrin-debug-disable.el
new file mode 100644
index 0000000..f6fc5db
--- /dev/null
+++ b/tests/test-wttrin-debug-disable.el
@@ -0,0 +1,43 @@
+;;; test-wttrin-debug-disable.el --- Tests for wttrin-debug-disable -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025-2026 Craig Jennings
+
+;;; Commentary:
+
+;; Unit tests for wttrin-debug-disable.  Verifies the interactive command
+;; clears `wttrin-debug' and is idempotent when already disabled.
+
+;;; Code:
+
+(require 'ert)
+(require 'wttrin)
+(require 'testutil-wttrin)
+
+(require 'wttrin-debug
+         (expand-file-name "wttrin-debug.el"
+                           (file-name-directory (locate-library "wttrin"))))
+
+;;; Normal Cases
+
+(ert-deftest test-wttrin-debug-disable-normal-flips-from-t-to-nil ()
+  "Calling disable when wttrin-debug is t sets it to nil."
+  (let ((wttrin-debug t))
+    (wttrin-debug-disable)
+    (should-not wttrin-debug)))
+
+(ert-deftest test-wttrin-debug-disable-normal-idempotent-when-already-disabled ()
+  "Calling disable when wttrin-debug is already nil leaves it nil."
+  (let ((wttrin-debug nil))
+    (wttrin-debug-disable)
+    (should-not wttrin-debug)))
+
+;;; Boundary Cases
+
+(ert-deftest test-wttrin-debug-disable-boundary-clears-non-boolean-truthy-value ()
+  "Calling disable replaces any truthy value with nil."
+  (let ((wttrin-debug 'verbose))
+    (wttrin-debug-disable)
+    (should-not wttrin-debug)))
+
+(provide 'test-wttrin-debug-disable)
+;;; test-wttrin-debug-disable.el ends here
-- 
cgit v1.2.3