From eabd510c302b43b0b40ee7b92bf5830d345d058d Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sun, 26 Apr 2026 18:29:27 -0500
Subject: refactor: extract wttrin--mode-line-stale-p helper
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The staleness check `(> age (* 2 wttrin-mode-line-refresh-interval))` lived in two places, `wttrin--mode-line-tooltip` and `wttrin--mode-line-update-display`, along with the four-line preamble that read the timestamp out of the cache cons and computed age. Centralizing the rule in a single helper means the threshold lives in one spot. That makes it easy to add a `wttrin-mode-line-staleness-threshold` defcustom later if the magic 2× ever needs to be tunable.

The helper takes a cache entry (or nil) and returns t/nil. Five new tests cover Normal (fresh, stale) and Boundary (just below the threshold, just past, nil entry). The boundary tests use 199s and 201s against a 100s refresh interval to lock the strict `>` semantics with comfortable float-time margins.

In `wttrin--mode-line-update-display` the refactor also drops two locals (`timestamp` and `age`) that were no longer used after the helper call replaced the inline calculation. Behavior is unchanged at both call sites.
---
 tests/test-wttrin--mode-line-helpers.el | 36 +++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

(limited to 'tests')

diff --git a/tests/test-wttrin--mode-line-helpers.el b/tests/test-wttrin--mode-line-helpers.el
index 34523a8..6eae822 100644
--- a/tests/test-wttrin--mode-line-helpers.el
+++ b/tests/test-wttrin--mode-line-helpers.el
@@ -135,5 +135,41 @@ distinguish a missing key from a present key bound to nil."
                        'mode-line-highlight)))
     (test-wttrin--mode-line-helpers-teardown)))
 
+;;; --------------------------------------------------------------------------
+;;; wttrin--mode-line-stale-p
+;;; --------------------------------------------------------------------------
+
+;;; Normal Cases
+
+(ert-deftest test-wttrin--mode-line-stale-p-normal-fresh-cache-returns-nil ()
+  "Cache entry well within the refresh window is not stale."
+  (let ((wttrin-mode-line-refresh-interval 100))
+    (let ((entry (cons (- (float-time) 50) "data")))
+      (should-not (wttrin--mode-line-stale-p entry)))))
+
+(ert-deftest test-wttrin--mode-line-stale-p-normal-stale-cache-returns-t ()
+  "Cache entry older than 2× refresh-interval is stale."
+  (let ((wttrin-mode-line-refresh-interval 100))
+    (let ((entry (cons (- (float-time) 500) "data")))
+      (should (wttrin--mode-line-stale-p entry)))))
+
+;;; Boundary Cases
+
+(ert-deftest test-wttrin--mode-line-stale-p-boundary-just-below-threshold ()
+  "Age 1s below the 2× threshold is not stale (strict >)."
+  (let ((wttrin-mode-line-refresh-interval 100))
+    (let ((entry (cons (- (float-time) 199) "data")))
+      (should-not (wttrin--mode-line-stale-p entry)))))
+
+(ert-deftest test-wttrin--mode-line-stale-p-boundary-just-past-threshold ()
+  "Age 1s past the 2× threshold is stale."
+  (let ((wttrin-mode-line-refresh-interval 100))
+    (let ((entry (cons (- (float-time) 201) "data")))
+      (should (wttrin--mode-line-stale-p entry)))))
+
+(ert-deftest test-wttrin--mode-line-stale-p-boundary-nil-cache-returns-nil ()
+  "Nil cache-entry returns nil with no signal."
+  (should-not (wttrin--mode-line-stale-p nil)))
+
 (provide 'test-wttrin--mode-line-helpers)
 ;;; test-wttrin--mode-line-helpers.el ends here
-- 
cgit v1.2.3