blob: 742a87252059940e1b9150a521fd4424be8e0767 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
|
;;; test-wttrin-hide-follow-line.el --- Tests for hiding the follow line -*- lexical-binding: t; -*-
;; Copyright (C) 2026 Craig Jennings
;;; Commentary:
;; Unit tests for wttrin--effective-display-options and its effect on
;; wttrin--build-url: the wttr.in F flag is added to the buffer request when
;; wttrin-hide-follow-line is non-nil, composing with wttrin-display-options.
;;; Code:
(require 'ert)
(require 'wttrin)
;;; --------------------------------------------------------------------------
;;; wttrin--effective-display-options
;;; --------------------------------------------------------------------------
;;; Normal Cases
(ert-deftest test-wttrin--effective-display-options-normal-hide-empty-adds-f ()
"Normal: hiding with no other options yields just the F flag."
(let ((wttrin-display-options nil)
(wttrin-hide-follow-line t))
(should (equal (wttrin--effective-display-options) "F"))))
(ert-deftest test-wttrin--effective-display-options-normal-hide-appends-f ()
"Normal: hiding appends F to existing options."
(let ((wttrin-display-options "0q")
(wttrin-hide-follow-line t))
(should (equal (wttrin--effective-display-options) "0qF"))))
(ert-deftest test-wttrin--effective-display-options-normal-no-hide-unchanged ()
"Normal: not hiding leaves the options untouched."
(let ((wttrin-display-options "0q")
(wttrin-hide-follow-line nil))
(should (equal (wttrin--effective-display-options) "0q"))))
;;; Boundary Cases
(ert-deftest test-wttrin--effective-display-options-boundary-f-already-present ()
"Boundary: F already in the options is not duplicated."
(let ((wttrin-display-options "0Fq")
(wttrin-hide-follow-line t))
(should (equal (wttrin--effective-display-options) "0Fq"))))
(ert-deftest test-wttrin--effective-display-options-boundary-no-hide-nil-options ()
"Boundary: not hiding with nil options yields an empty string."
(let ((wttrin-display-options nil)
(wttrin-hide-follow-line nil))
(should (equal (wttrin--effective-display-options) ""))))
;; wttr.in flags are case-sensitive (q and Q differ), and string-match-p
;; honours `case-fold-search', which defaults to t. A lowercase f must not
;; read as the F flag, whatever the caller's case-fold setting is.
(ert-deftest test-wttrin--effective-display-options-boundary-lowercase-f-is-not-f ()
"Boundary: a lowercase f in the options does not count as the F flag."
(let ((wttrin-display-options "0f")
(wttrin-hide-follow-line t)
(case-fold-search t))
(should (equal (wttrin--effective-display-options) "0fF"))))
(ert-deftest test-wttrin--effective-display-options-boundary-case-fold-nil-same-result ()
"Boundary: the result does not depend on the caller's `case-fold-search'."
(let ((wttrin-display-options "0f")
(wttrin-hide-follow-line t)
(case-fold-search nil))
(should (equal (wttrin--effective-display-options) "0fF"))))
;;; Error Cases
(ert-deftest test-wttrin--effective-display-options-error-non-string-options ()
"Error: a non-string options value signals rather than building a bad URL."
(let ((wttrin-display-options 'bogus)
(wttrin-hide-follow-line t))
(should-error (wttrin--effective-display-options) :type 'wrong-type-argument)))
;;; --------------------------------------------------------------------------
;;; wttrin--build-url integration
;;; --------------------------------------------------------------------------
;;; Normal Cases
(ert-deftest test-wttrin--build-url-normal-hide-appends-f-to-url ()
"Normal: hiding the follow line puts the F flag at the end of the URL."
(let ((wttrin-display-options nil)
(wttrin-hide-follow-line t)
(wttrin-unit-system nil))
(should (string-suffix-p "F" (wttrin--build-url "Tokyo")))))
(ert-deftest test-wttrin--build-url-normal-no-hide-no-trailing-f ()
"Normal: with hiding off, the URL does not end in the F flag."
(let ((wttrin-display-options nil)
(wttrin-hide-follow-line nil)
(wttrin-unit-system nil))
(should-not (string-suffix-p "F" (wttrin--build-url "Tokyo")))))
(provide 'test-wttrin-hide-follow-line)
;;; test-wttrin-hide-follow-line.el ends here
|
