From 01b75599a500d6276a962b47744166abb25d846c Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 28 Apr 2026 19:13:05 -0500 Subject: refactor: switch gloss-fetch result to uniform plist shape MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous shape (:ok DEFS) | (:empty :no-defs (...) :failed (...)) was malformed as a plist. The :empty tag at position 0 shifted the plist alignment. plist-get on :no-defs or :failed returned nil. Tests had to use (plist-get (cdr result) ...) as a workaround. The new shape is a uniform plist with all three keys always present: (:defs DEFS :no-defs (SYM ...) :failed (SYM ...)). Consumers branch on whether :defs is non-empty. There is no tag. plist-get works uniformly across success and empty cases. Updated gloss-fetch.el (rollup function and docstrings), 7 test files, and the design doc (docs/design/gloss.org ยง Error Handling). Tested by `make test`. 65 tests pass in 0.36 seconds. --- tests/test-gloss-fetch--libxml-probe.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/test-gloss-fetch--libxml-probe.el') diff --git a/tests/test-gloss-fetch--libxml-probe.el b/tests/test-gloss-fetch--libxml-probe.el index 758c185..1d8b7ed 100644 --- a/tests/test-gloss-fetch--libxml-probe.el +++ b/tests/test-gloss-fetch--libxml-probe.el @@ -57,8 +57,8 @@ (gloss-fetch-test--with-mocked-url (lambda (_url) (gloss-fetch-test--ok-response "{}")) (let ((result (gloss-fetch-definitions "term"))) - (should (eq (car result) :empty)) - (should (member 'wiktionary (plist-get (cdr result) :no-defs)))))))) + (should-not (plist-get result :defs)) + (should (member 'wiktionary (plist-get result :no-defs)))))))) (provide 'test-gloss-fetch--libxml-probe) ;;; test-gloss-fetch--libxml-probe.el ends here -- cgit v1.2.3