| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The :type 'cl-assertion-failed' fix didn't help — Emacs 29.4 in CI
still marks the eight scheduler error tests as failures even though
the cl-assertion-failed signal clearly fires (visible in the
test-failure backtrace).
Whatever ERT's should-error is doing in 29.4, it isn't accepting
the signal as a pass. Replacing should-error with a manual
condition-case wrapped in should sidesteps the fragility — we
just verify SOMETHING was signalled, which is all the test ever
needed.
Extracted as a test-scheduler--should-cl-assert helper macro in
each file (the two test files don't share infrastructure right
now).
Locally green; expected to clear the 29.4 CI failure.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CI on Emacs 29.4 failed eight scheduler :error: tests (5 in
Simple8, 3 in SM5). All eight wrap a function call that violates
a cl-assert precondition and use bare (should-error ...) to catch
the resulting cl-assertion-failed signal.
The same tests pass locally (Emacs 30.2) and in CI on Emacs
snapshot. Hypothesis: in 29.4 cl-assertion-failed isn't registered
with error as a parent class, so the default should-error filter
(which catches type 'error') doesn't match. Adding an explicit
:type 'cl-assertion-failed' tells should-error exactly what
condition to expect, avoiding the inheritance-class question
entirely.
Locally still green; expected to clear the CI failure on the next
push.
|
| |
|
|
| |
The failure-path assertion in the totaln test now expects the count to increment on both success and failure, matching SM2 and SM5. The updated test goes red against the current source. The source fix follows in the next commit.
|
|
|
The Simple8 algorithm at org-drill-determine-next-interval-simple8 had no direct test coverage, completing the trio after SM2 (37 tests) and SM5 (32 tests, just landed). Adds a per-function test file with 34 tests across Normal, Boundary, Error, algorithm-verification, and helper-specific categories.
Simple8-specific surface gets dedicated coverage. The function returns a 6-element list (not 7 like SM2/SM5) and recomputes ease from meanq each call rather than carrying an EF parameter through. Failure does not increment totaln (different from SM2/SM5, which always increment). The four delta-days configurations (nil, positive × flag, negative × flag) each take a distinct code path, including a late-review use-n adjustment that SM5 doesn't have.
The three pure-math helpers (simple8-first-interval, simple8-interval-factor, simple8-quality->ease) get five direct tests so polynomial-coefficient typos can't drift silently.
All 34 pass on first run as characterization. Full suite at 214 of 214 (was 180, +34).
|
