From 5c68f1ed1f59075ac1d4c0262884a5cd7aa25ef6 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Wed, 29 Apr 2026 09:58:30 -0500 Subject: test: expect totaln increment on Simple8 failure path The failure-path assertion in the totaln test now expects the count to increment on both success and failure, matching SM2 and SM5. The updated test goes red against the current source. The source fix follows in the next commit. --- tests/test-org-drill-determine-next-interval-simple8.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/test-org-drill-determine-next-interval-simple8.el b/tests/test-org-drill-determine-next-interval-simple8.el index 55b0d12..6d292bc 100644 --- a/tests/test-org-drill-determine-next-interval-simple8.el +++ b/tests/test-org-drill-determine-next-interval-simple8.el @@ -193,14 +193,15 @@ (should (numberp interval)) (should (> interval 0))))) -(ert-deftest test-org-drill-determine-next-interval-simple8-boundary-totaln-increments-on-success-only () - "Boundary: totaln increments on success but NOT on failure (Simple8-specific)." +(ert-deftest test-org-drill-determine-next-interval-simple8-boundary-totaln-increments-on-both-paths () + "Boundary: totaln increments on both success and failure paths. +This matches the SM2 and SM5 behavior so DRILL_TOTAL_REPEATS counts every +review attempt regardless of which scheduling algorithm produced it." (let* ((totaln 42) (result-success (org-drill-determine-next-interval-simple8 0 0 4 0 nil totaln nil)) (result-failure (org-drill-determine-next-interval-simple8 10 3 0 0 nil totaln nil))) (should (= (test-scheduler--extract-total-repeats result-success) (1+ totaln))) - ;; SM2/SM5 always increment; Simple8 does not on the failure path. - (should (= (test-scheduler--extract-total-repeats result-failure) totaln)))) + (should (= (test-scheduler--extract-total-repeats result-failure) (1+ totaln))))) ;;; Error Cases - cl-assert violations -- cgit v1.2.3