From 1338b2ae757b7143fe4d211fc5a354c73cee526b Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Tue, 26 May 2026 18:09:21 -0500
Subject: chore: coverage, autoload fix, and internal cleanup for org-drill

A batch of test-coverage and hardening work, squashed from the test-work branch.

Tests: deduplicated a colliding leitner-capture test name so make test-name loads again. Added SM2 assert-failure cases, the six basic multicloze variant delegations, the three English-side spanish-verb branches, and org-drill-current-scope branch coverage.

Fix: the entry-point commands (org-drill itself, cram-tree, tree, directory, resume, relearn-item, strip-all-data, merge-buffers) carried no autoload cookies, so M-x failed from a fresh install until something pulled the file in. They're autoloaded now.

Perf: org-drill-shuffle was quadratic because it indexed a list with elt on every swap. It runs a linear Fisher-Yates pass over a vector now, and it checks its argument is a list.

Feat: added org-drill-version, a constant plus an interactive command, so a bug reporter doesn't have to open the file header.

Refactor: extracted org-drill--format-tense-mood, shared by the two verb-conjugation presenters that each carried a copy.

Docs: explained the SM8 magic numbers in the simple8 helpers as empirical fits rather than tunable knobs.
---
 tests/test-org-drill-spanish-and-top-level.el | 42 +++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

(limited to 'tests/test-org-drill-spanish-and-top-level.el')

diff --git a/tests/test-org-drill-spanish-and-top-level.el b/tests/test-org-drill-spanish-and-top-level.el
index 61fc546..465d82f 100644
--- a/tests/test-org-drill-spanish-and-top-level.el
+++ b/tests/test-org-drill-spanish-and-top-level.el
@@ -88,6 +88,48 @@ hablo, hablas, ...
         (org-drill-present-spanish-verb (org-drill-session))
         (should (string-match-p "future perfect" shown-prompt))))))
 
+(ert-deftest test-present-spanish-verb-branch-1-present-tense-conjugate ()
+  "Branch 1 reveals the English side and asks to conjugate the present tense."
+  (with-card-buffer "* Verb :drill:\n** Infinitive\nhablar\n** English\nto speak\n** Present Tense\nfoo\n"
+    (let ((shown-prompt nil))
+      (cl-letf (((symbol-function 'cl-random) (lambda (_) 1))
+                ((symbol-function 'org-drill-presentation-prompt)
+                 (lambda (_session &optional prompt &rest _)
+                   (setq shown-prompt prompt) t))
+                ((symbol-function 'org-drill--show-latex-fragments) #'ignore)
+                ((symbol-function 'org-display-inline-images) #'ignore))
+        (org-drill-present-spanish-verb (org-drill-session))
+        (should (string-match-p "present.* tense" shown-prompt))
+        (should (string-match-p "English verb" shown-prompt))))))
+
+(ert-deftest test-present-spanish-verb-branch-3-past-tense-conjugate ()
+  "Branch 3 reveals the English side and asks to conjugate the past tense."
+  (with-card-buffer "* Verb :drill:\n** Infinitive\nhablar\n** English\nto speak\n** Past Tense\nfoo\n"
+    (let ((shown-prompt nil))
+      (cl-letf (((symbol-function 'cl-random) (lambda (_) 3))
+                ((symbol-function 'org-drill-presentation-prompt)
+                 (lambda (_session &optional prompt &rest _)
+                   (setq shown-prompt prompt) t))
+                ((symbol-function 'org-drill--show-latex-fragments) #'ignore)
+                ((symbol-function 'org-display-inline-images) #'ignore))
+        (org-drill-present-spanish-verb (org-drill-session))
+        (should (string-match-p "past.* tense" shown-prompt))
+        (should (string-match-p "English verb" shown-prompt))))))
+
+(ert-deftest test-present-spanish-verb-branch-5-future-perfect-conjugate ()
+  "Branch 5 reveals the English side and asks to conjugate the future perfect."
+  (with-card-buffer "* Verb :drill:\n** Infinitive\nhablar\n** English\nto speak\n** Future Perfect Tense\nfoo\n"
+    (let ((shown-prompt nil))
+      (cl-letf (((symbol-function 'cl-random) (lambda (_) 5))
+                ((symbol-function 'org-drill-presentation-prompt)
+                 (lambda (_session &optional prompt &rest _)
+                   (setq shown-prompt prompt) t))
+                ((symbol-function 'org-drill--show-latex-fragments) #'ignore)
+                ((symbol-function 'org-display-inline-images) #'ignore))
+        (org-drill-present-spanish-verb (org-drill-session))
+        (should (string-match-p "future perfect" shown-prompt))
+        (should (string-match-p "English verb" shown-prompt))))))
+
 ;;;; org-drill-cram and friends
 
 (ert-deftest test-org-drill-cram-passes-cram-flag ()
-- 
cgit v1.2.3