diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-24 15:01:01 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-24 15:01:01 -0500 |
| commit | 1a26149d4d7f16adb1552ba31a2de290a5c86fc4 (patch) | |
| tree | b61b23fd96ee757e6cc04020532c0717d20b102f /tests/test-pearl-comment-editing.el | |
| parent | 44b7e8e42383a0e2c7024f250c2d16de6b66c652 (diff) | |
| download | pearl-1a26149d4d7f16adb1552ba31a2de290a5c86fc4.tar.gz pearl-1a26149d4d7f16adb1552ba31a2de290a5c86fc4.zip | |
test: cover sync-back push-failure branches at the command level
Added ERT tests that the three sync commands leave provenance untouched when the push fails (:success nil): pearl-sync-current-issue keeps LINEAR-DESC-SHA256 and -UPDATED-AT, pearl-sync-current-issue-title keeps LINEAR-TITLE-SHA256, and pearl-edit-current-comment keeps LINEAR-COMMENT-SHA256 — and in each case the edited text stays in the buffer for retry. Each test asserts the push was attempted with the rendered text. The commands already behave correctly; this locks it. 360 tests green.
Diffstat (limited to 'tests/test-pearl-comment-editing.el')
| -rw-r--r-- | tests/test-pearl-comment-editing.el | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/tests/test-pearl-comment-editing.el b/tests/test-pearl-comment-editing.el index 05a3a76..866366f 100644 --- a/tests/test-pearl-comment-editing.el +++ b/tests/test-pearl-comment-editing.el @@ -214,6 +214,26 @@ (pearl-edit-current-comment) (should-not updated))))) +(ert-deftest test-pearl-edit-comment-push-failure-keeps-hash () + "A failed comment push keeps the stored hash and the edited body for retry." + (test-pearl--in-org (test-pearl--comment-doc "u-me" "old body" "new body") + (let ((pearl--cache-viewer '(:id "u-me" :name "Me")) + (pushed-body nil) + (stored (secure-hash 'sha256 "old body"))) + (cl-letf (((symbol-function 'pearl--fetch-comment-body-async) + (lambda (_id cb) (funcall cb "old body"))) + ((symbol-function 'pearl--update-comment-async) + (lambda (_id body cb) (setq pushed-body body) (funcall cb '(:success nil))))) + (re-search-forward "new body") + (pearl-edit-current-comment) + ;; push attempted with the edited body ... + (should (string= "new body" pushed-body)) + ;; ... but the stored hash is not advanced and the edit stays. + (goto-char (point-min)) + (re-search-forward "^\\*\\*\\*\\*\\* Craig") + (should (string= stored (org-entry-get nil "LINEAR-COMMENT-SHA256"))) + (should (string= "new body" (pearl--issue-body-at-point))))))) + ;;; editability highlighting (ert-deftest test-pearl-highlight-comments-colors-by-editability () |