From 8c42615b09471db089d81b7d702c60917fb85c79 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 26 May 2026 00:31:44 -0500 Subject: feat: resolve a cycled TODO keyword to its Linear state at save Cycling a ticket's TODO keyword (C-c C-t) now counts as a state edit. The dirty scan gains a keyword-cycle arm: state is dirty when the explicit id moved off its baseline (the picker arm, as before) or when the keyword diverged from the synced state name's slug. At save, the picker arm pushes the explicit id; the keyword-cycle arm resolves the keyword to a team state id by slug match, first by position, and pushes that. A keyword no team state matches is reported skipped rather than guessed. set-heading-state now slugifies the keyword instead of the static-map lookup, so the picker writes the same keyword the renderer derives. Without that, a picker edit to a non-standard state would read as permanently cycled. That retires pearl--map-linear-state-to-org, whose only caller this was, and its tests. --- tests/test-pearl-mapping.el | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) (limited to 'tests/test-pearl-mapping.el') diff --git a/tests/test-pearl-mapping.el b/tests/test-pearl-mapping.el index 2a96163..b5faa3d 100644 --- a/tests/test-pearl-mapping.el +++ b/tests/test-pearl-mapping.el @@ -37,27 +37,13 @@ (pearl--todo-states-pattern-source nil)) ,@body)) -;;; pearl--map-linear-state-to-org - -(ert-deftest test-pearl-map-linear-state-to-org-mapped-returns-keyword () - "A Linear state present in the mapping returns its org keyword." - (test-pearl--with-mapping '(("Todo" . "TODO") ("In Progress" . "DOING")) - (should (string-equal "DOING" (pearl--map-linear-state-to-org "In Progress"))))) - -(ert-deftest test-pearl-map-linear-state-to-org-unmapped-defaults-todo () - "An unmapped Linear state falls back to TODO." - (test-pearl--with-mapping '(("Todo" . "TODO") ("Done" . "DONE")) - (should (string-equal "TODO" (pearl--map-linear-state-to-org "Triage"))))) - -(ert-deftest test-pearl-map-linear-state-to-org-nil-defaults-todo () - "A nil state falls back to TODO rather than erroring." - (test-pearl--with-mapping '(("Todo" . "TODO")) - (should (string-equal "TODO" (pearl--map-linear-state-to-org nil))))) - -;; pearl--map-org-state-to-linear (the keyword->state reverse map) was removed -;; with the org-sync push path in save-model-v2; the keyword-cycle save will -;; resolve through the team's states (the keyword-derivation task), not a flat -;; reverse mapping. +;; pearl--map-linear-state-to-org (the static name->keyword lookup) was removed +;; in the keyword-cycle save: the keyword is now always the slug of the state +;; name (`pearl--state-name-to-keyword'), matching the workspace-derived #+TODO +;; header, and the keyword->state-id direction resolves through the team's +;; states (`pearl--resolve-keyword-to-state'), not a flat mapping. The mapping +;; alist itself survives only as the source for `pearl--get-todo-states-pattern' +;; (tested below). ;;; pearl--get-todo-states-pattern -- cgit v1.2.3