From 02d1c7b009f109a83a6c62ae56f4a3a9ba2d21e3 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 26 May 2026 15:06:42 -0500 Subject: refactor: remove the dead state-to-todo mapping subsystem `pearl-state-to-todo-mapping` and its derived regex stopped doing real work once keyword rendering moved to slugifying the Linear state name (`pearl--state-name-to-keyword`) and the keyword-to-state direction moved to resolving through the team's workflow states. The defcustom fed only `pearl--get-todo-states-pattern`, which had no caller left, and the two cache vars existed only to serve that dead function. State extraction reads `org-get-todo-state` off the buffer's `#+TODO` line, so nothing live touched the mapping. I removed the defcustom, both cache vars, and the dead function, and dropped the three pattern tests that exercised it. Removing the defcustom orphaned the mapping bindings that ~12 test setup macros still carried. They were passing through slugification rather than the map, so I stripped them too and kept the `org-todo-keywords` bindings the temp buffers actually need. Also dropped the stale README config row. --- tests/test-pearl-org-parse.el | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'tests/test-pearl-org-parse.el') diff --git a/tests/test-pearl-org-parse.el b/tests/test-pearl-org-parse.el index e0bb967..731f6ef 100644 --- a/tests/test-pearl-org-parse.el +++ b/tests/test-pearl-org-parse.el @@ -30,15 +30,11 @@ (require 'cl-lib) (defmacro test-pearl--in-org (content &rest body) - "Run BODY in an org-mode temp buffer holding CONTENT, default mapping bound." + "Run BODY in an org-mode temp buffer holding CONTENT." (declare (indent 1)) ;; Declare the Linear keywords so `org-get-todo-state' recognizes them, the ;; way the generated file's `#+TODO:' line does in real use. - `(let ((pearl-state-to-todo-mapping - '(("Todo" . "TODO") ("In Progress" . "IN-PROGRESS") ("Done" . "DONE"))) - (pearl-todo-states-pattern nil) - (pearl--todo-states-pattern-source nil) - (org-todo-keywords '((sequence "TODO" "IN-PROGRESS" "|" "DONE")))) + `(let ((org-todo-keywords '((sequence "TODO" "IN-PROGRESS" "|" "DONE")))) (with-temp-buffer (insert ,content) (org-mode) @@ -107,10 +103,7 @@ "An issue rendered by build-org-content parses back through the reader. Locks the render/parse contract: the LINEAR-* drawer the renderer writes is exactly what the reader extracts, and the rendered keyword is recognized." - (let ((pearl-state-to-todo-mapping '(("In Progress" . "IN-PROGRESS"))) - (pearl-todo-states-pattern nil) - (pearl--todo-states-pattern-source nil) - (org-todo-keywords '((sequence "TODO" "IN-PROGRESS" "|" "DONE")))) + (let ((org-todo-keywords '((sequence "TODO" "IN-PROGRESS" "|" "DONE")))) (let ((content (pearl--build-org-content '((:id "i-1" :identifier "ENG-2" :title "round trip" :priority 2 :state (:name "In Progress") :team (:id "t-1")))))) -- cgit v1.2.3