From 60b51e1c996f1c8f152696946b9440f26ea9a956 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Mon, 25 May 2026 21:22:27 -0500 Subject: refactor(save): retire the immediate-push field setters for buffer-editors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The structured fields now reconcile at save (the previous commits), so the immediate-push setters are the duplicate path that made the package feel like it had two save models. I retired them. pearl-set-priority is deleted outright — priority is edited org-natively through the heading cookie. pearl-set-state, pearl-set-assignee, and pearl-set-labels become pearl-edit-state / -assignee / -labels: the same completing-read picker, but it writes the buffer representation (keyword/name/id, the assignee drawer, the labels drawer plus the live LINEAR-LABEL-IDS set) and marks the field dirty instead of pushing. The change goes out at the next pearl-save-issue / pearl-save-all. pearl-compose-current-description is renamed pearl-edit-description (its compose-and-push behavior is unchanged — v2 doesn't touch the compose buffers). The transient, the C-; L e keymap, the affordance preamble, and the README follow the new names, and the priority slots are dropped (no command — it's the org cookie). Deleting the setters left pearl--push-issue-field and pearl--priority-choices with no callers, so both are gone, along with the killed-buffer test that only exercised the removed helper. I filed a follow-up: the atomic savers' async commit callbacks need the same killed-buffer guard that helper carried. The setter command tests are rewritten to assert the buffer-write-and-no-push contract. The reconcile-and-push path they used to cover is exercised in test-pearl-save. --- tests/test-pearl-output.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test-pearl-output.el') diff --git a/tests/test-pearl-output.el b/tests/test-pearl-output.el index 6eafbb4..eb5c671 100644 --- a/tests/test-pearl-output.el +++ b/tests/test-pearl-output.el @@ -52,7 +52,7 @@ (should (string-match-p "^#\\+LINEAR-SOURCE: " out)) (should (string-match-p "^#\\+LINEAR-COUNT: 0$" out)) ;; affordance preamble is present as org comments, not content - (should (string-match-p "^# .*pearl-sync-current-issue" out)))) + (should (string-match-p "^# .*pearl-save-issue" out)))) (ert-deftest test-pearl-build-org-content-source-roundtrips () "The serialized source in the header reads back to the original plist." -- cgit v1.2.3