From 02d1c7b009f109a83a6c62ae56f4a3a9ba2d21e3 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Tue, 26 May 2026 15:06:42 -0500 Subject: refactor: remove the dead state-to-todo mapping subsystem `pearl-state-to-todo-mapping` and its derived regex stopped doing real work once keyword rendering moved to slugifying the Linear state name (`pearl--state-name-to-keyword`) and the keyword-to-state direction moved to resolving through the team's workflow states. The defcustom fed only `pearl--get-todo-states-pattern`, which had no caller left, and the two cache vars existed only to serve that dead function. State extraction reads `org-get-todo-state` off the buffer's `#+TODO` line, so nothing live touched the mapping. I removed the defcustom, both cache vars, and the dead function, and dropped the three pattern tests that exercised it. Removing the defcustom orphaned the mapping bindings that ~12 test setup macros still carried. They were passing through slugification rather than the map, so I stripped them too and kept the `org-todo-keywords` bindings the temp buffers actually need. Also dropped the stale README config row. --- tests/test-pearl-save.el | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'tests/test-pearl-save.el') diff --git a/tests/test-pearl-save.el b/tests/test-pearl-save.el index 22df84e..90e55cd 100644 --- a/tests/test-pearl-save.el +++ b/tests/test-pearl-save.el @@ -43,8 +43,7 @@ ;; `org-entry-put', which in batch makes the cache reconcile pathologically ;; (seconds per call). Disabling it keeps the suite fast and deterministic; ;; production never touches this binding. - `(let ((pearl-state-to-todo-mapping '(("Todo" . "TODO"))) - (pearl-comment-sort-order 'newest-first) + `(let ((pearl-comment-sort-order 'newest-first) (org-element-use-cache nil)) (with-temp-buffer (insert (pearl--format-issue-as-org-entry ,issue)) @@ -734,8 +733,7 @@ description hash is left untouched and the title still saved." (defmacro test-pearl-save--in-two-issues (&rest body) "Render two issues (ENG-1, ENG-2; bodies \"Body.\") and run BODY at point-min." (declare (indent 0)) - `(let ((pearl-state-to-todo-mapping '(("Todo" . "TODO"))) - (pearl-comment-sort-order 'newest-first) + `(let ((pearl-comment-sort-order 'newest-first) (org-element-use-cache nil)) (with-temp-buffer (insert (pearl--format-issue-as-org-entry -- cgit v1.2.3