From f272f2a14c60ef853bb860c0612ad931d5a21d74 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Thu, 29 Jan 2026 12:18:12 -0600
Subject:   Add SSH remote backup support, new commands, and test suite

  - Add remote mode for SSH-based backups to servers like TrueNAS
  - Add SSH_IDENTITY_FILE config for non-root SSH keys
  - Add new commands: backup, status, list, dryrun
  - Add dependency checks for rsync, ssh, flock
  - Add timestamped logging
  - Fix: duplicate cron jobs on repeated setup
  - Fix: use mktemp for temp files
  - Fix: use portable sed instead of grep -oP
  - Fix: strengthen input validation with regex anchors
  - Fix: handle paths with spaces (newline-separated includes)
  - Change license from MIT to GPL v3
  - Add automated test suite (25 tests)
  - Update README with new features and testing docs
---
 tests/cases/test_cron.sh | 138 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 138 insertions(+)
 create mode 100755 tests/cases/test_cron.sh

(limited to 'tests/cases/test_cron.sh')

diff --git a/tests/cases/test_cron.sh b/tests/cases/test_cron.sh
new file mode 100755
index 0000000..2fdb6f5
--- /dev/null
+++ b/tests/cases/test_cron.sh
@@ -0,0 +1,138 @@
+#!/usr/bin/env bash
+# ==============================================================================
+# Cron Job Management Tests
+# ==============================================================================
+
+source "$(dirname "${BASH_SOURCE[0]}")/../lib/test_helpers.sh"
+
+# Save original crontab to restore later
+ORIGINAL_CRONTAB=""
+
+save_crontab() {
+    ORIGINAL_CRONTAB=$(crontab -l 2>/dev/null || true)
+}
+
+restore_crontab() {
+    if [ -n "$ORIGINAL_CRONTAB" ]; then
+        echo "$ORIGINAL_CRONTAB" | crontab -
+    else
+        crontab -r 2>/dev/null || true
+    fi
+}
+
+# ------------------------------------------------------------------------------
+# Test: Setup adds cron jobs
+# ------------------------------------------------------------------------------
+test_setup_adds_cron_jobs() {
+    setup_test_env
+    save_crontab
+
+    # Clear existing crontab
+    crontab -r 2>/dev/null || true
+
+    # Create minimal config
+    cat > "$TEST_CONFIG_DIR/config" << EOF
+REMOTE_HOST=""
+MOUNTDIR="$TEST_BACKUP_DIR"
+EOF
+    create_test_includes
+    create_test_excludes
+
+    # Run setup (will fail on some checks but should still add cron)
+    sudo INSTALLHOME="$TEST_CONFIG_DIR" SCRIPTLOC="/tmp/rsyncshot-test" RSYNCSHOT_SKIP_MOUNT_CHECK=1 "$SCRIPT_PATH" setup 2>&1 >/dev/null || true
+
+    # Check crontab contains rsyncshot entries
+    local crontab_content
+    crontab_content=$(crontab -l 2>/dev/null)
+
+    restore_crontab
+    teardown_test_env
+
+    assert_contains "$crontab_content" "rsyncshot" "crontab should contain rsyncshot" || return 1
+    assert_contains "$crontab_content" "hourly" "crontab should contain hourly job" || return 1
+    assert_contains "$crontab_content" "daily" "crontab should contain daily job" || return 1
+    assert_contains "$crontab_content" "weekly" "crontab should contain weekly job" || return 1
+}
+
+# ------------------------------------------------------------------------------
+# Test: Repeated setup doesn't duplicate entries
+# ------------------------------------------------------------------------------
+test_no_duplicate_cron_entries() {
+    setup_test_env
+    save_crontab
+
+    # Clear existing crontab
+    crontab -r 2>/dev/null || true
+
+    cat > "$TEST_CONFIG_DIR/config" << EOF
+REMOTE_HOST=""
+MOUNTDIR="$TEST_BACKUP_DIR"
+EOF
+    create_test_includes
+    create_test_excludes
+
+    # Run setup twice
+    sudo INSTALLHOME="$TEST_CONFIG_DIR" SCRIPTLOC="/tmp/rsyncshot-test" RSYNCSHOT_SKIP_MOUNT_CHECK=1 "$SCRIPT_PATH" setup 2>&1 >/dev/null || true
+    sudo INSTALLHOME="$TEST_CONFIG_DIR" SCRIPTLOC="/tmp/rsyncshot-test" RSYNCSHOT_SKIP_MOUNT_CHECK=1 "$SCRIPT_PATH" setup 2>&1 >/dev/null || true
+
+    # Count rsyncshot entries
+    local crontab_content hourly_count
+    crontab_content=$(crontab -l 2>/dev/null)
+    hourly_count=$(echo "$crontab_content" | grep -c "hourly" || echo 0)
+
+    restore_crontab
+    teardown_test_env
+
+    # Should only have 1 hourly entry, not 2
+    assert_equals "1" "$hourly_count" "should have exactly 1 hourly entry after repeated setup" || return 1
+}
+
+# ------------------------------------------------------------------------------
+# Test: Setup preserves existing cron jobs
+# ------------------------------------------------------------------------------
+test_preserves_existing_cron() {
+    setup_test_env
+    save_crontab
+
+    # Add a custom cron job
+    (crontab -l 2>/dev/null || true; echo "0 5 * * * /custom/job.sh") | crontab -
+
+    cat > "$TEST_CONFIG_DIR/config" << EOF
+REMOTE_HOST=""
+MOUNTDIR="$TEST_BACKUP_DIR"
+EOF
+    create_test_includes
+    create_test_excludes
+
+    # Run setup
+    sudo INSTALLHOME="$TEST_CONFIG_DIR" SCRIPTLOC="/tmp/rsyncshot-test" RSYNCSHOT_SKIP_MOUNT_CHECK=1 "$SCRIPT_PATH" setup 2>&1 >/dev/null || true
+
+    # Check custom job still exists
+    local crontab_content
+    crontab_content=$(crontab -l 2>/dev/null)
+
+    restore_crontab
+    teardown_test_env
+
+    assert_contains "$crontab_content" "/custom/job.sh" "should preserve existing cron jobs" || return 1
+    assert_contains "$crontab_content" "rsyncshot" "should also have rsyncshot jobs" || return 1
+}
+
+# ------------------------------------------------------------------------------
+# Run tests
+# ------------------------------------------------------------------------------
+run_cron_tests() {
+    echo ""
+    echo "Running cron tests..."
+    echo "------------------------------------------------------------"
+
+    run_test "setup adds cron jobs" test_setup_adds_cron_jobs
+    run_test "repeated setup doesn't duplicate entries" test_no_duplicate_cron_entries
+    run_test "setup preserves existing cron jobs" test_preserves_existing_cron
+}
+
+# Run if executed directly
+if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
+    run_cron_tests
+    print_summary
+fi
-- 
cgit v1.2.3