From ddf48dc7ac780da1aacdff4e03f1d7da255b8f39 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sun, 31 May 2026 12:19:34 -0500 Subject: feat: add rename-ai-artifact tool and rename the drill-deck family to flashcard Renaming an .ai artifact by hand is the kind of mechanical job that gets done incompletely: the canonical copy moves but the mirror doesn't, a reference in the INDEX is missed, a trigger phrase points at the old name. I'd also assumed a rename was costly because references scatter, when the index update is trivial and the drift check already guards it. So I built the discipline into a script instead of re-deriving it each time. scripts/rename-ai-artifact.sh takes old and new basenames, moves the file in both the canonical and mirror trees, and rewrites every reference repo-wide on a token boundary so renaming "foo" can't corrupt "foobar" or "foo-bar". It rewrites the underscore module-name variant too (a hyphenated script imported as foo_bar via importlib), leaves the archived session records under sessions/ alone because they're history, and runs workflow-integrity + sync-check at the end to prove no drift. rename-artifact.org documents it and indexes the triggers. Then I used the tool to do the rename that prompted it: the org-drill deck workflow and its helpers are now flashcard-named, since "flashcard" is the word you'd actually search for. The renamed set is flashcard-review.org plus flashcard-stats.py, flashcard-sync, flashcard-to-anki.py, and flashcard-diff-ids.py, with their tests, every reference, and the INDEX entry updated. The deck is still an org-drill deck under the hood, so the ":drill:" tag handling and the "drill deck" trigger phrases stay. I added "review/update the flashcards" alongside them. Tests: 9 bats for the rename tool (including the prefix-collision and history-preservation edges), and the renamed script suites all pass under make test. --- .ai/scripts/tests/drill-deck-sync.bats | 38 --- .ai/scripts/tests/flashcard-sync.bats | 38 +++ .ai/scripts/tests/test_drill_deck_diff_ids.py | 109 -------- .ai/scripts/tests/test_drill_deck_stats.py | 379 -------------------------- .ai/scripts/tests/test_drill_to_anki.py | 171 ------------ .ai/scripts/tests/test_flashcard_diff_ids.py | 109 ++++++++ .ai/scripts/tests/test_flashcard_stats.py | 379 ++++++++++++++++++++++++++ .ai/scripts/tests/test_flashcard_to_anki.py | 171 ++++++++++++ 8 files changed, 697 insertions(+), 697 deletions(-) delete mode 100644 .ai/scripts/tests/drill-deck-sync.bats create mode 100644 .ai/scripts/tests/flashcard-sync.bats delete mode 100644 .ai/scripts/tests/test_drill_deck_diff_ids.py delete mode 100644 .ai/scripts/tests/test_drill_deck_stats.py delete mode 100644 .ai/scripts/tests/test_drill_to_anki.py create mode 100644 .ai/scripts/tests/test_flashcard_diff_ids.py create mode 100644 .ai/scripts/tests/test_flashcard_stats.py create mode 100644 .ai/scripts/tests/test_flashcard_to_anki.py (limited to '.ai/scripts/tests') diff --git a/.ai/scripts/tests/drill-deck-sync.bats b/.ai/scripts/tests/drill-deck-sync.bats deleted file mode 100644 index e141cab..0000000 --- a/.ai/scripts/tests/drill-deck-sync.bats +++ /dev/null @@ -1,38 +0,0 @@ -#!/usr/bin/env bats -# Tests for the drill-deck-sync wrapper: argument handling + the stats gate. -# The clean end-to-end path runs drill-to-anki.py (uv-resolved genanki) and is -# not exercised here; these cover the guard paths that stop before that step. - -setup() { - SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)" - SYNC="$SCRIPT_DIR/drill-deck-sync" - TMP="$(mktemp -d)" -} - -teardown() { - rm -rf "$TMP" -} - -@test "drill-deck-sync: no args exits 2" { - run "$SYNC" - [ "$status" -eq 2 ] -} - -@test "drill-deck-sync: missing source file exits 2" { - run "$SYNC" "$TMP/nope.org" - [ "$status" -eq 2 ] -} - -@test "drill-deck-sync: stats gate failure exits 1 and writes no apkg" { - cat > "$TMP/dirty.org" <<'EOF' -#+TITLE: DeepSat Org-Drill Flashcards - -* Section -** DeepSat :drill: -*** Answer -A satellite company. -EOF - run "$SYNC" "$TMP/dirty.org" - [ "$status" -eq 1 ] - [ ! -f "$HOME/sync/phone/anki/dirty.apkg" ] -} diff --git a/.ai/scripts/tests/flashcard-sync.bats b/.ai/scripts/tests/flashcard-sync.bats new file mode 100644 index 0000000..608a280 --- /dev/null +++ b/.ai/scripts/tests/flashcard-sync.bats @@ -0,0 +1,38 @@ +#!/usr/bin/env bats +# Tests for the flashcard-sync wrapper: argument handling + the stats gate. +# The clean end-to-end path runs flashcard-to-anki.py (uv-resolved genanki) and is +# not exercised here; these cover the guard paths that stop before that step. + +setup() { + SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)" + SYNC="$SCRIPT_DIR/flashcard-sync" + TMP="$(mktemp -d)" +} + +teardown() { + rm -rf "$TMP" +} + +@test "flashcard-sync: no args exits 2" { + run "$SYNC" + [ "$status" -eq 2 ] +} + +@test "flashcard-sync: missing source file exits 2" { + run "$SYNC" "$TMP/nope.org" + [ "$status" -eq 2 ] +} + +@test "flashcard-sync: stats gate failure exits 1 and writes no apkg" { + cat > "$TMP/dirty.org" <<'EOF' +#+TITLE: DeepSat Org-Drill Flashcards + +* Section +** DeepSat :drill: +*** Answer +A satellite company. +EOF + run "$SYNC" "$TMP/dirty.org" + [ "$status" -eq 1 ] + [ ! -f "$HOME/sync/phone/anki/dirty.apkg" ] +} diff --git a/.ai/scripts/tests/test_drill_deck_diff_ids.py b/.ai/scripts/tests/test_drill_deck_diff_ids.py deleted file mode 100644 index 15fb148..0000000 --- a/.ai/scripts/tests/test_drill_deck_diff_ids.py +++ /dev/null @@ -1,109 +0,0 @@ -"""Tests for drill-deck-diff-ids.py: :ID: extraction + SRS-state diff CLI. - -Plain python3 script (no third-party deps), so card_id_map imports directly; -the disappeared/appeared reporting is exercised through the CLI. -""" -from __future__ import annotations - -import importlib.util -import subprocess -import sys -from pathlib import Path - -import pytest - -SCRIPT = Path(__file__).resolve().parents[1] / "drill-deck-diff-ids.py" - - -@pytest.fixture(scope="module") -def diff_ids(): - spec = importlib.util.spec_from_file_location("drill_deck_diff_ids", SCRIPT) - assert spec and spec.loader - module = importlib.util.module_from_spec(spec) - spec.loader.exec_module(module) - return module - - -DECK_A = """* Section -** What is DeepSat? :drill: -:PROPERTIES: -:ID: id-1 -:END: -Body. -** Who founded it? :drill: -:PROPERTIES: -:ID: id-2 -:END: -Body. -""" - -# id-2 dropped, id-3 added relative to DECK_A -DECK_B = """* Section -** What is DeepSat? :drill: -:PROPERTIES: -:ID: id-1 -:END: -Body. -** When was it founded? :drill: -:PROPERTIES: -:ID: id-3 -:END: -Body. -""" - - -def test_card_id_map_extracts_id_to_heading(diff_ids, tmp_path): - f = tmp_path / "a.org" - f.write_text(DECK_A) - m = diff_ids.card_id_map(f) - assert set(m) == {"id-1", "id-2"} - assert m["id-1"] == "What is DeepSat?" - - -def _run(before, after): - return subprocess.run( - [sys.executable, str(SCRIPT), str(before), str(after)], - capture_output=True, text=True, - ) - - -def test_cli_identical_decks_exit_zero(tmp_path): - a = tmp_path / "a.org" - a.write_text(DECK_A) - b = tmp_path / "b.org" - b.write_text(DECK_A) - r = _run(a, b) - assert r.returncode == 0 - assert "preserved" in r.stdout.lower() - - -def test_cli_dropped_id_warns_and_exits_one(tmp_path): - a = tmp_path / "a.org" - a.write_text(DECK_A) - b = tmp_path / "b.org" - b.write_text(DECK_B) - r = _run(a, b) - assert r.returncode == 1 - assert "disappeared" in r.stdout.lower() - assert "id-2" in r.stdout - - -DECK_ONE = """* Section -** What is DeepSat? :drill: -:PROPERTIES: -:ID: id-1 -:END: -Body. -""" - - -def test_cli_appeared_only_notes_new_ids_and_exits_one(tmp_path): - # before has id-1; after adds id-2 and drops nothing. - before = tmp_path / "before.org" - before.write_text(DECK_ONE) - after = tmp_path / "after.org" - after.write_text(DECK_A) - r = _run(before, after) - assert r.returncode == 1 - assert "appeared" in r.stdout.lower() - assert "id-2" in r.stdout diff --git a/.ai/scripts/tests/test_drill_deck_stats.py b/.ai/scripts/tests/test_drill_deck_stats.py deleted file mode 100644 index d60084d..0000000 --- a/.ai/scripts/tests/test_drill_deck_stats.py +++ /dev/null @@ -1,379 +0,0 @@ -"""Tests for drill-deck-stats.py: prompt-form heuristic + CLI inventory/gate. - -Plain python3 script (no third-party deps), so the pure helper imports directly; -the inventory/gate behavior is exercised through the CLI. -""" -from __future__ import annotations - -import importlib.util -import subprocess -import sys -from pathlib import Path - -import pytest - -SCRIPT = Path(__file__).resolve().parents[1] / "drill-deck-stats.py" - - -@pytest.fixture(scope="module") -def stats(): - spec = importlib.util.spec_from_file_location("drill_deck_stats", SCRIPT) - assert spec and spec.loader - module = importlib.util.module_from_spec(spec) - spec.loader.exec_module(module) - return module - - -# --- is_prompt_form (pure) --- - -def test_is_prompt_form_question_mark(stats): - assert stats.is_prompt_form("What is DeepSat?") is True - - -def test_is_prompt_form_imperative_verb(stats): - assert stats.is_prompt_form("Spell out the orbital regimes") is True - - -def test_is_prompt_form_imperative_is_case_insensitive(stats): - assert stats.is_prompt_form("introduce yourself") is True - - -def test_is_prompt_form_topic_heading_is_not_a_prompt(stats): - assert stats.is_prompt_form("DeepSat") is False - - -def test_is_prompt_form_strips_trailing_punctuation_off_first_word(stats): - assert stats.is_prompt_form("List: the founders") is True - - -# --- CLI inventory + gate (integration) --- - -CLEAN_DECK = """#+TITLE: DeepSat Flashcards - -* Section -** What is DeepSat? :drill: -:PROPERTIES: -:ID: card-1 -:END: -A satellite company. -""" - -DIRTY_DECK = """#+TITLE: DeepSat Org-Drill Flashcards - -* Section -** DeepSat :drill: -*** Answer -A satellite company. -""" - - -def _run(path): - return subprocess.run( - [sys.executable, str(SCRIPT), str(path)], - capture_output=True, text=True, - ) - - -def test_cli_clean_deck_exits_zero(tmp_path): - f = tmp_path / "clean.org" - f.write_text(CLEAN_DECK) - r = _run(f) - assert r.returncode == 0 - assert "clean" in r.stdout - - -def test_cli_dirty_deck_warns_and_exits_one(tmp_path): - f = tmp_path / "dirty.org" - f.write_text(DIRTY_DECK) - r = _run(f) - assert r.returncode == 1 - assert "WARN" in r.stdout - assert "org-drill" in r.stdout.lower() # title-jargon audit fired - - -def test_cli_missing_file_exits_two(tmp_path): - r = _run(tmp_path / "nope.org") - assert r.returncode == 2 - - -NO_TITLE_DECK = """* Section -** What is DeepSat? :drill: -:PROPERTIES: -:ID: card-1 -:END: -A satellite company. -""" - -# Two cards, only one PROPERTIES drawer. -PROP_MISMATCH_DECK = """#+TITLE: DeepSat Flashcards - -* Section -** What is DeepSat? :drill: -A satellite company. -** Who founded it? :drill: -:PROPERTIES: -:ID: card-2 -:END: -The team. -""" - - -def test_cli_missing_title_warns_and_exits_one(tmp_path): - f = tmp_path / "notitle.org" - f.write_text(NO_TITLE_DECK) - r = _run(f) - assert r.returncode == 1 - assert "no #+TITLE" in r.stdout - - -def test_cli_properties_count_mismatch_warns_and_exits_one(tmp_path): - f = tmp_path / "mismatch.org" - f.write_text(PROP_MISMATCH_DECK) - r = _run(f) - assert r.returncode == 1 - assert "does not match card count" in r.stdout - - -# --- content_words / leakage_ratio (pure) --- - -def test_content_words_drops_stopwords_and_short_tokens(stats): - assert stats.content_words("What is the LEO regime?") == {"leo", "regime"} - - -def test_leakage_ratio_high_when_answer_restates_question(stats): - ratio = stats.leakage_ratio( - "primary orbital regimes satellites", - "the primary orbital regimes for satellites are listed", - ) - assert ratio == 1.0 - - -def test_leakage_ratio_zero_for_short_question(stats): - # "LEO" is the only content word, below LEAKAGE_MIN_WORDS, so overlap is noise. - assert stats.leakage_ratio("What is LEO?", "LEO means low earth orbit") == 0.0 - - -# --- normalize_heading (pure) --- - -def test_normalize_heading_lowercases_and_strips_punctuation(stats): - assert stats.normalize_heading(" What is L.E.O.? ") == "what is l e o" - - -def test_normalize_heading_collisions_match(stats): - assert stats.normalize_heading("What is LEO?") == stats.normalize_heading("what is leo") - - -# --- is_binary_prompt (pure) --- - -def test_is_binary_prompt_true_for_yes_no_lead(stats): - assert stats.is_binary_prompt("Is LEO below GEO?") is True - - -def test_is_binary_prompt_true_for_a_or_b(stats): - assert stats.is_binary_prompt("Is it LEO or GEO?") is True - - -def test_is_binary_prompt_false_for_open_question(stats): - assert stats.is_binary_prompt("What distinguishes LEO from GEO?") is False - - -# --- back_word_count / is_list_back (pure) --- - -def test_back_word_count(stats): - assert stats.back_word_count("one two three") == 3 - assert stats.back_word_count("") == 0 - - -def test_is_list_back_true_for_bulleted_body(stats): - assert stats.is_list_back("- LEO\n- MEO\n- GEO") is True - - -def test_is_list_back_false_for_prose(stats): - assert stats.is_list_back("Low Earth Orbit.\nThe closest regime.") is False - - -def test_is_list_back_false_for_single_bullet(stats): - assert stats.is_list_back("- only one bullet\nplain prose line") is False - - -# --- parse_cards (pure) --- - -def test_parse_cards_captures_body_without_drawer_planning_or_answer_header(stats): - text = ( - "* Sec\n" - "** Q one? :drill:\n" - ":PROPERTIES:\n:ID: id-1\n:END:\n" - "SCHEDULED: <2026-05-20 Wed>\n" - "*** Answer\n" - "the real answer\n" - ) - cards, prop_count = stats.parse_cards(text.splitlines()) - assert prop_count == 1 - assert len(cards) == 1 - c = cards[0] - assert c["heading"] == "Q one?" - assert c["has_id"] is True - assert c["has_answer"] is True - assert c["body"] == "the real answer" - - -def test_find_duplicate_fronts_matches_normalized_headings(stats): - cards = [ - {"heading": "What is LEO?"}, - {"heading": "what is leo?"}, - {"heading": "What is GEO?"}, - ] - dups = stats.find_duplicate_fronts(cards) - assert len(dups) == 1 - assert dups[0] == ("What is LEO?", "what is leo?") - - -# --- CLI: new blocking checks --- - -LEAKY_DECK = """#+TITLE: Test Flashcards - -* Section -** What are the primary orbital regimes for satellites? :drill: -:PROPERTIES: -:ID: c1 -:END: -The primary orbital regimes for satellites are listed here. -""" - -DUP_FRONT_DECK = """#+TITLE: Test Flashcards - -* Section -** What is LEO? :drill: -:PROPERTIES: -:ID: c1 -:END: -Low Earth Orbit. -** What is LEO? :drill: -:PROPERTIES: -:ID: c2 -:END: -Low Earth Orbit, restated. -""" - - -def test_cli_answer_leakage_warns_and_exits_one(tmp_path): - f = tmp_path / "leaky.org" - f.write_text(LEAKY_DECK) - r = _run(f) - assert r.returncode == 1 - assert "leak" in r.stdout.lower() - - -def test_cli_duplicate_front_warns_and_exits_one(tmp_path): - f = tmp_path / "dup.org" - f.write_text(DUP_FRONT_DECK) - r = _run(f) - assert r.returncode == 1 - assert "duplicate" in r.stdout.lower() - - -# --- CLI: non-blocking NOTEs keep exit 0 --- - -NOTES_DECK = """#+TITLE: Test Flashcards - -* Section -** Is LEO closer than GEO? :drill: -:PROPERTIES: -:ID: c1 -:END: -Yes, much closer. -** What orbital regimes exist? :drill: -:PROPERTIES: -:ID: c2 -:END: -- LEO -- MEO -- GEO -** Describe the platform elements in full :drill: -:PROPERTIES: -:ID: c3 -:END: -The platform carries power generation, propulsion, attitude control, thermal regulation, and radio hardware arranged around a central frame. Each element draws from shared resources and must survive launch loads, vacuum, and radiation. Engineers trade mass against capability when every kilogram raises cost, so redundancy is added only where a single failure would end the mission entirely and cheaper options cannot cover the same risk. -""" - - -def test_cli_non_blocking_notes_keep_exit_zero(tmp_path): - f = tmp_path / "notes.org" - f.write_text(NOTES_DECK) - r = _run(f) - assert r.returncode == 0 - assert "NOTE" in r.stdout - - -# --- leakage refinements: source-line strip + numeric carve-out --- - -def test_prose_body_strips_source_and_created_lines(stats): - body = "The real answer here.\nCreated: 2026-05-30\nSource: AHA — https://heart.org/x" - assert stats.prose_body(body) == "The real answer here." - - -def test_has_distinct_numeric_recall_true_for_range_card(stats): - assert stats.has_distinct_numeric_recall( - "What are the HbA1c ranges across normal, prediabetes, and diabetes?", - "Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%.", - ) is True - - -def test_has_distinct_numeric_recall_false_without_numbers(stats): - assert stats.has_distinct_numeric_recall("What is LEO?", "Low Earth Orbit.") is False - - -def test_is_leaky_false_when_overlap_is_only_in_the_source_line(stats): - heading = "What blood pressure constitutes a hypertensive crisis?" - body = ("A reading at or above 180/120.\n" - "Source: AHA — https://heart.org/high-blood-pressure/hypertensive-crisis") - assert stats.is_leaky(heading, body) is False - - -def test_is_leaky_false_for_numeric_range_card(stats): - heading = "What are the HbA1c ranges across normal, prediabetes, and diabetes?" - body = "HbA1c ranges. Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%." - assert stats.is_leaky(heading, body) is False - - -def test_is_leaky_true_for_genuine_restatement(stats): - heading = "primary orbital regimes satellites classification" - body = "The primary orbital regimes satellites classification scheme." - assert stats.is_leaky(heading, body) is True - - -SOURCE_LINE_DECK = """#+TITLE: Test Flashcards - -* Section -** What blood pressure constitutes a hypertensive crisis? :drill: -:PROPERTIES: -:ID: c1 -:END: -A reading at or above 180/120. - -Source: AHA — https://heart.org/high-blood-pressure/hypertensive-crisis-blood-pressure -""" - -RANGE_CARD_DECK = """#+TITLE: Test Flashcards - -* Section -** What are the HbA1c ranges across normal, prediabetes, and diabetes? :drill: -:PROPERTIES: -:ID: c1 -:END: -HbA1c ranges. Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%. -""" - - -def test_cli_source_line_overlap_is_not_flagged(tmp_path): - f = tmp_path / "source.org" - f.write_text(SOURCE_LINE_DECK) - r = _run(f) - assert r.returncode == 0 - - -def test_cli_numeric_range_card_is_not_flagged(tmp_path): - f = tmp_path / "range.org" - f.write_text(RANGE_CARD_DECK) - r = _run(f) - assert r.returncode == 0 diff --git a/.ai/scripts/tests/test_drill_to_anki.py b/.ai/scripts/tests/test_drill_to_anki.py deleted file mode 100644 index fc17817..0000000 --- a/.ai/scripts/tests/test_drill_to_anki.py +++ /dev/null @@ -1,171 +0,0 @@ -"""Tests for drill-to-anki.py default-path and deck-name helpers. - -The script is a PEP 723 uv-run script that imports genanki, which uv resolves -at runtime but isn't installed in the test environment. The fixture stubs -genanki in sys.modules so the module loads; the pure helpers under test never -call into it. -""" -from __future__ import annotations - -import importlib.util -import sys -import types -from pathlib import Path - -import pytest - -SCRIPT = Path(__file__).resolve().parents[1] / "drill-to-anki.py" - - -@pytest.fixture(scope="module") -def drill(): - # Only stub when genanki is genuinely absent, so a real install isn't shadowed. - sys.modules.setdefault("genanki", types.ModuleType("genanki")) - spec = importlib.util.spec_from_file_location("drill_to_anki", SCRIPT) - assert spec and spec.loader - module = importlib.util.module_from_spec(spec) - spec.loader.exec_module(module) - return module - - -def test_default_output_path_targets_phone_anki_dir(drill): - """The .apkg is a phone artifact, so it defaults under sync/phone/anki/.""" - result = drill.default_output_path(Path("/home/x/projects/health/health-drill.org")) - assert result == Path.home() / "sync" / "phone" / "anki" / "health-drill.apkg" - - -def test_default_deck_name_is_raw_basename(drill): - """Deck name is the input basename with case preserved; #+TITLE is ignored.""" - assert drill.default_deck_name(Path("/x/deepsat.org")) == "deepsat" - - -def test_default_deck_name_keeps_hyphens(drill): - """A hyphenated basename is kept verbatim rather than title-cased.""" - assert drill.default_deck_name(Path("/x/health-drill.org")) == "health-drill" - - -# --- section_to_tag (pure) --- - -def test_section_to_tag_slugifies_words(drill): - assert drill.section_to_tag("Orbital Regimes") == "orbital-regimes" - - -def test_section_to_tag_strips_leading_and_trailing_nonalnum(drill): - assert drill.section_to_tag(" People & Roles! ") == "people-roles" - - -def test_section_to_tag_empty_string(drill): - assert drill.section_to_tag("") == "" - - -# --- escape_html (pure) --- - -def test_escape_html_escapes_amp_lt_gt(drill): - assert drill.escape_html("a & b < c > d") == "a & b < c > d" - - -def test_escape_html_plain_text_unchanged(drill): - assert drill.escape_html("plain text") == "plain text" - - -def test_escape_html_escapes_amp_first_so_existing_entity_is_literal(drill): - # & is replaced before < / >, so a literal "<" becomes "&lt;", - # not silently treated as an already-escaped entity. - assert drill.escape_html("<") == "&lt;" - - -def test_escape_html_empty_string(drill): - assert drill.escape_html("") == "" - - -# --- stable_id (pure) --- - -def test_stable_id_is_deterministic(drill): - assert drill.stable_id("DeepSat", "deck") == drill.stable_id("DeepSat", "deck") - - -def test_stable_id_salt_changes_the_result(drill): - assert drill.stable_id("DeepSat", "deck") != drill.stable_id("DeepSat", "model") - - -def test_stable_id_stays_within_the_reserved_range(drill): - value = drill.stable_id("anything", "deck") - assert drill.ID_BASE <= value < drill.ID_BASE + drill.ID_RANGE - - -# --- strip_org_metadata (pure) --- - -def test_strip_org_metadata_drops_properties_drawer(drill): - body = [":PROPERTIES:", ":ID: x", ":END:", "real content"] - assert drill.strip_org_metadata(body) == ["real content"] - - -def test_strip_org_metadata_drops_planning_lines(drill): - body = ["SCHEDULED: <2026-05-30>", "DEADLINE: <2026-06-01>", - "CLOSED: [2026-05-29]", "body"] - assert drill.strip_org_metadata(body) == ["body"] - - -def test_strip_org_metadata_leaves_plain_body_unchanged(drill): - body = ["line one", "line two"] - assert drill.strip_org_metadata(body) == ["line one", "line two"] - - -def test_strip_org_metadata_empty_list(drill): - assert drill.strip_org_metadata([]) == [] - - -def test_strip_org_metadata_unclosed_drawer_swallows_the_rest(drill): - # An unterminated :PROPERTIES: drawer consumes everything after it. - body = [":PROPERTIES:", ":ID: x", "still in drawer"] - assert drill.strip_org_metadata(body) == [] - - -def test_strip_org_metadata_drops_created_date_line(drill): - # A created/added date never belongs on a card back. - assert drill.strip_org_metadata(["Created: 2026-05-30", "real answer"]) == ["real answer"] - - -# --- parse (pure, core parser) --- - -SECTIONED = """* Orbital Regimes -** What is LEO? :drill: -Low Earth Orbit. -** What is GEO? :drill: -Geostationary Earth Orbit. -""" - - -def test_parse_returns_front_back_tag_per_card(drill): - cards = drill.parse(SECTIONED) - assert len(cards) == 2 - assert cards[0] == ("What is LEO?", "Low Earth Orbit.", "orbital-regimes") - assert cards[1][0] == "What is GEO?" - - -def test_parse_card_without_a_section_gets_the_drill_tag(drill): - assert drill.parse("** Lone card? :drill:\nbody\n") == [("Lone card?", "body", "drill")] - - -def test_parse_strips_properties_drawer_from_back(drill): - text = "** Q? :drill:\n:PROPERTIES:\n:ID: abc\n:END:\nThe answer.\n" - assert drill.parse(text) == [("Q?", "The answer.", "drill")] - - -def test_parse_trims_leading_and_trailing_blank_body_lines(drill): - cards = drill.parse("** Q? :drill:\n\n\nanswer\n\n\n") - assert cards[0][1] == "answer" - - -def test_parse_card_with_only_a_drawer_has_empty_back(drill): - text = "** Q? :drill:\n:PROPERTIES:\n:ID: x\n:END:\n" - assert drill.parse(text) == [("Q?", "", "drill")] - - -def test_parse_joins_multiline_body_with_br(drill): - cards = drill.parse("** Q? :drill:\nline one\nline two\n") - assert cards[0][1] == "line one
line two" - - -def test_parse_no_drill_cards_returns_empty(drill): - assert drill.parse("* Section\nno drill cards here\n") == [] diff --git a/.ai/scripts/tests/test_flashcard_diff_ids.py b/.ai/scripts/tests/test_flashcard_diff_ids.py new file mode 100644 index 0000000..9554b48 --- /dev/null +++ b/.ai/scripts/tests/test_flashcard_diff_ids.py @@ -0,0 +1,109 @@ +"""Tests for flashcard-diff-ids.py: :ID: extraction + SRS-state diff CLI. + +Plain python3 script (no third-party deps), so card_id_map imports directly; +the disappeared/appeared reporting is exercised through the CLI. +""" +from __future__ import annotations + +import importlib.util +import subprocess +import sys +from pathlib import Path + +import pytest + +SCRIPT = Path(__file__).resolve().parents[1] / "flashcard-diff-ids.py" + + +@pytest.fixture(scope="module") +def diff_ids(): + spec = importlib.util.spec_from_file_location("flashcard_diff_ids", SCRIPT) + assert spec and spec.loader + module = importlib.util.module_from_spec(spec) + spec.loader.exec_module(module) + return module + + +DECK_A = """* Section +** What is DeepSat? :drill: +:PROPERTIES: +:ID: id-1 +:END: +Body. +** Who founded it? :drill: +:PROPERTIES: +:ID: id-2 +:END: +Body. +""" + +# id-2 dropped, id-3 added relative to DECK_A +DECK_B = """* Section +** What is DeepSat? :drill: +:PROPERTIES: +:ID: id-1 +:END: +Body. +** When was it founded? :drill: +:PROPERTIES: +:ID: id-3 +:END: +Body. +""" + + +def test_card_id_map_extracts_id_to_heading(diff_ids, tmp_path): + f = tmp_path / "a.org" + f.write_text(DECK_A) + m = diff_ids.card_id_map(f) + assert set(m) == {"id-1", "id-2"} + assert m["id-1"] == "What is DeepSat?" + + +def _run(before, after): + return subprocess.run( + [sys.executable, str(SCRIPT), str(before), str(after)], + capture_output=True, text=True, + ) + + +def test_cli_identical_decks_exit_zero(tmp_path): + a = tmp_path / "a.org" + a.write_text(DECK_A) + b = tmp_path / "b.org" + b.write_text(DECK_A) + r = _run(a, b) + assert r.returncode == 0 + assert "preserved" in r.stdout.lower() + + +def test_cli_dropped_id_warns_and_exits_one(tmp_path): + a = tmp_path / "a.org" + a.write_text(DECK_A) + b = tmp_path / "b.org" + b.write_text(DECK_B) + r = _run(a, b) + assert r.returncode == 1 + assert "disappeared" in r.stdout.lower() + assert "id-2" in r.stdout + + +DECK_ONE = """* Section +** What is DeepSat? :drill: +:PROPERTIES: +:ID: id-1 +:END: +Body. +""" + + +def test_cli_appeared_only_notes_new_ids_and_exits_one(tmp_path): + # before has id-1; after adds id-2 and drops nothing. + before = tmp_path / "before.org" + before.write_text(DECK_ONE) + after = tmp_path / "after.org" + after.write_text(DECK_A) + r = _run(before, after) + assert r.returncode == 1 + assert "appeared" in r.stdout.lower() + assert "id-2" in r.stdout diff --git a/.ai/scripts/tests/test_flashcard_stats.py b/.ai/scripts/tests/test_flashcard_stats.py new file mode 100644 index 0000000..606f7c1 --- /dev/null +++ b/.ai/scripts/tests/test_flashcard_stats.py @@ -0,0 +1,379 @@ +"""Tests for flashcard-stats.py: prompt-form heuristic + CLI inventory/gate. + +Plain python3 script (no third-party deps), so the pure helper imports directly; +the inventory/gate behavior is exercised through the CLI. +""" +from __future__ import annotations + +import importlib.util +import subprocess +import sys +from pathlib import Path + +import pytest + +SCRIPT = Path(__file__).resolve().parents[1] / "flashcard-stats.py" + + +@pytest.fixture(scope="module") +def stats(): + spec = importlib.util.spec_from_file_location("flashcard_stats", SCRIPT) + assert spec and spec.loader + module = importlib.util.module_from_spec(spec) + spec.loader.exec_module(module) + return module + + +# --- is_prompt_form (pure) --- + +def test_is_prompt_form_question_mark(stats): + assert stats.is_prompt_form("What is DeepSat?") is True + + +def test_is_prompt_form_imperative_verb(stats): + assert stats.is_prompt_form("Spell out the orbital regimes") is True + + +def test_is_prompt_form_imperative_is_case_insensitive(stats): + assert stats.is_prompt_form("introduce yourself") is True + + +def test_is_prompt_form_topic_heading_is_not_a_prompt(stats): + assert stats.is_prompt_form("DeepSat") is False + + +def test_is_prompt_form_strips_trailing_punctuation_off_first_word(stats): + assert stats.is_prompt_form("List: the founders") is True + + +# --- CLI inventory + gate (integration) --- + +CLEAN_DECK = """#+TITLE: DeepSat Flashcards + +* Section +** What is DeepSat? :drill: +:PROPERTIES: +:ID: card-1 +:END: +A satellite company. +""" + +DIRTY_DECK = """#+TITLE: DeepSat Org-Drill Flashcards + +* Section +** DeepSat :drill: +*** Answer +A satellite company. +""" + + +def _run(path): + return subprocess.run( + [sys.executable, str(SCRIPT), str(path)], + capture_output=True, text=True, + ) + + +def test_cli_clean_deck_exits_zero(tmp_path): + f = tmp_path / "clean.org" + f.write_text(CLEAN_DECK) + r = _run(f) + assert r.returncode == 0 + assert "clean" in r.stdout + + +def test_cli_dirty_deck_warns_and_exits_one(tmp_path): + f = tmp_path / "dirty.org" + f.write_text(DIRTY_DECK) + r = _run(f) + assert r.returncode == 1 + assert "WARN" in r.stdout + assert "org-drill" in r.stdout.lower() # title-jargon audit fired + + +def test_cli_missing_file_exits_two(tmp_path): + r = _run(tmp_path / "nope.org") + assert r.returncode == 2 + + +NO_TITLE_DECK = """* Section +** What is DeepSat? :drill: +:PROPERTIES: +:ID: card-1 +:END: +A satellite company. +""" + +# Two cards, only one PROPERTIES drawer. +PROP_MISMATCH_DECK = """#+TITLE: DeepSat Flashcards + +* Section +** What is DeepSat? :drill: +A satellite company. +** Who founded it? :drill: +:PROPERTIES: +:ID: card-2 +:END: +The team. +""" + + +def test_cli_missing_title_warns_and_exits_one(tmp_path): + f = tmp_path / "notitle.org" + f.write_text(NO_TITLE_DECK) + r = _run(f) + assert r.returncode == 1 + assert "no #+TITLE" in r.stdout + + +def test_cli_properties_count_mismatch_warns_and_exits_one(tmp_path): + f = tmp_path / "mismatch.org" + f.write_text(PROP_MISMATCH_DECK) + r = _run(f) + assert r.returncode == 1 + assert "does not match card count" in r.stdout + + +# --- content_words / leakage_ratio (pure) --- + +def test_content_words_drops_stopwords_and_short_tokens(stats): + assert stats.content_words("What is the LEO regime?") == {"leo", "regime"} + + +def test_leakage_ratio_high_when_answer_restates_question(stats): + ratio = stats.leakage_ratio( + "primary orbital regimes satellites", + "the primary orbital regimes for satellites are listed", + ) + assert ratio == 1.0 + + +def test_leakage_ratio_zero_for_short_question(stats): + # "LEO" is the only content word, below LEAKAGE_MIN_WORDS, so overlap is noise. + assert stats.leakage_ratio("What is LEO?", "LEO means low earth orbit") == 0.0 + + +# --- normalize_heading (pure) --- + +def test_normalize_heading_lowercases_and_strips_punctuation(stats): + assert stats.normalize_heading(" What is L.E.O.? ") == "what is l e o" + + +def test_normalize_heading_collisions_match(stats): + assert stats.normalize_heading("What is LEO?") == stats.normalize_heading("what is leo") + + +# --- is_binary_prompt (pure) --- + +def test_is_binary_prompt_true_for_yes_no_lead(stats): + assert stats.is_binary_prompt("Is LEO below GEO?") is True + + +def test_is_binary_prompt_true_for_a_or_b(stats): + assert stats.is_binary_prompt("Is it LEO or GEO?") is True + + +def test_is_binary_prompt_false_for_open_question(stats): + assert stats.is_binary_prompt("What distinguishes LEO from GEO?") is False + + +# --- back_word_count / is_list_back (pure) --- + +def test_back_word_count(stats): + assert stats.back_word_count("one two three") == 3 + assert stats.back_word_count("") == 0 + + +def test_is_list_back_true_for_bulleted_body(stats): + assert stats.is_list_back("- LEO\n- MEO\n- GEO") is True + + +def test_is_list_back_false_for_prose(stats): + assert stats.is_list_back("Low Earth Orbit.\nThe closest regime.") is False + + +def test_is_list_back_false_for_single_bullet(stats): + assert stats.is_list_back("- only one bullet\nplain prose line") is False + + +# --- parse_cards (pure) --- + +def test_parse_cards_captures_body_without_drawer_planning_or_answer_header(stats): + text = ( + "* Sec\n" + "** Q one? :drill:\n" + ":PROPERTIES:\n:ID: id-1\n:END:\n" + "SCHEDULED: <2026-05-20 Wed>\n" + "*** Answer\n" + "the real answer\n" + ) + cards, prop_count = stats.parse_cards(text.splitlines()) + assert prop_count == 1 + assert len(cards) == 1 + c = cards[0] + assert c["heading"] == "Q one?" + assert c["has_id"] is True + assert c["has_answer"] is True + assert c["body"] == "the real answer" + + +def test_find_duplicate_fronts_matches_normalized_headings(stats): + cards = [ + {"heading": "What is LEO?"}, + {"heading": "what is leo?"}, + {"heading": "What is GEO?"}, + ] + dups = stats.find_duplicate_fronts(cards) + assert len(dups) == 1 + assert dups[0] == ("What is LEO?", "what is leo?") + + +# --- CLI: new blocking checks --- + +LEAKY_DECK = """#+TITLE: Test Flashcards + +* Section +** What are the primary orbital regimes for satellites? :drill: +:PROPERTIES: +:ID: c1 +:END: +The primary orbital regimes for satellites are listed here. +""" + +DUP_FRONT_DECK = """#+TITLE: Test Flashcards + +* Section +** What is LEO? :drill: +:PROPERTIES: +:ID: c1 +:END: +Low Earth Orbit. +** What is LEO? :drill: +:PROPERTIES: +:ID: c2 +:END: +Low Earth Orbit, restated. +""" + + +def test_cli_answer_leakage_warns_and_exits_one(tmp_path): + f = tmp_path / "leaky.org" + f.write_text(LEAKY_DECK) + r = _run(f) + assert r.returncode == 1 + assert "leak" in r.stdout.lower() + + +def test_cli_duplicate_front_warns_and_exits_one(tmp_path): + f = tmp_path / "dup.org" + f.write_text(DUP_FRONT_DECK) + r = _run(f) + assert r.returncode == 1 + assert "duplicate" in r.stdout.lower() + + +# --- CLI: non-blocking NOTEs keep exit 0 --- + +NOTES_DECK = """#+TITLE: Test Flashcards + +* Section +** Is LEO closer than GEO? :drill: +:PROPERTIES: +:ID: c1 +:END: +Yes, much closer. +** What orbital regimes exist? :drill: +:PROPERTIES: +:ID: c2 +:END: +- LEO +- MEO +- GEO +** Describe the platform elements in full :drill: +:PROPERTIES: +:ID: c3 +:END: +The platform carries power generation, propulsion, attitude control, thermal regulation, and radio hardware arranged around a central frame. Each element draws from shared resources and must survive launch loads, vacuum, and radiation. Engineers trade mass against capability when every kilogram raises cost, so redundancy is added only where a single failure would end the mission entirely and cheaper options cannot cover the same risk. +""" + + +def test_cli_non_blocking_notes_keep_exit_zero(tmp_path): + f = tmp_path / "notes.org" + f.write_text(NOTES_DECK) + r = _run(f) + assert r.returncode == 0 + assert "NOTE" in r.stdout + + +# --- leakage refinements: source-line strip + numeric carve-out --- + +def test_prose_body_strips_source_and_created_lines(stats): + body = "The real answer here.\nCreated: 2026-05-30\nSource: AHA — https://heart.org/x" + assert stats.prose_body(body) == "The real answer here." + + +def test_has_distinct_numeric_recall_true_for_range_card(stats): + assert stats.has_distinct_numeric_recall( + "What are the HbA1c ranges across normal, prediabetes, and diabetes?", + "Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%.", + ) is True + + +def test_has_distinct_numeric_recall_false_without_numbers(stats): + assert stats.has_distinct_numeric_recall("What is LEO?", "Low Earth Orbit.") is False + + +def test_is_leaky_false_when_overlap_is_only_in_the_source_line(stats): + heading = "What blood pressure constitutes a hypertensive crisis?" + body = ("A reading at or above 180/120.\n" + "Source: AHA — https://heart.org/high-blood-pressure/hypertensive-crisis") + assert stats.is_leaky(heading, body) is False + + +def test_is_leaky_false_for_numeric_range_card(stats): + heading = "What are the HbA1c ranges across normal, prediabetes, and diabetes?" + body = "HbA1c ranges. Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%." + assert stats.is_leaky(heading, body) is False + + +def test_is_leaky_true_for_genuine_restatement(stats): + heading = "primary orbital regimes satellites classification" + body = "The primary orbital regimes satellites classification scheme." + assert stats.is_leaky(heading, body) is True + + +SOURCE_LINE_DECK = """#+TITLE: Test Flashcards + +* Section +** What blood pressure constitutes a hypertensive crisis? :drill: +:PROPERTIES: +:ID: c1 +:END: +A reading at or above 180/120. + +Source: AHA — https://heart.org/high-blood-pressure/hypertensive-crisis-blood-pressure +""" + +RANGE_CARD_DECK = """#+TITLE: Test Flashcards + +* Section +** What are the HbA1c ranges across normal, prediabetes, and diabetes? :drill: +:PROPERTIES: +:ID: c1 +:END: +HbA1c ranges. Normal: <5.7%. Prediabetes: 5.7-6.4%. Diabetes: >=6.5%. +""" + + +def test_cli_source_line_overlap_is_not_flagged(tmp_path): + f = tmp_path / "source.org" + f.write_text(SOURCE_LINE_DECK) + r = _run(f) + assert r.returncode == 0 + + +def test_cli_numeric_range_card_is_not_flagged(tmp_path): + f = tmp_path / "range.org" + f.write_text(RANGE_CARD_DECK) + r = _run(f) + assert r.returncode == 0 diff --git a/.ai/scripts/tests/test_flashcard_to_anki.py b/.ai/scripts/tests/test_flashcard_to_anki.py new file mode 100644 index 0000000..058b0cd --- /dev/null +++ b/.ai/scripts/tests/test_flashcard_to_anki.py @@ -0,0 +1,171 @@ +"""Tests for flashcard-to-anki.py default-path and deck-name helpers. + +The script is a PEP 723 uv-run script that imports genanki, which uv resolves +at runtime but isn't installed in the test environment. The fixture stubs +genanki in sys.modules so the module loads; the pure helpers under test never +call into it. +""" +from __future__ import annotations + +import importlib.util +import sys +import types +from pathlib import Path + +import pytest + +SCRIPT = Path(__file__).resolve().parents[1] / "flashcard-to-anki.py" + + +@pytest.fixture(scope="module") +def drill(): + # Only stub when genanki is genuinely absent, so a real install isn't shadowed. + sys.modules.setdefault("genanki", types.ModuleType("genanki")) + spec = importlib.util.spec_from_file_location("flashcard_to_anki", SCRIPT) + assert spec and spec.loader + module = importlib.util.module_from_spec(spec) + spec.loader.exec_module(module) + return module + + +def test_default_output_path_targets_phone_anki_dir(drill): + """The .apkg is a phone artifact, so it defaults under sync/phone/anki/.""" + result = drill.default_output_path(Path("/home/x/projects/health/health-drill.org")) + assert result == Path.home() / "sync" / "phone" / "anki" / "health-drill.apkg" + + +def test_default_deck_name_is_raw_basename(drill): + """Deck name is the input basename with case preserved; #+TITLE is ignored.""" + assert drill.default_deck_name(Path("/x/deepsat.org")) == "deepsat" + + +def test_default_deck_name_keeps_hyphens(drill): + """A hyphenated basename is kept verbatim rather than title-cased.""" + assert drill.default_deck_name(Path("/x/health-drill.org")) == "health-drill" + + +# --- section_to_tag (pure) --- + +def test_section_to_tag_slugifies_words(drill): + assert drill.section_to_tag("Orbital Regimes") == "orbital-regimes" + + +def test_section_to_tag_strips_leading_and_trailing_nonalnum(drill): + assert drill.section_to_tag(" People & Roles! ") == "people-roles" + + +def test_section_to_tag_empty_string(drill): + assert drill.section_to_tag("") == "" + + +# --- escape_html (pure) --- + +def test_escape_html_escapes_amp_lt_gt(drill): + assert drill.escape_html("a & b < c > d") == "a & b < c > d" + + +def test_escape_html_plain_text_unchanged(drill): + assert drill.escape_html("plain text") == "plain text" + + +def test_escape_html_escapes_amp_first_so_existing_entity_is_literal(drill): + # & is replaced before < / >, so a literal "<" becomes "&lt;", + # not silently treated as an already-escaped entity. + assert drill.escape_html("<") == "&lt;" + + +def test_escape_html_empty_string(drill): + assert drill.escape_html("") == "" + + +# --- stable_id (pure) --- + +def test_stable_id_is_deterministic(drill): + assert drill.stable_id("DeepSat", "deck") == drill.stable_id("DeepSat", "deck") + + +def test_stable_id_salt_changes_the_result(drill): + assert drill.stable_id("DeepSat", "deck") != drill.stable_id("DeepSat", "model") + + +def test_stable_id_stays_within_the_reserved_range(drill): + value = drill.stable_id("anything", "deck") + assert drill.ID_BASE <= value < drill.ID_BASE + drill.ID_RANGE + + +# --- strip_org_metadata (pure) --- + +def test_strip_org_metadata_drops_properties_drawer(drill): + body = [":PROPERTIES:", ":ID: x", ":END:", "real content"] + assert drill.strip_org_metadata(body) == ["real content"] + + +def test_strip_org_metadata_drops_planning_lines(drill): + body = ["SCHEDULED: <2026-05-30>", "DEADLINE: <2026-06-01>", + "CLOSED: [2026-05-29]", "body"] + assert drill.strip_org_metadata(body) == ["body"] + + +def test_strip_org_metadata_leaves_plain_body_unchanged(drill): + body = ["line one", "line two"] + assert drill.strip_org_metadata(body) == ["line one", "line two"] + + +def test_strip_org_metadata_empty_list(drill): + assert drill.strip_org_metadata([]) == [] + + +def test_strip_org_metadata_unclosed_drawer_swallows_the_rest(drill): + # An unterminated :PROPERTIES: drawer consumes everything after it. + body = [":PROPERTIES:", ":ID: x", "still in drawer"] + assert drill.strip_org_metadata(body) == [] + + +def test_strip_org_metadata_drops_created_date_line(drill): + # A created/added date never belongs on a card back. + assert drill.strip_org_metadata(["Created: 2026-05-30", "real answer"]) == ["real answer"] + + +# --- parse (pure, core parser) --- + +SECTIONED = """* Orbital Regimes +** What is LEO? :drill: +Low Earth Orbit. +** What is GEO? :drill: +Geostationary Earth Orbit. +""" + + +def test_parse_returns_front_back_tag_per_card(drill): + cards = drill.parse(SECTIONED) + assert len(cards) == 2 + assert cards[0] == ("What is LEO?", "Low Earth Orbit.", "orbital-regimes") + assert cards[1][0] == "What is GEO?" + + +def test_parse_card_without_a_section_gets_the_drill_tag(drill): + assert drill.parse("** Lone card? :drill:\nbody\n") == [("Lone card?", "body", "drill")] + + +def test_parse_strips_properties_drawer_from_back(drill): + text = "** Q? :drill:\n:PROPERTIES:\n:ID: abc\n:END:\nThe answer.\n" + assert drill.parse(text) == [("Q?", "The answer.", "drill")] + + +def test_parse_trims_leading_and_trailing_blank_body_lines(drill): + cards = drill.parse("** Q? :drill:\n\n\nanswer\n\n\n") + assert cards[0][1] == "answer" + + +def test_parse_card_with_only_a_drawer_has_empty_back(drill): + text = "** Q? :drill:\n:PROPERTIES:\n:ID: x\n:END:\n" + assert drill.parse(text) == [("Q?", "", "drill")] + + +def test_parse_joins_multiline_body_with_br(drill): + cards = drill.parse("** Q? :drill:\nline one\nline two\n") + assert cards[0][1] == "line one
line two" + + +def test_parse_no_drill_cards_returns_empty(drill): + assert drill.parse("* Section\nno drill cards here\n") == [] -- cgit v1.2.3