From 29f04ead4051b79206626b5eb3ad0ed91e7f1d42 Mon Sep 17 00:00:00 2001 From: Craig Jennings Date: Sat, 2 May 2026 11:08:52 -0500 Subject: docs(commits): drop "on" from Slack notify templates --- claude-rules/commits.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 64b0177..72b1859 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -286,8 +286,8 @@ enough to skip review" exemption on top of it. - Inline code comment pinned to a specific line/hunk: no direct `gh` flag — use `gh api /repos///pulls//comments -F body=@/tmp/pr--comment.md -F commit_id=... -F path=... -F line=...`. 7. Verify the comment landed. `gh api /repos///pulls//reviews` for review-shaped comments, `gh api /repos///issues//comments` for issue-thread comments. 8. **Notify the PR author on Slack** (review-shaped comments only — `--approve` or `--request-changes`). After the review posts, send a one-line Slack message to channel `C0AM2MWHCJU` via the `slack-deepsat` MCP. No humanizer or personal-style passes — the message is short and templated. Two cases: - - Approved: `Approved on PR #N.\n` - - Changes requested: `Changes Requested on PR #N\n` + - Approved: `Approved PR #N.\n` + - Changes requested: `Changes Requested PR #N\n` Replace `#N` with the PR number and `` with the GHE URL of the PR. The URL goes on its own line, immediately after the message. If the MCP doesn't have a post-message tool registered (for example, in a project where the Slack MCP is read-only), surface that to the user and skip the post — don't fall back to a different channel or asking the user to paste it. Skip this step for plain `--comment` reviews (informal feedback, not a verdict) and for issue-thread or inline code comments. Approve and request-changes are the only verdicts that warrant the notification. -- cgit v1.2.3