From e35fe600ef9ec3bf2facae67608b0a8bf0298ed9 Mon Sep 17 00:00:00 2001
From: Craig Jennings <c@cjennings.net>
Date: Sun, 19 Apr 2026 16:28:03 -0500
Subject: refactor: review-pr → review-code with superpowers + plugin-lifted
 improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Renamed review-pr → review-code (the skill accepts PR, SHA range,
current branch, staged changes — "pr" was understating scope).
Rewrote SKILL.md with YAML frontmatter (previously header-style) and
merged useful patterns from two sources:

From obra/superpowers skills/requesting-code-review:
  - Intent-vs-delivery grading (given plan/ADR/ticket)
  - Mandatory Strengths section (three minimum)
  - Per-issue Critical/Important/Minor severity (per-criterion
    PASS/WARN/FAIL retained; complementary axes)
  - Required verdict + 1-2 sentence reasoning
  - Multi-input support (PR / SHA range / current branch / --staged)
  - Sub-agent dispatch recommendation for heavy reviews
  - Concrete filled-in example output

From the claude-plugins-official code-review plugin:
  - Phase 0 eligibility gate (skip closed/draft/auto/trivial/already-reviewed)
  - CLAUDE.md traversal + adherence criterion (reads root + per-directory
    CLAUDE.md files; audits the diff against stated rules)
  - Multi-perspective Phase 2: five passes (CLAUDE.md adherence, shallow
    bug scan, git history context, prior PR comments, in-scope code
    comments). For large reviews, dispatch as parallel sub-agents.
  - Confidence filter (High/Medium/Low; drop Low before reporting)
  - False-positive categories explicitly enumerated (pre-existing issues
    on unmodified lines, lint/typecheck issues CI handles,
    senior-wouldn't-call-out nitpicks, silenced issues with valid reason,
    intentional scope changes, unmodified-line issues, framework-behavior
    tests)
  - Trust-CI discipline (don't run builds yourself)

Substance from the original review-pr kept verbatim:
  - DeepSat-specific criteria (security, TDD evidence, conventions,
    no-AI-attribution, API contracts, architecture layering, root-cause
    discipline)

Size: 60 lines → 347 lines. Growth is structural (added phases, added
example, added perspectives, added filters) not verbose — each section
earns its lines.

NOT adopted from the plugin:
  - GitHub comment output format (plugin posts PR comments; review-code
    outputs a markdown report the user can paste if they want)
  - "Generated with Claude Code" footer (violates no-AI-attribution rule)
  - Specific 0/25/50/75/100 confidence scale (Critical/Important/Minor
    covers the same signal with less ceremony)

Makefile SKILLS updated: review-pr → review-code. Old
~/.claude/skills/review-pr symlink removed; make install creates the
new one at ~/.claude/skills/review-code.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'Makefile')

diff --git a/Makefile b/Makefile
index 37f9d84..1fca989 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ SHELL := /bin/bash
 
 SKILLS_DIR := $(HOME)/.claude/skills
 RULES_DIR  := $(HOME)/.claude/rules
-SKILLS     := c4-analyze c4-diagram debug add-tests respond-to-review review-pr fix-issue security-check \
+SKILLS     := c4-analyze c4-diagram debug add-tests respond-to-review review-code fix-issue security-check \
               arch-design arch-decide arch-document arch-evaluate \
               brainstorm codify root-cause-trace five-whys prompt-engineering \
               playwright-js playwright-py frontend-design pairwise-tests
-- 
cgit v1.2.3