diff options
| author | Craig Jennings <c@cjennings.net> | 2026-04-27 16:39:38 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-04-27 16:39:38 -0500 |
| commit | ea494c7d0fc41bb1cab888f92408fab29c190e75 (patch) | |
| tree | 08960ee41a47a5d37863f90b38740bad91dcd8ed /scripts | |
| parent | 6dcdf180289823fceda376c67af9d4ea659463a8 (diff) | |
| download | archangel-ea494c7d0fc41bb1cab888f92408fab29c190e75.tar.gz archangel-ea494c7d0fc41bb1cab888f92408fab29c190e75.zip | |
refactor: drop dead configure_luks_grub from Btrfs install path
Problem: configure_luks_grub appended GRUB_ENABLE_CRYPTODISK=y and prepended cryptdevice= to /etc/default/grub during the LUKS-target setup phase, but configure_grub at lib/btrfs.sh:578 does `cat > /etc/default/grub` later in the same install, with a single redirect that overwrites the file. Between the two, only generate_btrfs_fstab and configure_btrfs_initramfs run, neither of which touches /etc/default/grub. So configure_luks_grub's writes never reach the installed system. The live LUKS-cmdline work is configure_grub's own LUKS-enabled block at lib/btrfs.sh:597-627.
Solution: drop configure_luks_grub from btrfs_configure_luks_target and delete the function (no other callers). configure_luks_initramfs stays since it writes to mkinitcpio, not /etc/default/grub.
VM tests on the btrfs-luks path have always been passing because they exercise configure_grub's live block. prepend_grub_cmdline_linux already has bats coverage for the live cmdline path.
Bats: 147, 0 fail. Lint clean.
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions