aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-07-20 23:31:07 -0500
committerCraig Jennings <c@cjennings.net>2026-07-20 23:31:07 -0500
commit282132a65df3cf7b841f7be8e386464b7a1e1b57 (patch)
tree18c638a4e87eb252c1e54abda651b609c0e915c5
parente0d22bd8250d27438c9cd4c6a0c7f9e1abddff46 (diff)
downloadarchsetup-282132a65df3cf7b841f7be8e386464b7a1e1b57.tar.gz
archsetup-282132a65df3cf7b841f7be8e386464b7a1e1b57.zip
docs: close nvme early-module task
-rw-r--r--todo.org4
1 files changed, 3 insertions, 1 deletions
diff --git a/todo.org b/todo.org
index df1d83e..b1e93ad 100644
--- a/todo.org
+++ b/todo.org
@@ -1471,7 +1471,9 @@ CLOSED: [2026-07-20 Mon]
Fixed (fa3135a): extracted set_user_password, which guards the chpasswd with error_fatal so a failure aborts loudly instead of silently leaving no password. Fake-chpasswd test pins the guard fires on failure and stays quiet on success.
Grading: Major severity (fresh system's primary user can't log in) x rare edge case (chpasswd seldom fails) = P3 = [#C].
archsetup:1168 runs =echo "$user:$pass" | chpasswd= with no guard, then unsets the password next line; set -e is off (line 21), so a silent failure leaves no password and no log entry. Fix: guard with error_fatal (report + "set it by hand: passwd $user") before unsetting. See findings doc (S2).
-** TODO [#C] Installer nvme early module never built into initramfs :bug:solo:
+** DONE [#C] Installer nvme early module never built into initramfs :bug:solo:
+CLOSED: [2026-07-20 Mon]
+Fixed in e0d22bd: extracted ensure_nvme_early_module, which rebuilds the initramfs whenever it changed the conf (regardless of ZFS root) and scopes the presence check to the MODULES line. TDD via tests/installer-steps/test_ensure_nvme_early_module.py.
Grading: Minor severity (module autoload still boots the system) x most-machines (all Craig's ZFS-root boxes) = P3 = [#C].
archsetup:2910 writes MODULES=(nvme) but the only mkinitcpio -P in boot_ux runs =if ! is_zfs_root=, so on ZFS-root non-Framework machines the early-load hardening is never compiled in. Also archsetup:2918 greps the whole file for "nvme" (not the MODULES line). Fix: rebuild initramfs after the MODULES edit regardless of ZFS; scope the presence grep to =^MODULES=(=. See findings doc (S3).
** DONE [#C] Installer disk-space pre-flight check is fragile :bug:solo:quick: