docs(spec): bluetooth panel reviewed READY, decomposed to DOING; net-panel kbd-nav probe deferred

Fused reviewer + responder pass: gate passed (all four decisions resolved, phases decomposable, bluez 5.86 verbs verified), two non-blocking findings recorded and dispositioned inline (empty-state/no-adapter copy, eventlog + redaction carry-over — both clone the net-panel donor). Build parent now carries the five phase sub-tasks and the spec's ID. The keyboard-nav verification task logs its code-level findings; the live AT-SPI probe waits until Craig's meeting ends (no test windows or synthetic input while zoom holds focus).

2 files changed, 82 insertions, 6 deletions

diff --git a/docs/design/2026-07-02-bluetooth-panel-spec.org b/docs/design/2026-07-02-bluetooth-panel-spec.org
index f010c1a..3ada112 100644
--- a/docs/design/2026-07-02-bluetooth-panel-spec.org
+++ b/docs/design/2026-07-02-bluetooth-panel-spec.org
@@ -4,10 +4,17 @@
 #+TODO: TODO | DONE
 #+TODO: DRAFT READY DOING | IMPLEMENTED SUPERSEDED CANCELLED
 
-* DRAFT Status
+* DOING Status
 :PROPERTIES:
 :ID:       1271a845-4463-4831-9902-990eda6b2265
 :END:
+- [2026-07-02 Thu] DOING — spec-response decomposed the five phases into
+  build sub-tasks under the todo.org parent (:SPEC_ID: bound); build
+  started same day per Craig ("4 first, then 1" — bugs then bluetooth).
+- [2026-07-02 Thu] READY — spec-review passed the gate: all four
+  decisions resolved, phases decomposable, CLI verbs verified against
+  bluez 5.86. Two non-blocking findings recorded and dispositioned in
+  the same pass (donor-pattern answers).
 - [2026-07-02 Thu] DRAFT — initial spec from Craig's request: a bluetooth
   module driving a CLI underneath, consistent with the net panel, minimal
   interface, full functionality, diagnostics section, visual mockups.
@@ -16,7 +23,7 @@
 
 | Field  | Value                                                                           |
 |--------+---------------------------------------------------------------------------------|
-| Status | draft                                                                           |
+| Status | doing                                                                           |
 |--------+---------------------------------------------------------------------------------|
 | Owner  | Craig Jennings                                                                  |
 |--------+---------------------------------------------------------------------------------|
@@ -277,7 +284,7 @@ auto-dismiss in 4s, and the V2 spec's keyboard-navigation claims
 implemented. Both filed against the net panel rather than cloned here;
 this panel adopts whatever resolution those tasks land on.
 
-* Decisions (Craig)
+* Decisions (Craig) [4/4]
 
 ** DONE Pair implies trust + connect?
 CLOSED: [2026-07-02 Thu]
@@ -304,6 +311,32 @@ CLOSED: [2026-07-02 Thu]
 Approved (Craig, 2026-07-02): 8s bursts, no auto-repeat — Rescan stays
 explicit, matching the net panel's Available view.
 
+* Review findings [2/2]
+
+** DONE Empty-state and no-adapter presentation copy undefined :nonblocking:
+CLOSED: [2026-07-02 Thu]
+The mockups show populated lists; the spec didn't say what an empty Paired
+list, an empty post-scan Nearby list, or a machine with no adapter shows
+in the panel and on the bar glyph. Dispositioned same pass: clone the
+donor — the net panel's in-box overlay message pattern (=show_loading= /
+placeholder label) carries the copy. Paired empty: "No paired devices —
+switch to Nearby to pair one." Nearby post-scan empty: "Nothing found —
+Rescan, or make the device discoverable." No adapter: adapter row reads
+"No Bluetooth adapter", Devices controls disable, Diagnostics stays
+usable (the doctor's step 1 names the hardware/driver verdict); bar
+glyph shows the off/blocked state. Non-blocking; recorded so the
+implementer doesn't invent copy mid-build.
+
+** DONE Logging/redaction carry-over unstated :nonblocking:
+CLOSED: [2026-07-02 Thu]
+The spec says "the net panel's stack, verbatim" but didn't name whether
+the engine adopts net's =eventlog= (structured op log) and =redact=
+(sensitive-field scrubbing) modules. Dispositioned same pass: yes, both
+carry over — every mutating verb (pair/connect/forget/repair) logs an
+eventlog entry, and MACs are the redaction surface (device names stay,
+MACs redact in copied reports, mirroring net's report redaction).
+Non-blocking; it's the donor default made explicit.
+
 * Implementation phases
 
 1. Engine =bt= package: adapter/device/scan probes over fake-bluetoothctl,
@@ -324,3 +357,22 @@ explicit, matching the net panel's Available view.
    assertions.
 5. archsetup keybind/config defaults so a fresh install lands the panel
    wired (waybar module present, bind set, sudoers placed).
+
+* Review and iteration history
+
+** 2026-07-02 Thu @ 13:10:00 -0400 — Claude Code (archsetup) — reviewer + responder
+- *What changed or was recommended:* Ran the spec-review gate: passed.
+  All four decisions were already DONE (cookie added to the heading);
+  the five phases are each a clean single-session stop; CLI verbs are
+  verified against installed bluez 5.86. Two non-blocking findings
+  recorded and dispositioned in the same fused pass (empty-state /
+  no-adapter copy, eventlog + redaction carry-over) — both resolve to
+  "clone the net-panel donor," now stated explicitly. Flipped DRAFT →
+  READY → DOING and decomposed the phases into build sub-tasks under the
+  todo.org parent with :SPEC_ID: bound.
+- *Why:* Craig queued the build ("4 first, then 1", 2026-07-02) after
+  resolving all decisions the same morning; the gate held nothing back,
+  so review and response fused to keep the speedrun moving.
+- *Artifacts:* Findings in =* Review findings [2/2]= above; build parent
+  in todo.org ("Bluetooth panel + bar module"); net-panel toast fix the
+  UX-conformance note references landed as dotfiles =0f017d4=.
diff --git a/todo.org b/todo.org
index ed9d992..8518b64 100644
--- a/todo.org
+++ b/todo.org
@@ -537,11 +537,32 @@ Design / open questions (propose before building):
 
 Implementation notes: a small GTK layer-shell app (mirror pocketbook's structure: src-layout Python package, pytest, Makefile) talking to brightnessctl / hyprctl / the touchpad + airplane helpers. Lives in the dotfiles repo or in-tree like pocketbook. TDD the backing toggle/slider logic. Sizable — worth a design doc first.
 
-** TODO [#B] Bluetooth panel + bar module :feature:waybar:bluetooth:
-Initial spec written 2026-07-02: [[file:docs/design/2026-07-02-bluetooth-panel-spec.org]] (DRAFT — decisions await Craig's review before build).
+** DOING [#B] Bluetooth panel + bar module :feature:waybar:bluetooth:
+:PROPERTIES:
+:SPEC_ID: 1271a845-4463-4831-9902-990eda6b2265
+:END:
+Spec: [[file:docs/design/2026-07-02-bluetooth-panel-spec.org]] (DOING — reviewed READY and decomposed 2026-07-02; all four decisions resolved, two non-blocking findings dispositioned in the fused review pass).
 
 A bluetooth panel driving a CLI underneath (bluetoothctl one-shot verbs), consistent in look and feel with the net panel (GTK4 + layer-shell + Blueprint, humble-object presenter, verify-everything). Minimalistic interface, full functionality, plus a diagnostics/troubleshooting section mirroring the net panel's Diagnostics tab. Bar module glyph opens it. Craig's ask (2026-07-02): follow UX/UI best practices; where the net panel's patterns conflict with best practices, file a net-panel bug task rather than clone the flaw.
 
+*** TODO Phase 1 — engine bt package (dotfiles) :feature:
+Adapter/device/scan probes over fake-bluetoothctl, status + doctor chain (rfkill, service, powered, reachability, audio profile probe + A2DP switch repair over fake-wpctl) — pure TDD, no GTK. =bt status= and =bt doctor= work from a terminal. Factor the shared dupre css asset if the settings panel hasn't already.
+
+*** TODO Phase 2 — panel (dotfiles) :feature:
+PanelModel presenter + Blueprint pages (Devices with Paired/Nearby, Diagnostics), worker-thread wiring, pairing-dialog pty state machine, bt-panel toggle wrapper, AT-SPI smoke. Super+Shift+B rebind.
+
+*** TODO Phase 3 — bar module custom/bluetooth (dotfiles) :feature:
+Glyph states, tooltip with battery + keybind hints, low-battery surface, refresh signal, waybar config + suite coverage; blueman retirement per the decision.
+
+*** TODO Phase 4 — bt-priv + sudoers + packages (archsetup) :feature:
+One-verb bt-priv helper + NOPASSWD sudoers rule cloning net-priv's pattern; package-list swap (blueman out, bluez-utils stays); VM test assertions.
+
+*** TODO Phase 5 — install defaults (archsetup) :feature:
+Keybind/config defaults so a fresh install lands the panel wired: waybar module present, bind set, sudoers placed.
+
+*** TODO Test surface :test:
+Engine suites over fake binaries (bluetoothctl show/devices/info/scan parse, doctor chain verdicts, A2DP repair verify), PanelModel presenter suite, pairing state-machine suite (passkey confirm / NoInputNoOutput / timeout), bar-module suite, gated AT-SPI smoke, VM assertions for phases 4-5.
+
 ** TODO [#B] Local offline LLM runtime + per-host model cache :tooling:llm:
 :PROPERTIES:
 :LAST_REVIEWED: 2026-05-29
@@ -881,9 +902,12 @@ Shipped 2026-07-02 (dotfiles 775771b). Keybind now calls a =wlogout-menu= wrappe
 CLOSED: [2026-07-02 Thu]
 Fixed in dotfiles 0f017d4: viewmodel.toast_plan owns the toast policy — errors show sticky and ignore the post-op refresh's empty clear (worst case: a forget failure's error was wiped within ~2s by its own refresh), and the next real status replaces them. Successes keep the 4s fade. 7 policy tests added; 41 suites green.
 
-** TODO [#C] Net panel: verify claimed keyboard navigation :test:network:waybar:
+** DOING [#C] Net panel: verify claimed keyboard navigation :test:network:waybar:
 Found during the bluetooth-panel UX pass (2026-07-02). The V2 spec claims tab-between-sections, arrow-key row navigation, and type-to-filter, but no custom keyboard code exists in the panel — arrows and type-ahead may ride GTK ListBox defaults, tab-between-sections likely doesn't. Verify each claim against the live panel (AT-SPI smoke can assert focus order); implement or strike the claims from the spec so spec and panel agree.
 
+*** 2026-07-02 Thu @ 13:05:00 -0400 Code-level pass done; live probe deferred (Craig in a Zoom meeting)
+Code reality (dotfiles net/src/net): Esc close is wired (gui EventControllerKey); row-activated -> primary is wired for both connection lists (pages.py:122,126), so Enter-on-row rides the GTK ListBox activate binding; arrows ride ListBox defaults; NOTHING implements type-to-filter (no search/filter code exists — that claim is false as written); Tab is the plain GTK focus chain, widget by widget, not section jumps. Live AT-SPI probe plan: launch panel in test mode, drive keys via hyprctl dispatch sendshortcut targeted AT THE PANEL WINDOW (never the focused surface — wtype/ydotool absent anyway), gate every key on the panel holding focus, never send Enter on the available list (real connect risk). BLOCKED at 13:05: active window is zoom (meeting) — no test windows, no synthetic input until clear. Then: verify focus order + arrows + no-filter live, strike/reword the spec's keyboard bullet to match.
+
 ** TODO [#C] Window focus lost when unhiding stashed windows :bug:hyprland:
 :PROPERTIES:
 :LAST_REVIEWED: 2026-06-24