aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-05-26 16:00:11 -0500
committerCraig Jennings <c@cjennings.net>2026-05-26 16:00:11 -0500
commit61f96b996562e5b36a309bacd098b9b135cfc6af (patch)
tree5311caddcacba5312de9b39ae71d351207d5e5cf
parentf0dabfcfb5f658eb601ac87cfad1608db4e48c1a (diff)
downloadarchsetup-61f96b996562e5b36a309bacd098b9b135cfc6af.tar.gz
archsetup-61f96b996562e5b36a309bacd098b9b135cfc6af.zip
chore(todo): close the moot eval task and the already-done rustup task
Both were stale. The eval task pointed at a line-434 eval that no longer exists. The only eval left is in retry_install, and it's the deliberate one that captures the exit code directly, so there's nothing to replace. The rustup task was already implemented (rustup install plus rustup default stable in the languages section). It just predated that work.
-rw-r--r--todo.org9
1 files changed, 6 insertions, 3 deletions
diff --git a/todo.org b/todo.org
index ad9cfd7..f819075 100644
--- a/todo.org
+++ b/todo.org
@@ -280,8 +280,8 @@ Tests: =tests/safe-rm-rf/test_safe_rm_rf.py= sources the real function out of th
*** TODO [#A] Standardize boolean comparison style :quick:
Mixed =[ "$var" = "true" ]= vs =$var= evaluation — pick one pattern.
-*** TODO [#A] Replace eval with safer alternatives :quick:
-Line 434: =eval "$cmd"= — use arrays or direct execution.
+*** 2026-05-26 Tue @ 15:27:09 -0500 eval task moot — the line-434 eval is gone, the survivor is deliberate
+Verified: the only =eval= left in =archsetup= is line 578 in =retry_install=, and it's intentional and documented — it captures =$?= directly from =eval "$cmd"= to dodge the if-compound-swallows-exit-code trap. Replacing it with an array would reintroduce that bug. The line-434 eval this task pointed at no longer exists. Nothing to change.
** TODO [#B] Review post-archsetup laptop setup steps (velox 2026-04-10)
:PROPERTIES:
@@ -650,10 +650,13 @@ Establish clear process for tool evaluation decisions
:END:
Ensure new tools integrate with DWM environment and don't break workflow
-** TODO [#B] Add Rust installation via rustup instead of pacman package :quick:
+** DONE [#B] Add Rust installation via rustup instead of pacman package :quick:
+CLOSED: [2026-05-26 Tue]
:PROPERTIES:
:LAST_REVIEWED: 2026-05-21
:END:
+Already implemented — =archsetup= lines 1976-1979 (Programming Languages and Utilities) =pacman_install rustup= then =rustup default stable= as the user. Closing on verification; the task predated that work.
+
The =rust= package has been removed from archsetup. Need to add Rust installation using =rustup= (the official Rust toolchain manager) instead of the Arch package.
Steps: