diff options
| author | Craig Jennings <c@cjennings.net> | 2026-07-20 15:42:37 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-07-20 15:42:37 -0500 |
| commit | 6de55d2942f3ea0d859c98816076fc6ce3601b63 (patch) | |
| tree | 974d2f5b3056d78f810537a1be88d33bcd59bba0 /docs/prototypes/widgets.js | |
| parent | 712e666fa11014c15de991fd541b9a961bdb7aed (diff) | |
| download | archsetup-6de55d2942f3ea0d859c98816076fc6ce3601b63.tar.gz archsetup-6de55d2942f3ea0d859c98816076fc6ce3601b63.zip | |
fix(installer): record the state marker on non-fatal step warnings
run_step marked a step complete only when its function returned 0. But error_fatal exits the script outright, so a step function that returns at all has already cleared every fatal check -- a non-zero return can only be a trailing non-fatal warning, since error_warn returns 1. The old code read that as a failure and withheld the state marker, so the step re-ran on every resume even though its body had finished. run_step now records the marker whenever the function returns and logs a warning line when the return was non-zero.
Two smaller fixes alongside it. run_step's step_name/step_func and show_status's step/timestamp now use local so they stop leaking to global scope. The package-cache refresh loop captures pacman's real exit code instead of reading `$?` off the `$refresh_ok` test, which always read 1 and made error_fatal report "error code: 0" -- the same trap retry_install already documents.
Diffstat (limited to 'docs/prototypes/widgets.js')
0 files changed, 0 insertions, 0 deletions
