aboutsummaryrefslogtreecommitdiff
path: root/scripts/testing/run-test.sh
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-05-11 17:19:56 -0500
committerCraig Jennings <c@cjennings.net>2026-05-11 17:19:56 -0500
commit3f89f7524c7d15401968c0b2f4ae25757dda5053 (patch)
tree2b73163fca35af2a4df04ae4231f5852f54beeb0 /scripts/testing/run-test.sh
parent979cf4103e94f05c5186366161ca6c667def39f6 (diff)
downloadarchsetup-3f89f7524c7d15401968c0b2f4ae25757dda5053.tar.gz
archsetup-3f89f7524c7d15401968c0b2f4ae25757dda5053.zip
fix(testing): drop stale plugin checks, count failed validations
validate_hyprland_plugins and validate_hyprpm_hook checked for the hyprland-plugins-setup script and the hyprpm pacman hook, both removed in 225cc76 (Hyprland 0.54 brings the layouts into core). I deleted the two functions and their calls in validate_window_manager. I also disabled errexit in run-test.sh from the validation phase onward, so one failed check is counted in VALIDATION_FAILED instead of aborting the run before the report or VM cleanup. About 16 validations across the file do a bare `return 1` after `validation_fail`; any of them firing under the previous behavior would have killed the harness mid-run.
Diffstat (limited to 'scripts/testing/run-test.sh')
-rwxr-xr-xscripts/testing/run-test.sh10
1 files changed, 9 insertions, 1 deletions
diff --git a/scripts/testing/run-test.sh b/scripts/testing/run-test.sh
index d1b4566..c0eaf50 100755
--- a/scripts/testing/run-test.sh
+++ b/scripts/testing/run-test.sh
@@ -256,7 +256,15 @@ copy_from_vm "/var/log/archsetup-installed-packages.txt" "$TEST_RESULTS_DIR/" "$
capture_post_install_state "$TEST_RESULTS_DIR"
# Run comprehensive validation
-# This uses the validation.sh library for all checks
+# This uses the validation.sh library for all checks.
+#
+# From here to the end of the script, errexit is disabled on purpose: the
+# validation functions are designed to fail-and-count (see VALIDATION_FAILED)
+# rather than abort, and the analysis/report-generation steps below can also
+# legitimately return non-zero. With `set -e` active, a single failed check
+# would kill the run before the test report is written or the VM is cleaned
+# up. Pass/fail is signalled explicitly by the exit code at the bottom.
+set +e
run_all_validations
validate_all_services