diff options
| author | Craig Jennings <c@cjennings.net> | 2026-07-20 15:39:10 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-07-20 15:39:10 -0500 |
| commit | 712e666fa11014c15de991fd541b9a961bdb7aed (patch) | |
| tree | fbb3328c5e24435a817ac9cff6327967c30bf7bf /todo.org | |
| parent | aef074f711566159d200021f7133f7713f2aaf8d (diff) | |
| download | archsetup-712e666fa11014c15de991fd541b9a961bdb7aed.tar.gz archsetup-712e666fa11014c15de991fd541b9a961bdb7aed.zip | |
docs: close df disk-space pre-flight task
Diffstat (limited to 'todo.org')
| -rw-r--r-- | todo.org | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -1469,7 +1469,9 @@ archsetup:1168 runs =echo "$user:$pass" | chpasswd= with no guard, then unsets t ** TODO [#C] Installer nvme early module never built into initramfs :bug:solo: Grading: Minor severity (module autoload still boots the system) x most-machines (all Craig's ZFS-root boxes) = P3 = [#C]. archsetup:2910 writes MODULES=(nvme) but the only mkinitcpio -P in boot_ux runs =if ! is_zfs_root=, so on ZFS-root non-Framework machines the early-load hardening is never compiled in. Also archsetup:2918 greps the whole file for "nvme" (not the MODULES line). Fix: rebuild initramfs after the MODULES edit regardless of ZFS; scope the presence grep to =^MODULES=(=. See findings doc (S3). -** TODO [#C] Installer disk-space pre-flight check is fragile :bug:solo:quick: +** DONE [#C] Installer disk-space pre-flight check is fragile :bug:solo:quick: +CLOSED: [2026-07-20 Mon] +Fixed in aef074f: extracted check_disk_space using df -P (wrap-safe) and a KB comparison (no truncation bias); non-numeric df output falls back to zero so a malformed read aborts loudly. TDD via tests/installer-steps/test_check_disk_space.py. Grading: Major severity (aborts a valid install) x some (df wraps long device names on a live ISO / device-mapper root) = P3 = [#C]. archsetup:487 parses =df / | awk 'NR==2'=, which reads the device-name line (empty $4 -> 0 GB) when df wraps; archsetup:488 also integer-truncates the GB compare against the 20 GB floor. Fix: =df -P /= (single-line) or =df --output=avail=; compare in KB to avoid the rounding bias. See findings doc (S1). ** TODO [#C] Installer run_step state + exit-code handling :bug:solo: |
