1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
;;; test-chime-intervals-for-marker.el --- Tests for per-event interval override -*- lexical-binding: t; -*-
;; Copyright (C) 2026 Craig Jennings
;; Author: Craig Jennings <c@cjennings.net>
;; This program is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with this program. If not, see <http://www.gnu.org/licenses/>.
;;; Commentary:
;; Tests for the per-event :CHIME_NOTIFY_BEFORE: property override and the
;; deprecated :WILD_NOTIFIER_NOTIFY_BEFORE: alias:
;;
;; - chime--parse-notify-before-value : value-string parsing
;; - chime--intervals-for-marker : property lookup with fallback to
;; chime-alert-intervals; returns
;; (INTERVALS . DEPRECATED-PROP)
;; - chime--gather-info : end-to-end gather honoring the property
;; - chime--maybe-warn-deprecated-properties : one-warning-per-session guard
;;; Code:
(require 'test-bootstrap (expand-file-name "test-bootstrap.el"))
(require 'testutil-time (expand-file-name "testutil-time.el"))
(require 'cl-lib)
;;; Helpers
(defun test-chime-intervals--org-heading-with-props (props)
"Return org content for one heading whose drawer carries PROPS.
PROPS is a list of (NAME . VALUE) string pairs, or nil for no drawer.
A dynamic timestamp is appended so `chime--gather-info' has one to extract."
(concat "* Test Heading\n"
(when props
(concat ":PROPERTIES:\n"
(mapconcat (lambda (p) (format ":%s: %s\n" (car p) (cdr p)))
props "")
":END:\n"))
(test-timestamp-string (test-time-tomorrow-at 14 0)) "\n"))
(defmacro test-chime-intervals--with-marker (props &rest body)
"Run BODY in a temp org buffer with a heading carrying PROPS; bind `marker'."
(declare (indent 1) (debug t))
`(with-temp-buffer
(org-mode)
(insert (test-chime-intervals--org-heading-with-props ,props))
(goto-char (point-min))
(let ((marker (point-marker)))
,@body)))
;;; chime--parse-notify-before-value
(ert-deftest test-chime-parse-notify-before-value-normal-and-boundary ()
"Normal/Boundary: non-negative integer strings parse to integers."
(dolist (case '(("30" . 30) ("0" . 0) (" 30 " . 30) ("007" . 7) ("1440" . 1440)))
(should (= (cdr case)
(chime--parse-notify-before-value (car case))))))
(ert-deftest test-chime-parse-notify-before-value-error-cases ()
"Error: non-integer, negative, fractional, empty, suffixed, and nil values yield nil."
(dolist (bad '("abc" "-5" "30.5" "" " " "30m" nil))
(should-not (chime--parse-notify-before-value bad))))
;;; chime--intervals-for-marker
(ert-deftest test-chime-intervals-for-marker-normal-no-property-uses-global ()
"Normal: with no override property, returns (chime-alert-intervals . nil)."
(let ((chime-alert-intervals '((10 . medium) (0 . high))))
(test-chime-intervals--with-marker nil
(should (equal (cons '((10 . medium) (0 . high)) nil)
(chime--intervals-for-marker marker))))))
(ert-deftest test-chime-intervals-for-marker-normal-canonical-property ()
"Normal: :CHIME_NOTIFY_BEFORE: 30 yields (((30 . medium)) . nil)."
(test-chime-intervals--with-marker '(("CHIME_NOTIFY_BEFORE" . "30"))
(should (equal (cons '((30 . medium)) nil)
(chime--intervals-for-marker marker)))))
(ert-deftest test-chime-intervals-for-marker-normal-deprecated-alias ()
"Normal: :WILD_NOTIFIER_NOTIFY_BEFORE: 15 yields the override and flags the alias."
(test-chime-intervals--with-marker '(("WILD_NOTIFIER_NOTIFY_BEFORE" . "15"))
(should (equal (cons '((15 . medium)) "WILD_NOTIFIER_NOTIFY_BEFORE")
(chime--intervals-for-marker marker)))))
(ert-deftest test-chime-intervals-for-marker-normal-canonical-wins-over-alias ()
"Normal: with both properties set, the canonical one wins and the alias is not flagged."
(test-chime-intervals--with-marker '(("CHIME_NOTIFY_BEFORE" . "5")
("WILD_NOTIFIER_NOTIFY_BEFORE" . "60"))
(should (equal (cons '((5 . medium)) nil)
(chime--intervals-for-marker marker)))))
(ert-deftest test-chime-intervals-for-marker-boundary-zero ()
"Boundary: :CHIME_NOTIFY_BEFORE: 0 means notify at event time."
(test-chime-intervals--with-marker '(("CHIME_NOTIFY_BEFORE" . "0"))
(should (equal (cons '((0 . medium)) nil)
(chime--intervals-for-marker marker)))))
(ert-deftest test-chime-intervals-for-marker-error-malformed-canonical-falls-back ()
"Error: a malformed :CHIME_NOTIFY_BEFORE: value logs and falls back to the global."
(let ((chime-alert-intervals '((10 . medium)))
(messages nil))
(test-chime-intervals--with-marker '(("CHIME_NOTIFY_BEFORE" . "soon"))
(cl-letf (((symbol-function 'message)
(lambda (fmt &rest args) (push (apply #'format fmt args) messages))))
(should (equal (cons '((10 . medium)) nil)
(chime--intervals-for-marker marker))))
(should (cl-some (lambda (m) (string-match-p "CHIME_NOTIFY_BEFORE" m)) messages)))))
(ert-deftest test-chime-intervals-for-marker-error-malformed-alias-falls-back ()
"Error: a malformed deprecated-alias value logs and falls back to the global."
(let ((chime-alert-intervals '((10 . medium)))
(messages nil))
(test-chime-intervals--with-marker '(("WILD_NOTIFIER_NOTIFY_BEFORE" . "-3"))
(cl-letf (((symbol-function 'message)
(lambda (fmt &rest args) (push (apply #'format fmt args) messages))))
(should (equal (cons '((10 . medium)) nil)
(chime--intervals-for-marker marker))))
(should (cl-some (lambda (m) (string-match-p "WILD_NOTIFIER_NOTIFY_BEFORE" m)) messages)))))
;;; chime--gather-info integration
(ert-deftest test-chime-gather-info-integration-applies-canonical-override ()
"Integration: a heading with :CHIME_NOTIFY_BEFORE: 25 gathers an event with ((25 . medium))."
(test-chime-intervals--with-marker '(("CHIME_NOTIFY_BEFORE" . "25"))
(let ((event (chime--gather-info marker)))
(should (equal '((25 . medium)) (chime--event-intervals event)))
(should-not (chime--event-deprecated-property event)))))
(ert-deftest test-chime-gather-info-integration-flags-deprecated-alias ()
"Integration: a heading with the deprecated alias gathers an event carrying the deprecation flag."
(test-chime-intervals--with-marker '(("WILD_NOTIFIER_NOTIFY_BEFORE" . "20"))
(let ((event (chime--gather-info marker)))
(should (equal '((20 . medium)) (chime--event-intervals event)))
(should (string= "WILD_NOTIFIER_NOTIFY_BEFORE"
(chime--event-deprecated-property event))))))
(ert-deftest test-chime-gather-info-integration-no-override-uses-global ()
"Integration: a heading without the property gathers with chime-alert-intervals."
(let ((chime-alert-intervals '((10 . medium) (0 . high))))
(test-chime-intervals--with-marker nil
(let ((event (chime--gather-info marker)))
(should (equal '((10 . medium) (0 . high)) (chime--event-intervals event)))
(should-not (chime--event-deprecated-property event))))))
;;; chime--maybe-warn-deprecated-properties
(ert-deftest test-chime-maybe-warn-deprecated-properties-normal-warns-once ()
"Normal: the first events list carrying a deprecated property triggers one warning."
(let ((chime--deprecated-property-warned nil)
(warned nil))
(cl-letf (((symbol-function 'display-warning)
(lambda (_type msg &rest _) (push msg warned))))
(chime--maybe-warn-deprecated-properties
(list (chime--make-event '(("<2026-05-12 Tue 14:00>" . (1 2))) "A" '((10 . medium)))
(chime--make-event '(("<2026-05-12 Tue 15:00>" . (3 4))) "B" '((20 . medium))
nil nil "WILD_NOTIFIER_NOTIFY_BEFORE")))
(should (= 1 (length warned)))
(should chime--deprecated-property-warned)
(should (string-match-p "WILD_NOTIFIER_NOTIFY_BEFORE" (car warned))))))
(ert-deftest test-chime-maybe-warn-deprecated-properties-boundary-no-deprecated-no-warning ()
"Boundary: events with no deprecated property produce no warning, guard stays nil."
(let ((chime--deprecated-property-warned nil)
(warned nil))
(cl-letf (((symbol-function 'display-warning)
(lambda (&rest _) (push t warned))))
(chime--maybe-warn-deprecated-properties
(list (chime--make-event '(("<2026-05-12 Tue 14:00>" . (1 2))) "A" '((10 . medium)))))
(should (null warned))
(should-not chime--deprecated-property-warned))))
(ert-deftest test-chime-maybe-warn-deprecated-properties-boundary-already-warned-no-repeat ()
"Boundary: once the session guard is set, no further warning fires."
(let ((chime--deprecated-property-warned t)
(warned nil))
(cl-letf (((symbol-function 'display-warning)
(lambda (&rest _) (push t warned))))
(chime--maybe-warn-deprecated-properties
(list (chime--make-event '(("<2026-05-12 Tue 14:00>" . (1 2))) "A" '((20 . medium))
nil nil "WILD_NOTIFIER_NOTIFY_BEFORE")))
(should (null warned)))))
(provide 'test-chime-intervals-for-marker)
;;; test-chime-intervals-for-marker.el ends here
|
