summaryrefslogtreecommitdiff
path: root/todo.org
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-03-06 14:50:31 -0600
committerCraig Jennings <c@cjennings.net>2026-03-06 14:50:31 -0600
commit786171248678dc1769be1f24d4bc875761f8a451 (patch)
tree2c24a590a6da158f977b8a31fd0e7949c84a82be /todo.org
parentfc271461ac3b16ec161750335b5cb0bc81660639 (diff)
fix(slack): fix notification and mark-as-read bugs
Notifications silently failed: slack-room-im-p (nonexistent) replaced with slack-im-p; slack-message-to-string replaced with slack-message-body. Mark-as-read bound to nonexistent function; added cj/slack-mark-read-and-bury.
Diffstat (limited to 'todo.org')
-rw-r--r--todo.org43
1 files changed, 43 insertions, 0 deletions
diff --git a/todo.org b/todo.org
index c7054d44..3af97067 100644
--- a/todo.org
+++ b/todo.org
@@ -71,6 +71,49 @@ to better defaults via org-reveal-head-preamble CSS or custom theme.
Create a custom reveal.js CSS theme using colors from themes/dupre-palette.el.
Install into reveal.js/css/theme/ for use with #+REVEAL_THEME: dupre.
+** Slack
+
+*** VERIFY [#B] Test Slack desktop notifications (DM and @mention)
+
+Notifications were silently failing due to two bugs in cj/slack-notify:
+1. ~slack-room-im-p~ (nonexistent) → ~slack-im-p~ (correct EIEIO predicate)
+2. ~slack-message-to-string~ (propertized) → ~slack-message-body~ (plain text)
+
+**Testing Steps:**
+
+1. Open slack-config.el and run ~M-x eval-buffer~
+2. Connect to Slack: ~C-; S s~
+3. In any Slack channel, type ~/remind me in 1 minute test notification~
+4. Wait for Slackbot DM — a desktop notification should appear
+5. Verify notification shows "Slack: DM: Slackbot" as title with message body
+
+**If notification does NOT appear:**
+- Check ~*Messages*~ buffer for errors mentioning ~cj/slack-notify~
+- Verify ~notify~ command works standalone: run ~notify info "Test" "Hello"~ in a terminal
+
+**Files Modified:**
+- modules/slack-config.el (cj/slack-notify function)
+
+*** VERIFY [#B] Test Slack mark-as-read and bury buffer (C-; S q)
+
+~C-; S q~ was bound to ~slack-buffer-mark-as-read-and-bury~ which doesn't exist
+in the emacs-slack package. Replaced with ~cj/slack-mark-read-and-bury~.
+
+**Testing Steps:**
+
+1. Open slack-config.el and run ~M-x eval-buffer~
+2. Connect to Slack: ~C-; S s~
+3. Open any channel with unread messages: ~C-; S c~
+4. Press ~C-; S q~ — buffer should bury without error
+5. Reopen the same channel: ~C-; S c~ — it should no longer appear as unread
+
+**If it errors:**
+- Check ~*Messages*~ buffer for the specific error
+- Verify ~slack-current-buffer~ is bound in the Slack buffer: ~C-h v slack-current-buffer~
+
+**Files Modified:**
+- modules/slack-config.el (new cj/slack-mark-read-and-bury function + keybinding)
+
** Mail
*** VERIFY [#B] Fix mail attachment workflow (currently awkward)