blob: 37a7f94d9b861b8031011f5a56be57f63392795d (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
;;; test-video-audio-recording-process-sentinel.el --- Tests for cj/recording-process-sentinel -*- lexical-binding: t; -*-
;;; Commentary:
;; Unit tests for cj/recording-process-sentinel function.
;; Tests process cleanup and modeline update when recording processes exit.
;;; Code:
(require 'ert)
;; Stub dependencies before loading the module
(defvar cj/custom-keymap (make-sparse-keymap)
"Stub keymap for testing.")
;; Now load the actual production module
(require 'video-audio-recording)
;;; Setup and Teardown
(defun test-sentinel-setup ()
"Reset process variables before each test."
(setq cj/audio-recording-ffmpeg-process nil)
(setq cj/video-recording-ffmpeg-process nil))
(defun test-sentinel-teardown ()
"Clean up process variables after each test."
(setq cj/audio-recording-ffmpeg-process nil)
(setq cj/video-recording-ffmpeg-process nil))
;;; Normal Cases
(ert-deftest test-video-audio-recording-process-sentinel-normal-audio-exit-clears-variable ()
"Test that sentinel clears audio process variable when process exits."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sh" "-c" "exit 0"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock process-status to return 'exit
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'exit)))
;; Call sentinel with exit status
(cj/recording-process-sentinel fake-process "finished\n")
;; Variable should be cleared
(should (null cj/audio-recording-ffmpeg-process))))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-normal-video-exit-clears-variable ()
"Test that sentinel clears video process variable when process exits."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-video" :command '("sh" "-c" "exit 0"))))
(setq cj/video-recording-ffmpeg-process fake-process)
;; Mock process-status to return 'exit
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'exit)))
;; Call sentinel with exit status
(cj/recording-process-sentinel fake-process "finished\n")
;; Variable should be cleared
(should (null cj/video-recording-ffmpeg-process))))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-normal-signal-status-clears-variable ()
"Test that sentinel clears variable on signal status (killed)."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sleep" "1000"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
(delete-process fake-process)
;; Call sentinel with signal status
(cj/recording-process-sentinel fake-process "killed\n")
;; Variable should be cleared
(should (null cj/audio-recording-ffmpeg-process)))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-normal-modeline-update-called ()
"Test that sentinel triggers modeline update."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sh" "-c" "exit 0")))
(update-called nil))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock force-mode-line-update to track if it's called
(cl-letf (((symbol-function 'force-mode-line-update)
(lambda (&optional _all) (setq update-called t))))
(cj/recording-process-sentinel fake-process "finished\n")
(should update-called)))
(test-sentinel-teardown)))
;;; Boundary Cases
(ert-deftest test-video-audio-recording-process-sentinel-boundary-run-status-ignored ()
"Test that sentinel ignores processes in 'run status (still running)."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sleep" "1000"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock process-status to return 'run
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'run)))
(cj/recording-process-sentinel fake-process "run")
;; Variable should NOT be cleared
(should (eq fake-process cj/audio-recording-ffmpeg-process)))
(delete-process fake-process))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-boundary-open-status-ignored ()
"Test that sentinel ignores processes in 'open status."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sleep" "1000"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'open)))
(cj/recording-process-sentinel fake-process "open")
;; Variable should NOT be cleared
(should (eq fake-process cj/audio-recording-ffmpeg-process)))
(delete-process fake-process))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-boundary-event-trimmed ()
"Test that event string is trimmed in message."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sh" "-c" "exit 0")))
(message-text nil))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock message to capture output
(cl-letf (((symbol-function 'message)
(lambda (fmt &rest args) (setq message-text (apply #'format fmt args)))))
(cj/recording-process-sentinel fake-process " finished \n")
;; Message should contain trimmed event
(should (string-match-p "finished" message-text))
;; Should not have extra whitespace
(should-not (string-match-p " finished " message-text))))
(test-sentinel-teardown)))
;;; Error Cases
(ert-deftest test-video-audio-recording-process-sentinel-error-unknown-process-ignored ()
"Test that sentinel handles unknown process (not audio or video) gracefully."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-unknown" :command '("sh" "-c" "exit 0")))
(audio-proc (make-process :name "test-audio" :command '("sleep" "1000")))
(video-proc (make-process :name "test-video" :command '("sleep" "1000"))))
(setq cj/audio-recording-ffmpeg-process audio-proc)
(setq cj/video-recording-ffmpeg-process video-proc)
;; Call sentinel with unknown process
(cj/recording-process-sentinel fake-process "finished\n")
;; Audio and video variables should NOT be cleared
(should (eq audio-proc cj/audio-recording-ffmpeg-process))
(should (eq video-proc cj/video-recording-ffmpeg-process))
(delete-process audio-proc)
(delete-process video-proc))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-error-nil-event-handled ()
"Test that sentinel handles nil event string gracefully."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sh" "-c" "exit 0"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock process-status to return 'exit
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'exit)))
;; Should not crash with nil event (string-trim will error, but that's caught)
;; The function uses string-trim without protection, so this will error
;; Testing that it doesn't crash means we expect an error
(should-error
(cj/recording-process-sentinel fake-process nil))))
(test-sentinel-teardown)))
(ert-deftest test-video-audio-recording-process-sentinel-error-empty-event-handled ()
"Test that sentinel handles empty event string gracefully."
(test-sentinel-setup)
(unwind-protect
(let ((fake-process (make-process :name "test-audio" :command '("sh" "-c" "exit 0"))))
(setq cj/audio-recording-ffmpeg-process fake-process)
;; Mock process-status to return 'exit
(cl-letf (((symbol-function 'process-status)
(lambda (_proc) 'exit)))
;; Empty string is fine - string-trim handles it
;; No error should be raised
(cj/recording-process-sentinel fake-process "")
;; Variable should be cleared
(should (null cj/audio-recording-ffmpeg-process))))
(test-sentinel-teardown)))
(provide 'test-video-audio-recording-process-sentinel)
;;; test-video-audio-recording-process-sentinel.el ends here
|
