chore(todo): dashboard icons (Cause C) done, reframe item-color as theme-studio work

Cause C (per-filetype file icons) is fixed and committed. Cause B reframed per Craig: items already default to fg, coloring routes through theme-studio (task 2418), no hardcoded hex. Filed a visual-verify VERIFY.

1 files changed, 6 insertions, 2 deletions

diff --git a/todo.org b/todo.org
index 15fcbed1c..c193f1265 100644
--- a/todo.org
+++ b/todo.org
@@ -53,11 +53,11 @@ FIX A — DONE 2026-06-16, commit =202cf430=: exclude dashboard-mode from global
 
 *** Cause B — project/bookmark/recent items have no color
 Items and the navigator are painted by a =dashboard-items-face= button OVERLAY (overlays survive font-lock, which is why Cause A didn't touch them). But in =WIP-theme.el= =dashboard-items-face= is just =(:inherit widget-button)= — unspecified foreground, so it renders in the default color. 7496 had colored it (steel+2) in the now-retired Dupre theme; that color never carried into WIP. Per 7496, the navigator and items share =dashboard-items-face=, so coloring it colors both (separating them is the open task "Color dashboard navigator independently of list items", 7740).
-FIX B: give =dashboard-items-face= (and =dashboard-no-items-face=) an explicit =:foreground= in the WIP theme. Craig's color choice.
+FIX B (per Craig 2026-06-16 — no hardcoded colors, theme it): the items already fall back to the default foreground (=dashboard-items-face= inherits =widget-button= -> unspecified -> default fg), which is the right default. To actually COLOR them, theme-studio must expose =dashboard-items-face= so the color comes from the theme, not a hardcoded hex in =WIP-theme.el=. That is the items half of task 2418. No config/theme change here; this routes to 2418.
 
 *** Cause C — no icons on items or section titles
 =dashboard-set-file-icons= and =dashboard-set-heading-icons= are both nil in the live config (=dashboard-config.el= sets =dashboard-display-icons-p t= + =dashboard-icon-type 'nerd-icons= but never the two enable toggles), so dashboard renders no file/section icons. Only the custom navigator row has icons.
-FIX C: set =dashboard-set-file-icons t= (file/project/bookmark icons) and optionally =dashboard-set-heading-icons t= (section-title icons) in =dashboard-config.el=. Icon color: nerd-icons colors file icons per-filetype by default; a uniform theme color needs overriding the icon face — decide per-type vs uniform.
+FIX C — file icons DONE 2026-06-16, commit =1c97cba7=: =(setq dashboard-set-file-icons t)= in =dashboard-config.el=. Items now show nerd-icons file icons colored per filetype (verified live: =todo.org= -> nerd-icons-lgreen, project dirs -> nerd-icons-yellow; bookmarks fall back to a generic uncolored icon, no filetype to map). Per Craig: per-filetype (the nerd-icons default). They render only because Fix A took the dashboard out of font-lock, which was stripping the icon faces too. OPEN (offered, not done): =dashboard-set-heading-icons t= would add icons to the section titles — left off pending Craig's call.
 
 *** Studio angle
 To set the item color from theme-studio instead of hand-editing =WIP-theme.el=, the studio's dashboard app must expose =dashboard-items-face= as editable — the "list items unthemed" half of task 2418 (theme-studio: dashboard preview icons missing, list items unthemed).
@@ -4568,6 +4568,10 @@ No dedicated update path today — refreshing a pinned package means ad-hoc =cp=
 
 ** TODO Manual testing and validation
 Exercised once the phases above land.
+*** VERIFY dashboard theming — banner gold, headings themed, items show per-filetype icons
+What we're verifying: with the dashboard out of global font-lock (Fix A) and file icons on (Fix C), the live dashboard shows the theme colors and icons. Eyeball it.
+- Open the dashboard (F1)
+Expected: the "Emacs:" banner title is gold, the "Projects:/Bookmarks:/Recent Files:" headings are themed blue, and the project/recent-file rows each show a colored per-filetype icon (org files greenish, dirs yellow; bookmarks a plain icon).
 *** VERIFY gptel C-; a B switches model without the modeline hang
 What we're verifying: cj/gptel-switch-backend (C-; a B) now sets gptel-model to an interned symbol, so the switch completes without the wrong-type-argument-symbolp redisplay hang. Unit tests + a live helper eval already cover the coercion; this is the interactive end-to-end.
 - Invoke cj/gptel-switch-backend (C-; a B)