diff options
| author | Craig Jennings <c@cjennings.net> | 2026-06-24 18:10:39 -0400 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-06-24 18:10:39 -0400 |
| commit | 70c45532f6949e6e4b30d8db2b9b2ef831a11ebb (patch) | |
| tree | 2a9846d3cfced2a93b887387861c29baf337888c | |
| parent | fd1969eda49b2e6c562439ecea9430ace164e16d (diff) | |
| download | dotemacs-70c45532f6949e6e4b30d8db2b9b2ef831a11ebb.tar.gz dotemacs-70c45532f6949e6e4b30d8db2b9b2ef831a11ebb.zip | |
chore(todo): log theme-studio tier-1 simplification completion
| -rw-r--r-- | todo.org | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -378,6 +378,10 @@ What we're verifying: in dirvish, d now duplicates the file at point (delete-to- Expected: d duplicates; D names the exact targets and only deletes on yes; the files are gone with no trash copy. If sudo needs a password that shell-command can't supply, flag it — the delete may need to route through a tty instead. ** PROJECT [#A] Theme-Studio Open Work Parent grouping the open theme-studio / theming issues; close each child independently. +*** 2026-06-24 Wed @ 18:09:26 -0400 theme-studio tier-1 simplifications landed +Behavior-preserving simplifications from the four-agent refactor/simplify assessment, all test-verified (full suite green). Landed: syncMockHeight + syncPkgHeight merged into syncPaneHeight(tableId, paneId); the dead generatorHues "manual" branch deleted (identical to fallback); locateInfoLine removed (fn + export + test, orphaned this session); the redundant pkgbody guard dropped (buildPkgTable self-guards); displayHex/displayName closures inlined; paintUI now calls worstCellHtml; generate.py's two nerd-icons loaders share _load_nerd_icons_artifact (sentinel keeps the null-file edge exact); face_coverage.classify rewritten with named locals (with a new characterization test). Two agent findings were wrong and skipped on verification: LOCATE_REG is live (read by previewSpan), and normalizePaletteEntryCore doesn't exist (hallucinated). Skipped on judgment: a RELEASED_BOX constant (mutable-dict aliasing hazard, only ~10 sites) and inlining apply_hover_box_default (its why-docstring earns the named function). Open for Craig: previewFaceAttrs (app-core.js) is test-only with a stale "the gate calls it" docstring — confirm delete vs keep. +*** TODO [#D] theme-studio app.js module split (tier 2) :refactor:studio: +Optional structural change. app.js (927 lines) holds seven responsibility clusters. Split into controls.js / picker.js / locate.js / io.js / tables.js — near-zero runtime risk since generate.py concatenates source by token. Navigability win only; do it only if scrolling app.js becomes real friction. *** TODO [#A] theme-studio: consistent assignment-view table columns :feature:studio:next: All view-assignment tables should use one consistent column set and order, whatever view is selected: element name (sortable), lock, fg, bg, style, box (with a side expansion showing the selected color, as in UI faces), contrast, inheritance, size, preview text. No other columns at this design stage. When a view's elements can't take a given section, raise a signal and disable that section for that view; the disabled state is the visual cue. From the roam inbox 2026-06-16. *** TODO [#B] Route hardcoded theme colors through the theme :refactor: |
