aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-06-25 01:10:09 -0400
committerCraig Jennings <c@cjennings.net>2026-06-25 01:10:09 -0400
commit7bf7c244886ee37d40a633e0c365e0517a46dbe4 (patch)
tree258a22e2d47c6e7d456b50e42e67fc567010cd84
parent12610e7255c37c77f3eaae5b2da33f79ea6b7472 (diff)
downloaddotemacs-7bf7c244886ee37d40a633e0c365e0517a46dbe4.tar.gz
dotemacs-7bf7c244886ee37d40a633e0c365e0517a46dbe4.zip
chore(todo): file eww User-Agent advice test failure (pre-existing, Emacs 30 derived-mode-p)
-rw-r--r--todo.org2
1 files changed, 2 insertions, 0 deletions
diff --git a/todo.org b/todo.org
index 76f74b579..c958e050c 100644
--- a/todo.org
+++ b/todo.org
@@ -55,6 +55,8 @@ Tags are additive. For example, a small wrong-behavior fix can be
=:bug:quick:=, and a feature that requires internal restructuring can be
=:feature:refactor:=.
* Emacs Open Work
+** TODO [#B] eww User-Agent advice may not inject under Emacs 30 :bug:
+The UA-injection advice =my-eww--inject-user-agent= (=modules/eww-config.el:47=) gates on =(derived-mode-p 'eww-mode)= and is an =:around= on =url-retrieve= / =url-retrieve-synchronously=. Its tests (=tests/test-eww-config-user-agent-advice.el=) fail under =make test=: =test-eww-ua-injected-in-eww-buffer= (:21) and =test-eww-ua-replaces-existing-and-keeps-other-headers= (:42) both see no injected UA, because =(derived-mode-p 'eww-mode)= returns nil in the test's temp buffer where the mode is set with a bare =(setq major-mode 'eww-mode)=. Two possibilities: (a) test-only artifact — a bare setq doesn't establish the mode the way =derived-mode-p= now resolves it, so the test should set the mode properly (call =eww-mode=, or set =derived-mode-parent=); or (b) a real Emacs-30 =derived-mode-p= change that means the advice no longer fires in real eww buffers either, so the desktop User-Agent isn't actually sent. Check (b) first: in a live eww page, =M-: (derived-mode-p 'eww-mode)= — if nil, the gate is broken in production (fix to =(eq major-mode 'eww-mode)= or =provided-mode-derived-p=). If only the test is wrong, fix its mode setup. Pre-existing (eww-config + test unchanged this session); surfaced 2026-06-25 running the full suite during the google-keep work. The third test (=test-eww-ua-not-injected-outside-eww=) passes.
** TODO [#B] first f12 doesn't toggle the term window :bug:solo:
The first =f12= of a session flashes the terminal open and immediately closes it, as if the toggle fired on then off; a second =f12= then works. Seen across two separate sessions. From the roam inbox 2026-06-24.
** TODO [#C] org-capture popup leaks f12 / f10 / f11 / ai-term keys :bug: