aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-07-18 15:46:12 -0500
committerCraig Jennings <c@cjennings.net>2026-07-18 15:46:12 -0500
commit97445c8b04327317d617fde7be664a82230f3fb5 (patch)
treee00ffe60cef08cd33778c33b021d984e0bf78719
parent52c031775dca66d308cc341271900258f36b5895 (diff)
downloaddotemacs-97445c8b04327317d617fde7be664a82230f3fb5.tar.gz
dotemacs-97445c8b04327317d617fde7be664a82230f3fb5.zip
fix(music): raise the playlist dock default to half the frame
-rw-r--r--modules/music-config.el12
-rw-r--r--tests/test-music-config--playlist-dock.el7
2 files changed, 10 insertions, 9 deletions
diff --git a/modules/music-config.el b/modules/music-config.el
index 5f35d2cc..bff0f5ce 100644
--- a/modules/music-config.el
+++ b/modules/music-config.el
@@ -898,13 +898,13 @@ Intended for use on `emms-player-finished-hook'."
)
-(defvar cj/music-playlist-window-height 0.33
+(defvar cj/music-playlist-window-height 0.5
"Default fraction of frame height for the F10 music playlist side window.
-A third of the frame, so a playlist of real length shows enough rows.
-Used when the playlist hasn't been resized and toggled off this session;
-after that, the toggled-off height is remembered in
-`cj/--music-playlist-height' -- but only when it's at least this default
-\(see the discard in `cj/music-playlist-toggle').")
+Half the frame, so a playlist of real length shows enough rows (a third
+still read too short in practice). Used when the playlist hasn't been
+resized and toggled off this session; after that, the toggled-off height
+is remembered in `cj/--music-playlist-height' -- but only when it's at
+least this default (see the discard in `cj/music-playlist-toggle').")
(defvar cj/--music-playlist-height nil
"Last height fraction the playlist was toggled off at.
diff --git a/tests/test-music-config--playlist-dock.el b/tests/test-music-config--playlist-dock.el
index 501ff272..1dbe9fbb 100644
--- a/tests/test-music-config--playlist-dock.el
+++ b/tests/test-music-config--playlist-dock.el
@@ -70,9 +70,10 @@ silently does nothing."
(should-not (boundp 'cj/--music-playlist-width))
(should-not (fboundp 'cj/--music-playlist-side)))
-(ert-deftest test-music-config-playlist-default-height-is-a-third ()
- "Normal: the dock opens at a third of the frame height by default."
- (should (= cj/music-playlist-window-height 0.33)))
+(ert-deftest test-music-config-playlist-default-height-is-half ()
+ "Normal: the dock opens at half the frame height by default (Craig,
+2026-07-18 -- a third still read too short for a real playlist)."
+ (should (= cj/music-playlist-window-height 0.5)))
(ert-deftest test-music-config-playlist-toggle-off-discards-shrunk-height ()
"Error: a captured height below the default is discarded. Window churn