refactor(local-repository): drop the dead archive-init path

localrepo-initialize, localrepo--car-member, and the repository-id/priority defcustoms were never called: early-init.el owns adding the local archive to package-archives, with its own localrepo-location constant. The module is now just cj/update-localrepo-repository. It targets localrepo-location, so there's one archive path instead of a divergent copy. The car-member test goes with its subject. A new test pins that the mirror update uses localrepo-location.

3 files changed, 41 insertions, 111 deletions

diff --git a/modules/local-repository.el b/modules/local-repository.el
index e3c7a227..0f2c981c 100644
--- a/modules/local-repository.el
+++ b/modules/local-repository.el
@@ -6,72 +6,28 @@
 ;; Layer: 4 (Optional).
 ;; Category: O/D/P.
 ;; Load shape: eager.
-;; Eager reason: none; local package mirror commands can autoload.
+;; Eager reason: none; the mirror-refresh command can autoload.
 ;; Top-level side effects: none.
 ;; Runtime requires: elpa-mirror when updating the mirror.
 ;; Direct test load: yes.
 ;;
-;; Adds the checked-in local package archive to package-archives with high
-;; priority, and provides a command to refresh that archive from installed
-;; packages via elpa-mirror.
+;; Provides a command to refresh the checked-in local package archive from the
+;; installed packages via elpa-mirror.  Adding that archive to package-archives
+;; is owned by early-init.el (see `localrepo-location'); this module only
+;; refreshes it.
 
 ;;; Code:
 
 (require 'elpa-mirror nil t)  ;; optional; cj/update-localrepo-repository fails at call-time if absent
 
 (declare-function elpamr-create-mirror-for-installed "elpa-mirror")
-
-;; ------------------------------ Utility Function -----------------------------
-
-
-(defun localrepo--car-member (value list)
-  "Check if VALUE exists as the car of any cons cell in LIST."
-  (member value (mapcar #'car list)))
-
-;; ------------------------------- Customizations ------------------------------
-
-(defgroup localrepo nil
-  "Local last-known-good package repository."
-  :group 'package)
-
-(defcustom localrepo-repository-id "localrepo"
-  "The name used to identify the local repository internally.
-
-Used for the package-archive and package-archive-priorities lists."
-  :type 'string
-  :group 'localrepo)
-
-(defcustom localrepo-repository-priority 100
-  "The value for the local repository in the package-archive-priority list.
-
-A higher value means higher priority. If you want your local packages to be
-preferred, this must be a higher number than any other repositories."
-  :type 'integer
-  :group 'localrepo)
-
-(defcustom localrepo-repository-location
-  (concat user-emacs-directory "/.localrepo")
-  "The location of the local repository.
-
-It's a good idea to keep this with the rest of your configuration files and
-keep them in source control."
-  :type 'directory
-  :group 'localrepo)
+(defvar localrepo-location)  ;; defconst in early-init.el: the archive path
 
 (defun cj/update-localrepo-repository ()
-  "Update the local repository with currently installed packages."
+  "Update the local repository with currently installed packages.
+Targets `localrepo-location', the archive path early-init.el sets up."
   (interactive)
-  (elpamr-create-mirror-for-installed localrepo-repository-location t))
-
-(defun localrepo-initialize ()
-"Add the repository to the package archives, then gives it a high priority."
-  (unless (localrepo--car-member localrepo-repository-id package-archives)
-	(add-to-list 'package-archives
-				 (cons localrepo-repository-id localrepo-repository-location)))
-
-  (unless (localrepo--car-member localrepo-repository-id package-archive-priorities)
-	(add-to-list 'package-archive-priorities
-				 (cons localrepo-repository-id localrepo-repository-priority))))
+  (elpamr-create-mirror-for-installed localrepo-location t))
 
 (provide 'local-repository)
 ;;; local-repository.el ends here.
diff --git a/tests/test-local-repository--car-member.el b/tests/test-local-repository--car-member.el
deleted file mode 100644
index 30ae58c6..00000000
--- a/tests/test-local-repository--car-member.el
+++ /dev/null
@@ -1,58 +0,0 @@
-;;; test-local-repository--car-member.el --- Tests for localrepo--car-member -*- lexical-binding: t -*-
-
-;;; Commentary:
-;; Tests for `localrepo--car-member' in local-repository.el — the predicate
-;; localrepo-initialize uses to check whether an archive id is already
-;; registered in package-archives / package-archive-priorities.
-
-;;; Code:
-
-(require 'ert)
-(require 'local-repository)
-
-;;; Normal Cases
-
-(ert-deftest test-local-repository-localrepo--car-member-found ()
-  "Normal: VALUE present as a car returns the matching tail (non-nil)."
-  (should (equal (localrepo--car-member 'b '((a . 1) (b . 2) (c . 3)))
-                 '(b c))))
-
-(ert-deftest test-local-repository-localrepo--car-member-not-found ()
-  "Normal: VALUE absent from every car returns nil."
-  (should-not (localrepo--car-member 'z '((a . 1) (b . 2)))))
-
-(ert-deftest test-local-repository-localrepo--car-member-string-car ()
-  "Normal: car comparison uses `equal', so string keys match by value."
-  (should (localrepo--car-member "localrepo"
-                      '(("gnu" . "url1") ("localrepo" . "url2")))))
-
-;;; Boundary Cases
-
-(ert-deftest test-local-repository-localrepo--car-member-empty-list ()
-  "Boundary: an empty list never matches."
-  (should-not (localrepo--car-member 'a nil)))
-
-(ert-deftest test-local-repository-localrepo--car-member-single-match ()
-  "Boundary: a single-element list whose car matches returns non-nil."
-  (should (localrepo--car-member 'only '((only . 1)))))
-
-(ert-deftest test-local-repository-localrepo--car-member-single-no-match ()
-  "Boundary: a single-element list whose car differs returns nil."
-  (should-not (localrepo--car-member 'x '((only . 1)))))
-
-(ert-deftest test-local-repository-localrepo--car-member-nil-value-with-nil-car ()
-  "Boundary: a nil VALUE matches a cons whose car is nil."
-  (should (localrepo--car-member nil '((nil . 1) (a . 2)))))
-
-(ert-deftest test-local-repository-localrepo--car-member-nil-value-no-nil-car ()
-  "Boundary: a nil VALUE with no nil car returns nil."
-  (should-not (localrepo--car-member nil '((a . 1) (b . 2)))))
-
-;;; Error Cases
-
-(ert-deftest test-local-repository-localrepo--car-member-non-cons-element ()
-  "Error: a non-cons element makes `car' signal wrong-type-argument."
-  (should-error (localrepo--car-member 'x '(1 2)) :type 'wrong-type-argument))
-
-(provide 'test-local-repository--car-member)
-;;; test-local-repository--car-member.el ends here
diff --git a/tests/test-local-repository.el b/tests/test-local-repository.el
new file mode 100644
index 00000000..132f8dc4
--- /dev/null
+++ b/tests/test-local-repository.el
@@ -0,0 +1,32 @@
+;;; test-local-repository.el --- Tests for the local-repository update command -*- lexical-binding: t; -*-
+
+;;; Commentary:
+;; `cj/update-localrepo-repository' refreshes the checked-in local package
+;; archive at `localrepo-location' (owned by early-init.el) via elpa-mirror.
+;; The elpa-mirror call is mocked at the boundary.
+
+;;; Code:
+
+(require 'ert)
+(require 'cl-lib)
+
+(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(require 'local-repository)
+
+;; localrepo-location is a defconst in early-init.el, which `make test' never
+;; loads.  Declare it special here so the `let' below binds it dynamically and
+;; the module reads that value.
+(defvar localrepo-location nil)
+
+(ert-deftest test-local-repository-update-targets-early-init-location ()
+  "Normal: the mirror update targets `localrepo-location', the single archive
+path early-init.el owns, not a divergent module-local copy."
+  (let ((localrepo-location "/tmp/test-localrepo/")
+        (captured nil))
+    (cl-letf (((symbol-function 'elpamr-create-mirror-for-installed)
+               (lambda (dir &rest _) (setq captured dir))))
+      (cj/update-localrepo-repository)
+      (should (equal captured "/tmp/test-localrepo/")))))
+
+(provide 'test-local-repository)
+;;; test-local-repository.el ends here