aboutsummaryrefslogtreecommitdiff
path: root/githooks
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-05-03 21:11:26 -0500
committerCraig Jennings <c@cjennings.net>2026-05-03 21:11:26 -0500
commit31edc86a54d20c3c73d0ebad247fde2c35e6a964 (patch)
tree3b4af9056b22d2ee09e9a7a9bb9196e9a60d89b7 /githooks
parentba1a0249bfbc61ba3590ec0c9cd8b5568980ab22 (diff)
downloaddotemacs-31edc86a54d20c3c73d0ebad247fde2c35e6a964.tar.gz
dotemacs-31edc86a54d20c3c73d0ebad247fde2c35e6a964.zip
fix: scope projectile cache revert state to each compile
The projectile compile/test/run cache-revert protection in `dev-fkeys.el` used a single global variable, `cj/--projectile-revert-state`. Two overlapping compiles could clobber each other's state. The second compile's capture would overwrite the first's. So when the first compile finished and ran the global finish-hook, it'd act on the wrong project's state, or revert nothing because the keys had drifted. I moved the state into a closure. `cj/--projectile-capture-cmd` now returns the state plist instead of mutating the global. `cj/--projectile-around-revert` captures the state into a local, calls the projectile cmd-runner, and installs a one-shot buffer-local finish hook on the returned compilation buffer. The hook closes over its own state plist, so two compiles can finish in any order and each one acts on the right project. I extracted three small helpers along the way. `cj/--projectile-revert-state-on-fail` is the pure decision (revert when failed AND modified AND prior was non-nil). `cj/--projectile-make-revert-on-fail-hook` builds the closure-based one-shot hook. `cj/--projectile-compilation-buffer` normalizes a buffer-or-process result from projectile into a buffer. The legacy `cj/--projectile-revert-on-fail` function still reads the global `cj/--projectile-revert-state`. It stays around for the existing direct tests, but its core logic now delegates to the extracted state-on-fail helper. No production caller adds it to `compilation-finish-functions` anymore. I added one regression test in `test-dev-fkeys--projectile-around-revert.el`: two projectile invocations on different projects, finishes triggered out of order, each compile reverts its own project's cache and leaves the other alone. The capture and around-advice tests were rewritten to match the new return-style API and to assert hooks land buffer-locally rather than globally. 19 projectile-related tests pass together.
Diffstat (limited to 'githooks')
0 files changed, 0 insertions, 0 deletions