refactor(user-constants): move filesystem creation out of module load

(require 'user-constants) created ~8 directories and ~10 org/calendar files at load time, via a top-level dolist for the calendar stubs and a top-level call to cj/initialize-user-directories-and-files. That meant any bare require — tests, byte-compile, batch tools — wrote to disk. It's why a stray sync/org/ tree kept appearing in the repo during test runs.

I removed both top-level forms and folded the gcal/pcal/dcal creation into the initializer. The path defconsts stay exactly as they were, so every consumer that just reads a path is unaffected. init.el now calls the initializer right after requiring the module, guarded by (unless noninteractive), so interactive and daemon startup create everything in the same order as before while a bare require stays side-effect-free.

Added tests/test-user-constants.el: loading the module creates nothing, and the initializer creates the backbone dirs and the configured files. Updated the module header — top-level side effects are now none and it's safe to load in tests.

1 files changed, 2 insertions, 0 deletions

diff --git a/init.el b/init.el
index f65e6085..c0de8b62 100644
--- a/init.el
+++ b/init.el
@@ -21,6 +21,8 @@
 (require 'system-lib)            ;; low-level system utility functions
 (require 'config-utilities)      ;; enable for extra Emacs config debug helpers
 (require 'user-constants)        ;; paths for files referenced in this config
+(unless noninteractive
+  (cj/initialize-user-directories-and-files)) ;; create configured dirs/files on real startup
 (require 'host-environment)      ;; convenience functions re: host environment
 (require 'keyboard-compat)       ;; terminal/GUI keyboard compatibility
 (require 'system-defaults)       ;; native comp; log; unicode, backup, exec path