diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-23 03:21:07 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-23 03:21:07 -0500 |
| commit | 025a54fb3550e7673c7b7f31198665cf6aa3f9bb (patch) | |
| tree | 7199737c7df292ac1611347858ac55907c8ba8c2 /modules/dirvish-config.el | |
| parent | 3ab3de0d0f17749acb97a7acb5b9e018e68afaf9 (diff) | |
| download | dotemacs-025a54fb3550e7673c7b7f31198665cf6aa3f9bb.tar.gz dotemacs-025a54fb3550e7673c7b7f31198665cf6aa3f9bb.zip | |
fix(dirvish): declare runtime constant/util deps with plain require
dirvish-config builds `dirvish-quick-access-entries` from `code-dir`, `music-dir`, `pix-dir`, and the recording dirs at load time, and binds keys to `cj/xdg-open` and `cj/open-file-with-command`. Those come from user-constants and system-utils, but the module only required them under `eval-when-compile`, so the compiled module carries no runtime require and leans on init order having loaded them first.
I switched both to plain requires, matching host-environment, system-lib, and external-open-lib right below. Added a dependency-contract smoke test that fails if the requires are dropped.
Diffstat (limited to 'modules/dirvish-config.el')
| -rw-r--r-- | modules/dirvish-config.el | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/dirvish-config.el b/modules/dirvish-config.el index 5f5ca7fc0..774c9ab78 100644 --- a/modules/dirvish-config.el +++ b/modules/dirvish-config.el @@ -24,8 +24,8 @@ ;;; Code: -(eval-when-compile (require 'user-constants)) -(eval-when-compile (require 'system-utils)) +(require 'user-constants) ;; code-dir, music-dir, pix-dir et al. used at load time +(require 'system-utils) ;; cj/xdg-open, cj/open-file-with-command bound to keys (require 'host-environment) (require 'system-lib) (require 'external-open-lib) |