aboutsummaryrefslogtreecommitdiff
path: root/modules/dwim-shell-config.el
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-07-18 18:24:01 -0500
committerCraig Jennings <c@cjennings.net>2026-07-18 18:24:01 -0500
commit11eb84175a30b96e3fa179723bc486a88d102d05 (patch)
tree6ae85ae210340c7c7de3661d810cfc04e91c72bb /modules/dwim-shell-config.el
parentfbd69990f7e3731a6df4ed992f1aefaef3748750 (diff)
downloaddotemacs-11eb84175a30b96e3fa179723bc486a88d102d05.tar.gz
dotemacs-11eb84175a30b96e3fa179723bc486a88d102d05.zip
fix(shell): require external-open, scope tramp revert, drop dead config
- dirvish-config, dwim-shell-config: both call cj/xdg-open (external-open) but relied on init.el requiring it before them, and dirvish's require comment misattributed it to system-utils. Added the require to both and corrected the comment and both Runtime-requires headers. - tramp-config: revert-without-query was set to '(".*") inside the TRAMP module, so every file in Emacs reverted without confirmation. Scoped it to the TRAMP path regexp, so local files keep their revert prompt and remote files skip the round-trip. - tramp-config: removed the sshfast method (referenced nowhere, scp and sshx handle everything) and a duplicate tramp-own-remote-path add-to-list. Tests: new runtime-requires assertions for both modules, red first under make test-file. The tramp :config edits are verified in the daemon. Suite green.
Diffstat (limited to 'modules/dwim-shell-config.el')
-rw-r--r--modules/dwim-shell-config.el3
1 files changed, 2 insertions, 1 deletions
diff --git a/modules/dwim-shell-config.el b/modules/dwim-shell-config.el
index e8790a48..a334fc4e 100644
--- a/modules/dwim-shell-config.el
+++ b/modules/dwim-shell-config.el
@@ -7,7 +7,7 @@
;; Load shape: eager.
;; Eager reason: none; Dired/Dirvish shell commands can load by command.
;; Top-level side effects: package configuration via use-package.
-;; Runtime requires: cl-lib, system-lib.
+;; Runtime requires: cl-lib, system-lib, external-open.
;; Direct test load: yes.
;;
;; Configures dwim-shell-command actions for marked Dired/Dirvish files:
@@ -23,6 +23,7 @@
(require 'cl-lib)
(require 'system-lib) ;; cj/confirm-strong (permanent file destruction confirm)
+(require 'external-open) ;; cj/xdg-open, called to open conversion output files
;; Function declarations (lazily-loaded packages and sibling modules).
(declare-function dwim-shell-command-on-marked-files "dwim-shell-command")