refactor:eshell-vterm-config): update keymap and eshell loading

Replace `define-key` with `keymap-set` for better key binding
clarity and reliability. Switch eshell loading from `:defer .5` to
`:commands (eshell)` for on-demand loading. Remove unnecessary
`:defer` from `xterm-color`.

1 files changed, 4 insertions, 5 deletions

diff --git a/modules/eshell-vterm-config.el b/modules/eshell-vterm-config.el
index 480b32ecd..4f2d14dfa 100644
--- a/modules/eshell-vterm-config.el
+++ b/modules/eshell-vterm-config.el
@@ -37,7 +37,7 @@
 
 (use-package eshell
   :ensure nil ;; built-in
-  :defer .5
+  :commands (eshell)
   :config
   (setq eshell-banner-message "")
   (setq eshell-scroll-to-bottom-on-input 'all)
@@ -71,8 +71,8 @@
 
   (add-hook 'eshell-hist-mode-hook
             (lambda ()
-              (define-key eshell-hist-mode-map (kbd "<up>") 'previous-line)
-              (define-key eshell-hist-mode-map (kbd "<down>") 'next-line)))
+              (keymap-set eshell-hist-mode-map "<up>" #'previous-line)
+              (keymap-set eshell-hist-mode-map "<down>" #'next-line)))
 
   (add-hook 'eshell-mode-hook
             (lambda ()
@@ -134,7 +134,6 @@
   ("C-<f12>" . eshell-toggle))
 
 (use-package xterm-color
-  :defer .5
   :after eshell
   :hook
   (eshell-before-prompt-hook . (lambda ()
@@ -164,7 +163,7 @@
 
 (add-hook 'eshell-mode-hook
 		  (lambda ()
-			(define-key eshell-mode-map (kbd "C-r") 'cj/eshell-history-search)))
+			(keymap-set eshell-mode-map "C-r" #'cj/eshell-history-search)))
 
 ;; Better completion for eshell
 (use-package pcmpl-args