refactor: extract shared format-region helper into system-lib

prog-json and prog-yaml each carried a byte-identical cj/--<lang>-format-region that runs a formatter over the buffer via call-process-region and replaces it on exit 0. Hoist it to system-lib as cj/format-region-with-program with a generic output buffer, and point both formatters at it. Adds the first direct unit coverage of the helper (Normal, Boundary, Error).

1 files changed, 4 insertions, 27 deletions

diff --git a/modules/prog-yaml.el b/modules/prog-yaml.el
index c2bb559b1..e07cf510e 100644
--- a/modules/prog-yaml.el
+++ b/modules/prog-yaml.el
@@ -9,7 +9,7 @@
 ;; Eager reason: none necessary; currently eager but should load by YAML major
 ;;   mode (Phase 6 deferral candidate).
 ;; Top-level side effects: one add-hook, package configuration via use-package.
-;; Runtime requires: none (configures packages via use-package).
+;; Runtime requires: system-lib (cj/format-region-with-program).
 ;; Direct test load: yes.
 ;;
 ;; YAML editing with tree-sitter highlighting and one-key formatting.
@@ -24,6 +24,8 @@
 
 ;;; Code:
 
+(require 'system-lib)
+
 ;; -------------------------------- YAML Mode ----------------------------------
 ;; tree-sitter mode for YAML files (built-in, Emacs 29+)
 ;; NOTE: No :mode directive — treesit-auto (in prog-general.el) handles
@@ -36,37 +38,12 @@
 ;; -------------------------------- Formatting ---------------------------------
 ;; normalize indentation and style, bound to standard format key
 
-(defun cj/--yaml-format-region (program &rest args)
-  "Replace the buffer with PROGRAM ARGS run over its contents, via argv.
-Runs PROGRAM (with ARGS) on the whole buffer through
-`call-process-region' — no shell, so no quoting or word-splitting.
-The buffer is replaced only when PROGRAM exits zero; on a non-zero
-exit the buffer is left untouched and an error is signalled with
-the program's stderr text.  Point is preserved as closely as the
-reformatted size allows.  Returns t on success."
-  (let* ((point (point))
-         (src (current-buffer))
-         (out (generate-new-buffer " *yaml-format-out*"))
-         (status (apply #'call-process-region
-                        (point-min) (point-max) program
-                        nil out nil args)))
-    (unwind-protect
-        (if (and (integerp status) (zerop status))
-            (progn
-              (with-current-buffer src
-                (replace-buffer-contents out)
-                (goto-char (min point (point-max))))
-              t)
-          (user-error "%s failed: %s" program
-                      (string-trim (with-current-buffer out (buffer-string)))))
-      (kill-buffer out))))
-
 (defun cj/yaml-format-buffer ()
   "Format the current YAML buffer with prettier.
 Preserves point position as closely as possible."
   (interactive)
   (if (executable-find "prettier")
-      (cj/--yaml-format-region "prettier" "--parser" "yaml")
+      (cj/format-region-with-program "prettier" "--parser" "yaml")
     (user-error "prettier not found; install with: npm install -g prettier")))
 
 (defun cj/yaml-setup ()