refactor(ui): remove buffer-state coloring of the buffer name

The modeline colored the buffer name by write and modification state (red read-only, green modified, gold overwrite) through a classifier in user-constants.el. I removed it, the same way the matching cursor coloring was removed earlier for being more confusing than useful. The classifier had no other live user, so it and its two test files go with it. The buffer name now renders in the normal mode-line color.

1 files changed, 3 insertions, 4 deletions

diff --git a/modules/ui-config.el b/modules/ui-config.el
index 05448b3c5..32bd393f5 100644
--- a/modules/ui-config.el
+++ b/modules/ui-config.el
@@ -94,10 +94,9 @@ When `cj/enable-transparency' is nil, reset alpha to fully opaque."
 		   (if cj/enable-transparency "enabled" "disabled")))
 
 ;; ----------------------------------- Cursor ----------------------------------
-;; The cursor uses the theme's cursor face. Buffer-state cursor coloring was
-;; removed -- a cursor that changed color by buffer state was confusing. The
-;; cj/buffer-status-state / cj/buffer-status-color classifier stays in
-;; user-constants.el; the modeline buffer-name indicator still uses it.
+;; The cursor uses the theme's cursor face. Buffer-state coloring (both the
+;; cursor and the modeline buffer-name) was removed -- changing color by buffer
+;; write state was more confusing than useful.
 
 ;; Don’t show a cursor in non-selected windows:
 (setq cursor-in-non-selected-windows nil)