fix(prog): cover classic modes and warn for missing dev tools

Classic go-mode and js-mode buffers got none of the ts-mode setup, and web-mode got the format key without the promised company/flyspell/LSP. All three now run the shared setup. The web-mode LSP attach guards on the HTML language server, so machines without it stay silent instead of prompting.

gopls, clangd, clang-format, bash-language-server, shfmt, and shellcheck now warn at load when missing. The shfmt, shellcheck, and clang-format blocks gate on :if, which evaluates once at startup, so an absent tool silently disabled that setup until the next restart. I also put ~/go/bin on exec-path at load so the gopls check doesn't misreport a gopls installed there.

4 files changed, 71 insertions, 11 deletions

diff --git a/modules/prog-c.el b/modules/prog-c.el
index 728df018..29a341d5 100644
--- a/modules/prog-c.el
+++ b/modules/prog-c.el
@@ -8,8 +8,9 @@
 ;; Load shape: eager.
 ;; Eager reason: none necessary; currently eager but should load by C major mode
 ;;   (Phase 6 deferral candidate).
-;; Top-level side effects: six add-hook, package configuration via use-package.
-;; Runtime requires: none (configures packages via use-package).
+;; Top-level side effects: six add-hook, package configuration via use-package;
+;;   warns at load if clangd or clang-format is missing.
+;; Runtime requires: system-lib.
 ;; Direct test load: yes.
 ;;
 ;; Modern C programming environment with LSP, tree-sitter, debugging, and formatting.
@@ -59,6 +60,14 @@
 (defvar clang-format-path "clang-format"
   "Path to clang-format executable.")
 
+;; Warn at load time when a C tool is missing.  The clang-format block
+;; below gates on `:if (executable-find ...)', which evaluates once at
+;; startup — an absent binary silently disables the format key until the
+;; next restart, so this warn is the only visible trace.
+(require 'system-lib)  ; for cj/executable-find-or-warn
+(cj/executable-find-or-warn clangd-path "clangd LSP" 'prog-c)
+(cj/executable-find-or-warn clang-format-path "C formatting" 'prog-c)
+
 ;; -------------------------------- C Mode Setup -------------------------------
 ;; preferences for C programming following common conventions
 
diff --git a/modules/prog-go.el b/modules/prog-go.el
index 7faf92a0..2870cd0f 100644
--- a/modules/prog-go.el
+++ b/modules/prog-go.el
@@ -8,8 +8,9 @@
 ;; Load shape: eager.
 ;; Eager reason: none necessary; currently eager but should load by Go major
 ;;   mode (Phase 6 deferral candidate).
-;; Top-level side effects: package configuration via use-package (hooks via :hook).
-;; Runtime requires: none (configures packages via use-package).
+;; Top-level side effects: package configuration via use-package (hooks via
+;;   :hook); adds ~/go/bin to exec-path; warns at load if gopls is missing.
+;; Runtime requires: system-lib.
 ;; Direct test load: yes.
 ;;
 ;; Configuration for Go programming using go-ts-mode (tree-sitter based).
@@ -29,14 +30,25 @@
 
 ;;; Code:
 
+(require 'system-lib)  ; for cj/executable-find-or-warn
+
 (defvar go-bin-path (expand-file-name "~/go/bin")
   "Path to Go binaries directory.
 This is where tools like goimports and staticcheck are installed.")
 
+;; Register the Go bin directory before the gopls check below: go tools
+;; install there, so probing PATH without it would warn about a gopls
+;; that is in fact present.
+(add-to-list 'exec-path go-bin-path)
+
 (defvar gopls-path "gopls"
   "Path to gopls (Go language server).
 Install with: go install golang.org/x/tools/gopls@latest")
 
+;; Warn at load time if gopls is missing rather than waiting for the
+;; first Go buffer to silently skip the LSP attach.
+(cj/executable-find-or-warn gopls-path "gopls LSP" 'prog-go)
+
 (defvar dlv-path "dlv"
   "Path to Delve debugger.
 Install with: go install github.com/go-delve/delve/cmd/dlv@latest")
@@ -113,7 +125,11 @@ Overrides default prog-mode keybindings with Go-specific commands."
   ;; never ran. Autoload gofmt so the first format pulls go-mode and its :config.
   :commands (gofmt)
   :hook ((go-ts-mode . cj/go-setup)
-         (go-ts-mode . cj/go-mode-keybindings))
+         (go-ts-mode . cj/go-mode-keybindings)
+         ;; Classic-mode fallback: same setup when the Go grammar is
+         ;; unavailable and the buffer lands in go-mode.
+         (go-mode . cj/go-setup)
+         (go-mode . cj/go-mode-keybindings))
   :mode (("\\.go\\'" . go-ts-mode)      ;; .go files use go-ts-mode
          ("go\\.mod\\'" . go-mod-ts-mode)) ;; go.mod uses go-mod-ts-mode
   :config
diff --git a/modules/prog-shell.el b/modules/prog-shell.el
index 3ed51da1..7c0972f0 100644
--- a/modules/prog-shell.el
+++ b/modules/prog-shell.el
@@ -9,8 +9,9 @@
 ;; Eager reason: none necessary; currently eager but should load by shell major
 ;;   mode (Phase 6 deferral candidate).
 ;; Top-level side effects: five add-hook, including an after-save executable hook
-;;   the spec flags as needing opt-in/scoping; package config via use-package.
-;; Runtime requires: none (configures packages via use-package).
+;;   the spec flags as needing opt-in/scoping; package config via use-package;
+;;   warns at load for missing shell tools.
+;; Runtime requires: system-lib.
 ;; Direct test load: yes.
 ;;
 ;; Modern shell scripting environment with LSP, tree-sitter, linting, and formatting.
@@ -65,6 +66,15 @@ Install with: sudo pacman -S shfmt")
   "Path to shellcheck executable.
 Install with: sudo pacman -S shellcheck")
 
+;; Warn at load time when a shell tool is missing.  The shfmt and
+;; flycheck blocks below gate on `:if (executable-find ...)', which
+;; evaluates once at startup — an absent tool silently disables that
+;; setup until the next restart, so this warn is the only visible trace.
+(require 'system-lib)  ; for cj/executable-find-or-warn
+(cj/executable-find-or-warn bash-language-server-path "bash LSP" 'prog-shell)
+(cj/executable-find-or-warn shfmt-path "shell formatting" 'prog-shell)
+(cj/executable-find-or-warn shellcheck-path "shell linting" 'prog-shell)
+
 ;; ------------------------------- Shell Script Setup ------------------------------
 ;; preferences for shell scripting
 
diff --git a/modules/prog-webdev.el b/modules/prog-webdev.el
index b228d0cc..f305c65d 100644
--- a/modules/prog-webdev.el
+++ b/modules/prog-webdev.el
@@ -18,6 +18,7 @@
 ;;
 ;; Installation:
 ;;   sudo pacman -S typescript-language-server typescript prettier
+;;   sudo pacman -S vscode-html-languageserver   # LSP in web-mode buffers
 ;;
 ;; Features:
 ;;   - Tree-sitter: Syntax highlighting for TS, TSX, JS (via treesit-auto)
@@ -52,6 +53,10 @@ Install with: sudo pacman -S typescript-language-server")
   "Path to prettier executable.
 Install with: sudo pacman -S prettier")
 
+(defvar html-language-server-path "vscode-html-language-server"
+  "Path to the HTML language server executable used in web-mode buffers.
+Install with: sudo pacman -S vscode-html-languageserver")
+
 ;; Warn at load time if prettier is missing rather than waiting for the
 ;; first format-on-save to fail mid-edit.
 (cj/executable-find-or-warn prettier-path "prettier formatter" 'prog-webdev)
@@ -59,8 +64,8 @@ Install with: sudo pacman -S prettier")
 ;; ------------------------------ Web Dev Setup --------------------------------
 ;; shared setup for TypeScript, JavaScript, and TSX modes
 
-(defun cj/webdev-setup ()
-  "Set up common preferences for web development buffers."
+(defun cj/--webdev-prefs ()
+  "Apply the shared buffer-local preferences for web development buffers."
   (company-mode)
   (flyspell-prog-mode)
   (superword-mode)
@@ -68,13 +73,27 @@ Install with: sudo pacman -S prettier")
   (setq-local tab-width 2)
   (setq-local standard-indent 2)
   (setq-local indent-tabs-mode nil)
-  (electric-pair-local-mode t)
+  (electric-pair-local-mode t))
+
+(defun cj/webdev-setup ()
+  "Set up common preferences for TypeScript/JavaScript buffers."
+  (cj/--webdev-prefs)
 
   ;; Enable LSP if available
   (when (and (fboundp 'lsp-deferred)
              (executable-find ts-language-server-path))
     (lsp-deferred)))
 
+(defun cj/web-mode-setup ()
+  "Set up preferences for web-mode (HTML template) buffers.
+Same shared preferences as the TS/JS modes, but the LSP attach is
+guarded on the HTML language server rather than the TypeScript one, so
+machines without it stay silent instead of prompting."
+  (cj/--webdev-prefs)
+  (when (and (fboundp 'lsp-deferred)
+             (executable-find html-language-server-path))
+    (lsp-deferred)))
+
 (defun cj/--webdev-format-args (file)
   "Return the prettier argv list that formats FILE's contents on stdin.
 No shell quoting is needed: the args are passed to prettier directly
@@ -121,6 +140,11 @@ Detects the file type automatically from the filename."
   ((js-ts-mode . cj/webdev-setup)
    (js-ts-mode . cj/webdev-keybindings)))
 
+;; Classic-mode fallback: when the JS grammar is unavailable the buffer
+;; lands in js-mode; give it the same setup as the tree-sitter modes.
+(add-hook 'js-mode-hook #'cj/webdev-setup)
+(add-hook 'js-mode-hook #'cj/webdev-keybindings)
+
 ;; ----------------------------------- LSP -------------------------------------
 ;; TypeScript/JavaScript LSP configuration
 ;; Core LSP setup is in prog-general.el
@@ -145,7 +169,8 @@ Detects the file type automatically from the filename."
   (web-mode-code-indent-offset 2)
   (web-mode-engines-alist '(("django" . "\\.html\\'")))
   :mode ("\\.html?$" . web-mode)
-  :hook (web-mode . cj/webdev-keybindings))
+  :hook ((web-mode . cj/web-mode-setup)
+         (web-mode . cj/webdev-keybindings)))
 
 (provide 'prog-webdev)
 ;;; prog-webdev.el ends here.