diff options
| author | Craig Jennings <c@cjennings.net> | 2026-06-13 00:56:38 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-06-13 00:56:38 -0500 |
| commit | 5d7633c74dbe47690eb837946ca9f17453dbe13f (patch) | |
| tree | 2a14fb2aee3db7fa37f268ef0b57b2c60e0fb095 /modules | |
| parent | 72bcdede09ddecc21a6ac7e0c97b2e80ecef6ba1 (diff) | |
| download | dotemacs-5d7633c74dbe47690eb837946ca9f17453dbe13f.tar.gz dotemacs-5d7633c74dbe47690eb837946ca9f17453dbe13f.zip | |
fix(keys): revert 936c9fd2, restore the M-S- launcher bindings
936c9fd2 rebound eww/elfeed/calibredb from M-S-e/r/b to the uppercase Meta events M-E/M-R/M-B, on the theory that the keyboard emits the uppercase event and the lowercase-shift spec never matched. It was wrong. keyboard-compat.el installs a key-translation-map entry (M-E -> M-S-e, etc.) in GUI frames, so the original M-S- bindings did reach the launchers. Binding M-E directly while that translation stayed in place rewrote the keypress to the now-unbound M-S-e, breaking all three in GUI on the next restart.
The audit and the review missed it because they checked key-binding, which ignores key-translation-map, and the running daemon still held the pre-fix bindings as stale state.
This restores M-S-e/r/b, deletes the key-binding-only test that certified the broken config, and reclassifies the task as not-a-bug. The real problem, that these chords are dead outside GUI, is the subject of the keybinding-console-safety spec.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/calibredb-epub-config.el | 2 | ||||
| -rw-r--r-- | modules/elfeed-config.el | 2 | ||||
| -rw-r--r-- | modules/eww-config.el | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/modules/calibredb-epub-config.el b/modules/calibredb-epub-config.el index 20262e6e4..a17bf8c91 100644 --- a/modules/calibredb-epub-config.el +++ b/modules/calibredb-epub-config.el @@ -112,7 +112,7 @@ which re-applies `calibredb-search-filter' instead." (use-package calibredb :commands calibredb :bind - ("M-B" . calibredb) ;; Meta+Shift+b emits the uppercase event; overrides backward-word + ("M-S-b" . calibredb) ;; was M-B, overrides backward-word ;; use built-in filter by tag, add clear-filters (:map calibredb-search-mode-map ("l" . calibredb-filter-by-tag) diff --git a/modules/elfeed-config.el b/modules/elfeed-config.el index 4f4089157..ad7bda83a 100644 --- a/modules/elfeed-config.el +++ b/modules/elfeed-config.el @@ -33,7 +33,7 @@ (use-package elfeed :bind - ("M-R" . cj/elfeed-open) ;; Meta+Shift+r emits the uppercase event + ("M-S-r" . cj/elfeed-open) ;; was M-R (:map elfeed-show-mode-map ("w" . eww-open-in-new-buffer)) (:map elfeed-search-mode-map diff --git a/modules/eww-config.el b/modules/eww-config.el index 18648c1ba..066fae989 100644 --- a/modules/eww-config.el +++ b/modules/eww-config.el @@ -67,7 +67,7 @@ (use-package eww :ensure nil ;; built-in :bind - (("M-E" . eww) ;; Meta+Shift+e emits the uppercase event; overrides forward-sentence + (("M-S-e" . eww) ;; was M-E, overrides forward-sentence :map eww-mode-map ("<" . eww-back-url) (">" . eww-forward-url) |