diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-23 03:21:07 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-23 03:21:07 -0500 |
| commit | b63c4f83081ec50074307cdbaff68525869d7294 (patch) | |
| tree | 0dd5db4405401efe2aaf870ae49eecd8ae5de4cb /modules | |
| parent | 61adf68a0e14ad76c276fd6f39162f25f78302b1 (diff) | |
| download | dotemacs-b63c4f83081ec50074307cdbaff68525869d7294.tar.gz dotemacs-b63c4f83081ec50074307cdbaff68525869d7294.zip | |
fix(dirvish): declare runtime constant/util deps with plain require
dirvish-config builds `dirvish-quick-access-entries` from `code-dir`, `music-dir`, `pix-dir`, and the recording dirs at load time, and binds keys to `cj/xdg-open` and `cj/open-file-with-command`. Those come from user-constants and system-utils, but the module only required them under `eval-when-compile`, so the compiled module carries no runtime require and leans on init order having loaded them first.
I switched both to plain requires, matching host-environment, system-lib, and external-open-lib right below. Added a dependency-contract smoke test that fails if the requires are dropped.
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/dirvish-config.el | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/dirvish-config.el b/modules/dirvish-config.el index 5f5ca7fc..774c9ab7 100644 --- a/modules/dirvish-config.el +++ b/modules/dirvish-config.el @@ -24,8 +24,8 @@ ;;; Code: -(eval-when-compile (require 'user-constants)) -(eval-when-compile (require 'system-utils)) +(require 'user-constants) ;; code-dir, music-dir, pix-dir et al. used at load time +(require 'system-utils) ;; cj/xdg-open, cj/open-file-with-command bound to keys (require 'host-environment) (require 'system-lib) (require 'external-open-lib) |