refactor(theme-studio): tier-1 simplification pass

These are behavior-preserving cleanups from the refactor/simplify assessment, all test-verified.

I merged syncMockHeight and syncPkgHeight into one syncPaneHeight(tableId, paneId), inlined the two single-use displayHex/displayName closures, dropped a pkgbody guard that buildPkgTable already does, and had paintUI call worstCellHtml instead of rebuilding the covered-contrast cell. I deleted the dead generatorHues "manual" branch (a copy of the fallback) and locateInfoLine (orphaned when I removed the preview info line earlier today). The two nerd-icons loaders now share _load_nerd_icons_artifact, with a sentinel so a null-file edge keeps its exact behavior. face_coverage.classify reads through named locals now, guarded by a new characterization test.

Two assessment findings were wrong and skipped after I checked them against the code: LOCATE_REG is live (read by previewSpan), and normalizePaletteEntryCore doesn't exist.

1 files changed, 33 insertions, 0 deletions

diff --git a/scripts/theme-studio/test_generate.py b/scripts/theme-studio/test_generate.py
index bc0e87815..3bc78bdf8 100644
--- a/scripts/theme-studio/test_generate.py
+++ b/scripts/theme-studio/test_generate.py
@@ -18,6 +18,39 @@ from collections import Counter, defaultdict
 from contextlib import redirect_stdout
 
 import generate  # importable without side effects: the file write is __main__-guarded
+import face_coverage
+from unittest import mock
+
+
+class ClassifyBucket(unittest.TestCase):
+    """Characterization of face_coverage.classify's core/general/package decision,
+    locking each branch before the named-locals rewrite. bucket_of_source is mocked
+    to identity, so the src dict maps each face straight to its bucket name."""
+
+    def _classify(self, src, pkgfaces=(), name="x"):
+        with mock.patch.object(face_coverage, "bucket_of_source", lambda s: s):
+            return face_coverage.classify(name, list(src), src, set(pkgfaces))
+
+    def test_emacs_core_short_circuits_to_core(self):
+        self.assertEqual(face_coverage.classify("emacs-core", [], {}, set()), "core")
+
+    def test_nothing_loaded_with_a_package_face_is_package(self):
+        self.assertEqual(self._classify({"a": "unloaded", "b": "unloaded"}, pkgfaces={"b"}), "package")
+
+    def test_nothing_loaded_without_a_package_face_is_general(self):
+        self.assertEqual(self._classify({"a": "unloaded"}), "general")
+
+    def test_elpa_plurality_is_package(self):
+        self.assertEqual(self._classify({"a": "elpa", "b": "elpa", "c": "builtin"}), "package")
+
+    def test_elpa_tied_with_builtin_is_package(self):
+        self.assertEqual(self._classify({"a": "elpa", "b": "builtin"}), "package")
+
+    def test_other_beats_builtin_and_ties_elpa_is_package(self):
+        self.assertEqual(self._classify({"a": "other", "b": "other", "c": "elpa", "d": "builtin"}), "package")
+
+    def test_builtin_plurality_is_general(self):
+        self.assertEqual(self._classify({"a": "builtin", "b": "builtin", "c": "elpa"}), "general")
 from app_inventory import face_rows
 from default_faces import DefaultFaces, changed_summary
 from face_specs import face_spec, package_face_spec, ui_face_spec