diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-25 18:05:55 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-25 18:05:55 -0500 |
| commit | 1ca28f229eb360498b93bd048ef745f32f7761e1 (patch) | |
| tree | 0395c87d4a25f7223c6c0b3ae7c7f384e14203cd /tests/test-ai-rewrite.el | |
| parent | 9ed2af69be43d889f59ae1ca262af40405c481c5 (diff) | |
| download | dotemacs-1ca28f229eb360498b93bd048ef745f32f7761e1.tar.gz dotemacs-1ca28f229eb360498b93bd048ef745f32f7761e1.zip | |
refactor(prog): run JSON/YAML/webdev formatters via argv, not a shell
cj/json-format-buffer, cj/yaml-format-buffer, and cj/webdev-format-buffer ran their formatters through shell-command-on-region, which goes via a shell. I moved each to call-process-region with an explicit program and argv list, so a filename or buffer content can't be word-split or read as shell syntax. The webdev path dropped its shell-quote-argument dance once the filename became a plain argv element.
Point preservation is unchanged. One deliberate improvement, and it's tested: shell-command-on-region with replace replaced the buffer with the formatter's error text on a non-zero exit. The new per-formatter helper captures output to a temp buffer, checks the exit code, replaces only on success, and otherwise raises a user-error carrying stderr — so a failed format leaves the buffer alone.
I kept a small format-region helper in each of the three modules rather than one shared helper. They have no common module to live in short of system-lib, and coupling three unrelated domain modules through it wasn't worth saving sixteen lines.
Diffstat (limited to 'tests/test-ai-rewrite.el')
0 files changed, 0 insertions, 0 deletions
