refactor(tests): extract shared buffer-cleanup and fake-vterm helpers

Eight test files across the ai-vterm and vterm-toggle suites each shipped a small variant of the same cleanup loop: walk `buffer-list`, kill any buffer whose name starts with a given prefix. Each file also re-implemented the `(string-prefix-p ...)` check inline. One file additionally had its own fake-vterm-mode-buffer constructor for tests that needed `cj/--vterm-toggle-buffer-p` to fire.

I pulled the shared logic into `tests/testutil-vterm-buffers.el`:

- `cj/test--kill-buffers-matching-prefix` is the primitive.
- `cj/test--kill-claude-buffers` and `cj/test--kill-test-vterm-buffers` are thin wrappers for the two prefixes that actually appear.
- `cj/test--make-fake-vterm-buffer` constructs a buffer with `major-mode` set to `vterm-mode` without launching a real vterm process.

Each affected test file now `(require 'testutil-vterm-buffers)` and calls the shared helpers directly. `test-vterm-toggle--buffer-filter.el` keeps a 3-line wrapper that calls both kill helpers in sequence (the only place that needs both prefixes). Net diff: -116 / +72 across 8 test files, plus ~30 lines in the new testutil. Roughly -45 lines after the abstraction is paid for.

No behavior change. 80 ai-vterm tests, 15 vterm-toggle tests, 15 cj-window-geometry tests all pass. Full make test green.

1 files changed, 7 insertions, 11 deletions

diff --git a/tests/test-ai-vterm--claude-buffers.el b/tests/test-ai-vterm--claude-buffers.el
index 56668ca1b..f975b64eb 100644
--- a/tests/test-ai-vterm--claude-buffers.el
+++ b/tests/test-ai-vterm--claude-buffers.el
@@ -12,24 +12,20 @@
 (require 'ert)
 
 (add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(add-to-list 'load-path (expand-file-name "tests" user-emacs-directory))
 (require 'ai-vterm)
-
-(defun test-ai-vterm--claude-buffers-cleanup ()
-  "Kill any leftover claude-prefixed buffers before/after a test."
-  (dolist (b (buffer-list))
-    (when (string-prefix-p "claude [" (buffer-name b))
-      (kill-buffer b))))
+(require 'testutil-vterm-buffers)
 
 (ert-deftest test-ai-vterm--claude-buffers-empty-when-none-exist ()
   "Boundary: no claude-prefixed buffers anywhere -> empty list."
-  (test-ai-vterm--claude-buffers-cleanup)
+  (cj/test--kill-claude-buffers)
   (unwind-protect
       (should (null (cj/--ai-vterm-claude-buffers)))
-    (test-ai-vterm--claude-buffers-cleanup)))
+    (cj/test--kill-claude-buffers)))
 
 (ert-deftest test-ai-vterm--claude-buffers-returns-only-claude-buffers ()
   "Normal: filters to only claude-prefixed buffers, leaves others alone."
-  (test-ai-vterm--claude-buffers-cleanup)
+  (cj/test--kill-claude-buffers)
   (let ((c1 (get-buffer-create "claude [a]"))
         (c2 (get-buffer-create "claude [b]"))
         (other (get-buffer-create "regular-buffer")))
@@ -45,7 +41,7 @@
 
 (ert-deftest test-ai-vterm--claude-buffers-anchors-prefix-not-substring ()
   "Boundary: 'foo claude [bar]' is not a claude buffer -- prefix anchored."
-  (test-ai-vterm--claude-buffers-cleanup)
+  (cj/test--kill-claude-buffers)
   (let ((not-claude (get-buffer-create "foo claude [bar]")))
     (unwind-protect
         (should-not (memq not-claude (cj/--ai-vterm-claude-buffers)))
@@ -53,7 +49,7 @@
 
 (ert-deftest test-ai-vterm--claude-buffers-bare-claude-not-included ()
   "Boundary: 'claude' alone (no bracket) doesn't match the 'claude [' prefix."
-  (test-ai-vterm--claude-buffers-cleanup)
+  (cj/test--kill-claude-buffers)
   (let ((bare (get-buffer-create "claude")))
     (unwind-protect
         (should-not (memq bare (cj/--ai-vterm-claude-buffers)))