test: repair the seven files red under Emacs 31.1HEADmain

None of the seven was a config regression. Each file had its own cause:

- config-utilities: the tests mocked fboundp with cl-letf. fset on a subr autoloads comp-run, which requires bytecomp, whose defun of byte-compile-file replaced the mock installed earlier in the same cl-letf. 30.2 hid it because ert happened to load bytecomp first. I extracted cj/--compile-elisp-file with an injectable availability predicate (fboundp by default), made cj/compile-this-elisp-buffer the wrapper, and had the tests inject a predicate instead of redefining a primitive. Added the missing no-compiler case.
- system-defaults-functions: the file let-bound use-package-always-ensure before anything declared it special. 30.2 downgraded that to a "Failed to parse package recentf" warning; 31.1 moves the defcustom to autoload time, where it is fatal at load. One defvar before the let.
- calibredb-epub-config: the jump tests stubbed calibredb while it was still an autoload, so the module's require loaded the real definition over the stub and the real command always ran. Require calibredb before any stub.
- agenda-query--render: org 9.8.7 parses the priority cookie with (looking-at org-priority-regexp), whose lazy prefix swallows everything between the stars and the cookie. The fixture now has no cookie and pins that the keyword is not recognised.
- prog-general-yas-activation: python-ts-mode prompts to install a missing grammar, which a batch run cannot answer. The test skips on treesit-ready-p rather than on the mode existing, and the module comment says why.
- integration-recurring-events: the fixtures are America/Chicago and the assertions expect Chicago rendering, so the file only passed on a machine in Central time. TZ is pinned in setup and restored in teardown.

The integration failure had been invisible since 08-17 because make test stops after a red unit phase. make test exits 0 again for the first time since then.

1 files changed, 91 insertions, 47 deletions

diff --git a/tests/test-config-utilities--compile-this-elisp-buffer.el b/tests/test-config-utilities--compile-this-elisp-buffer.el
index a06440ab..f1a442b4 100644
--- a/tests/test-config-utilities--compile-this-elisp-buffer.el
+++ b/tests/test-config-utilities--compile-this-elisp-buffer.el
@@ -1,10 +1,14 @@
 ;;; test-config-utilities--compile-this-elisp-buffer.el --- Tests for cj/compile-this-elisp-buffer -*- lexical-binding: t; -*-
 
 ;;; Commentary:
-;; Tests for `cj/compile-this-elisp-buffer'. The function dispatches
-;; among native-compile-async, native-compile (sync), and
-;; byte-compile-file based on which is fboundp. Tests force each
-;; branch by mocking fboundp at the boundary.
+;; Tests for `cj/compile-this-elisp-buffer' and its helper
+;; `cj/--compile-elisp-file'.  The helper dispatches among
+;; native-compile-async, native-compile (sync), and byte-compile-file based
+;; on an AVAILABLE-P predicate that defaults to `fboundp'.  Tests force each
+;; branch by passing the predicate, never by redefining `fboundp': an `fset'
+;; on that subr autoloads comp-run, which requires bytecomp, whose `defun' of
+;; `byte-compile-file' replaces any test double installed earlier in the same
+;; `cl-letf' (Emacs 30.2 hid this because ert happened to preload bytecomp).
 
 ;;; Code:
 
@@ -14,6 +18,10 @@
 (add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
 (require 'config-utilities)
 
+(defun test-config-utilities--available (&rest syms)
+  "Return a predicate that reports only SYMS as available compilers."
+  (lambda (sym) (memq sym syms)))
+
 (defmacro test-config-utilities--with-elisp-buffer (path &rest body)
   "Run BODY in a temp buffer visiting PATH (a .el file path).
 Skips the interactive `save-buffer' so tests stay free of disk side
@@ -24,72 +32,108 @@ effects."
      (cl-letf (((symbol-function 'save-buffer) (lambda (&rest _) nil)))
        ,@body)))
 
+;; -- the interactive wrapper -------------------------------------------------
+
 (ert-deftest test-config-utilities-compile-buffer-not-elisp-raises ()
   "Error: a buffer whose file isn't .el raises `user-error'."
   (test-config-utilities--with-elisp-buffer "/tmp/not-elisp.txt"
     (should-error (cj/compile-this-elisp-buffer) :type 'user-error)))
 
-(ert-deftest test-config-utilities-compile-buffer-no-buffer-file-name-raises ()
-  "Error: a buffer with no `buffer-file-name' raises `user-error'."
+(ert-deftest test-config-utilities-compile-buffer-no-file-raises ()
+  "Boundary: a buffer visiting no file raises `user-error' rather than
+passing nil to the compiler."
   (with-temp-buffer
-    (setq buffer-file-name nil)
     (should-error (cj/compile-this-elisp-buffer) :type 'user-error)))
 
+(ert-deftest test-config-utilities-compile-buffer-saves-then-delegates ()
+  "Normal: the wrapper saves the buffer and hands its file to the helper."
+  (let (saved compiled)
+    (with-temp-buffer
+      (setq buffer-file-name "/tmp/some.el")
+      (cl-letf (((symbol-function 'save-buffer) (lambda (&rest _) (setq saved t)))
+                ((symbol-function 'cj/--compile-elisp-file)
+                 (lambda (file &optional _) (setq compiled file))))
+        (cj/compile-this-elisp-buffer)))
+    (should saved)
+    (should (equal compiled "/tmp/some.el"))))
+
+;; -- the helper's dispatch ---------------------------------------------------
+
 (ert-deftest test-config-utilities-compile-buffer-prefers-native-async ()
   "Normal: `native-compile-async' is preferred when available."
   (let (called-with)
-    (test-config-utilities--with-elisp-buffer "/tmp/some.el"
-      (cl-letf (((symbol-function 'fboundp)
-                 (lambda (sym)
-                   (memq sym '(native-compile-async native-compile byte-compile-file))))
-                ((symbol-function 'native-compile-async)
-                 (lambda (file) (setq called-with file)))
-                ((symbol-function 'native-compile)
-                 (lambda (_) (error "should not call sync native-compile")))
-                ((symbol-function 'byte-compile-file)
-                 (lambda (&rest _) (error "should not call byte-compile-file"))))
-        (cj/compile-this-elisp-buffer)
-        (should (equal called-with "/tmp/some.el"))))))
+    (cl-letf (((symbol-function 'native-compile-async)
+               (lambda (file) (setq called-with file)))
+              ((symbol-function 'native-compile)
+               (lambda (_) (error "should not call sync native-compile")))
+              ((symbol-function 'byte-compile-file)
+               (lambda (&rest _) (error "should not call byte-compile-file"))))
+      (cj/--compile-elisp-file
+       "/tmp/some.el"
+       (test-config-utilities--available 'native-compile-async 'native-compile
+                                         'byte-compile-file))
+      (should (equal called-with "/tmp/some.el")))))
 
 (ert-deftest test-config-utilities-compile-buffer-falls-back-to-sync-native ()
   "Normal: `native-compile' is used when async isn't available."
   (let (called-with)
-    (test-config-utilities--with-elisp-buffer "/tmp/some.el"
-      (cl-letf (((symbol-function 'fboundp)
-                 (lambda (sym) (memq sym '(native-compile byte-compile-file))))
-                ((symbol-function 'native-compile)
-                 (lambda (file) (setq called-with file)))
-                ((symbol-function 'byte-compile-file)
-                 (lambda (&rest _) (error "should not call byte-compile-file"))))
-        (cj/compile-this-elisp-buffer)
-        (should (equal called-with "/tmp/some.el"))))))
+    (cl-letf (((symbol-function 'native-compile)
+               (lambda (file) (setq called-with file)))
+              ((symbol-function 'byte-compile-file)
+               (lambda (&rest _) (error "should not call byte-compile-file"))))
+      (cj/--compile-elisp-file
+       "/tmp/some.el"
+       (test-config-utilities--available 'native-compile 'byte-compile-file))
+      (should (equal called-with "/tmp/some.el")))))
 
 (ert-deftest test-config-utilities-compile-buffer-falls-back-to-byte-compile ()
   "Normal: `byte-compile-file' is used when neither native option is available."
   (let (called-with)
-    (test-config-utilities--with-elisp-buffer "/tmp/some.el"
-      (cl-letf (((symbol-function 'fboundp)
-                 (lambda (sym) (eq sym 'byte-compile-file)))
-                ((symbol-function 'byte-compile-file)
-                 (lambda (file &rest _) (setq called-with file) "/tmp/some.elc")))
-        (cj/compile-this-elisp-buffer)
-        (should (equal called-with "/tmp/some.el"))))))
+    (cl-letf (((symbol-function 'byte-compile-file)
+               (lambda (file &rest _) (setq called-with file) "/tmp/some.elc")))
+      (cj/--compile-elisp-file
+       "/tmp/some.el"
+       (test-config-utilities--available 'byte-compile-file))
+      (should (equal called-with "/tmp/some.el")))))
+
+(ert-deftest test-config-utilities-compile-buffer-reports-when-nothing-available ()
+  "Boundary: with no compiler available the helper only messages, calling none."
+  (let (captured)
+    (cl-letf (((symbol-function 'native-compile-async)
+               (lambda (&rest _) (error "should not call native-compile-async")))
+              ((symbol-function 'native-compile)
+               (lambda (&rest _) (error "should not call native-compile")))
+              ((symbol-function 'byte-compile-file)
+               (lambda (&rest _) (error "should not call byte-compile-file")))
+              ((symbol-function 'message)
+               (lambda (fmt &rest args) (setq captured (apply #'format fmt args)))))
+      (cj/--compile-elisp-file "/tmp/some.el" (test-config-utilities--available)))
+    (should (string-match-p "No compilation available" captured))))
 
 (ert-deftest test-config-utilities-compile-buffer-handles-sync-native-error ()
   "Error: a sync `native-compile' that signals is caught and reported.
-Asserts no error escapes by running the function and checking that the
+Asserts no error escapes by running the helper and checking that the
 message captured contains the failure prefix."
-  (test-config-utilities--with-elisp-buffer "/tmp/some.el"
-    (let (captured)
-      (cl-letf (((symbol-function 'fboundp)
-                 (lambda (sym) (memq sym '(native-compile byte-compile-file))))
-                ((symbol-function 'native-compile)
-                 (lambda (_) (error "boom")))
-                ((symbol-function 'message)
-                 (lambda (fmt &rest args)
-                   (setq captured (apply #'format fmt args)))))
-        (cj/compile-this-elisp-buffer))
-      (should (string-match-p "Native compile failed" captured)))))
+  (let (captured)
+    (cl-letf (((symbol-function 'native-compile)
+               (lambda (_) (error "boom")))
+              ((symbol-function 'message)
+               (lambda (fmt &rest args) (setq captured (apply #'format fmt args)))))
+      (cj/--compile-elisp-file
+       "/tmp/some.el"
+       (test-config-utilities--available 'native-compile 'byte-compile-file)))
+    (should (string-match-p "Native compile failed" captured))))
+
+(ert-deftest test-config-utilities-compile-buffer-default-predicate-is-fboundp ()
+  "Normal: with no predicate the helper consults `fboundp', so on a real
+Emacs it reaches whichever compiler exists rather than the no-compiler
+message."
+  (let (captured)
+    (cl-letf (((symbol-function 'native-compile-async) (lambda (&rest _) nil))
+              ((symbol-function 'message)
+               (lambda (fmt &rest args) (setq captured (apply #'format fmt args)))))
+      (cj/--compile-elisp-file "/tmp/some.el"))
+    (should (string-match-p "Queued native compilation" captured))))
 
 (provide 'test-config-utilities--compile-this-elisp-buffer)
 ;;; test-config-utilities--compile-this-elisp-buffer.el ends here