feat(dev-fkeys): revert projectile cache on failed-and-modified compile

Without this, a one-off typo at projectile's compile/test/run prompt poisons the per-project cache: every subsequent invocation pre-fills the broken value. I hit it during the Phase 2a live-test, where projectile's "All tests" prompt was replaying `go test ../.` and there was no clean way to get the prior known-good back.

Three pieces of machinery, all in `dev-fkeys.el`:

`cj/--projectile-capture-cmd' captures the current cached cmd at the project root before each invocation, stashing a plist with :map / :root / :prior in `cj/--projectile-revert-state'.

`cj/--projectile-revert-on-fail' is a `compilation-finish-functions' hook that reads that state. If the compile failed AND the cmd was modified from the captured prior value AND the prior was non-nil, it puts the prior back in projectile's cmd-map. Test-fails-because-of-real-bug (cmd unchanged through the run) leaves the cache alone. The hook self-removes on first invocation regardless of outcome and clears the state.

`cj/--projectile-around-revert' is the around-advice that wires the two together. I added the advice to all three projectile cmd-runners — `projectile-compile-project', `projectile-test-project', `projectile-run-project' — so the auto-revert applies whether the user invoked via F4 / F6 or directly via `M-x'.

Plus the manual escape-hatch: `cj/projectile-reset-cmds' clears compile/test/run cache for the current project. Bound to `C-; P' under the personal keymap. Use when projectile's auto-derived default was wrong from the start and you want to start fresh — the next F4 / F6 invocation re-derives projectile's project-type default.

TDD: 18 new tests across 4 files, one per helper. The around-advice tests build the capture/install/orig-fn flow against stub cmd-maps and verify state captured, hook installed, orig-fn invoked. The revert hook tests cover failure-and-modified (revert), success (leave alone), failure-but-unchanged (leave alone), nil prior (leave alone), nil state (no-op), and self-removal. The reset-cmds tests cover the all-three-maps clear, no-cached-entry no-op, and no-project user-error.

1 files changed, 76 insertions, 0 deletions

diff --git a/tests/test-dev-fkeys--projectile-around-revert.el b/tests/test-dev-fkeys--projectile-around-revert.el
new file mode 100644
index 00000000..bdcb11a1
--- /dev/null
+++ b/tests/test-dev-fkeys--projectile-around-revert.el
@@ -0,0 +1,76 @@
+;;; test-dev-fkeys--projectile-around-revert.el --- Tests for cj/--projectile-around-revert -*- lexical-binding: t -*-
+
+;;; Commentary:
+;; Tests for the around-advice that wires the capture / finish-hook pair
+;; to projectile cmd runners. The advice:
+;;
+;; 1. Captures the prior cached cmd via `cj/--projectile-capture-cmd'.
+;; 2. Adds `cj/--projectile-revert-on-fail' to `compilation-finish-functions'.
+;; 3. Calls ORIG-FN with ARGS so projectile's normal flow proceeds.
+
+;;; Code:
+
+(require 'ert)
+(require 'cl-lib)
+(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(require 'dev-fkeys)
+
+(defvar projectile-compile-cmd-map nil)
+
+;;; Normal Cases
+
+(ert-deftest test-dev-fkeys-projectile-around-revert-invokes-orig-fn ()
+  "Normal: advice calls the wrapped function with its args."
+  (let ((calls nil)
+        (cj/--projectile-revert-state nil)
+        (compilation-finish-functions nil)
+        (projectile-compile-cmd-map (make-hash-table :test 'equal)))
+    (cl-letf (((symbol-function 'cj/--f4-project-root) (lambda () "/p/")))
+      (cj/--projectile-around-revert
+       'projectile-compile-cmd-map
+       (lambda (&rest args) (push args calls))
+       'arg1 'arg2))
+    (should (equal calls '((arg1 arg2))))))
+
+(ert-deftest test-dev-fkeys-projectile-around-revert-captures-prior ()
+  "Normal: advice captures the prior cmd into the revert state."
+  (let ((cj/--projectile-revert-state nil)
+        (compilation-finish-functions nil)
+        (projectile-compile-cmd-map (make-hash-table :test 'equal)))
+    (puthash "/p/" "make build" projectile-compile-cmd-map)
+    (cl-letf (((symbol-function 'cj/--f4-project-root) (lambda () "/p/")))
+      (cj/--projectile-around-revert
+       'projectile-compile-cmd-map
+       (lambda (&rest _) nil)))
+    (should (equal (plist-get cj/--projectile-revert-state :prior)
+                   "make build"))))
+
+(ert-deftest test-dev-fkeys-projectile-around-revert-installs-finish-hook ()
+  "Normal: advice adds the revert-on-fail hook to compilation-finish-functions."
+  (let ((cj/--projectile-revert-state nil)
+        (compilation-finish-functions nil)
+        (projectile-compile-cmd-map (make-hash-table :test 'equal)))
+    (cl-letf (((symbol-function 'cj/--f4-project-root) (lambda () "/p/")))
+      (cj/--projectile-around-revert
+       'projectile-compile-cmd-map
+       (lambda (&rest _) nil)))
+    (should (member #'cj/--projectile-revert-on-fail
+                    compilation-finish-functions))))
+
+;;; Boundary Cases
+
+(ert-deftest test-dev-fkeys-projectile-around-revert-no-project-still-runs-orig-fn ()
+  "Boundary: no project root → capture is a no-op, orig-fn still runs.
+The state stays nil so the finish hook will be a no-op too."
+  (let ((calls 0)
+        (cj/--projectile-revert-state nil)
+        (compilation-finish-functions nil))
+    (cl-letf (((symbol-function 'cj/--f4-project-root) (lambda () nil)))
+      (cj/--projectile-around-revert
+       'projectile-compile-cmd-map
+       (lambda (&rest _) (cl-incf calls))))
+    (should (= calls 1))
+    (should (null cj/--projectile-revert-state))))
+
+(provide 'test-dev-fkeys--projectile-around-revert)
+;;; test-dev-fkeys--projectile-around-revert.el ends here