test: re-point projectile revert tests at the decision helper

The legacy `cj/--projectile-revert-on-fail` wrapper and `cj/--projectile-revert-state` global were removed when the closure-based revert refactor landed (commit 2f8d898). The corresponding tests in `test-dev-fkeys--projectile-revert-on-fail.el` and the around-revert / capture-cmd files still referenced the legacy symbols, so 7 tests had been failing on `main` since that commit.

I re-pointed each test at `cj/--projectile-revert-state-on-fail`, the pure decision helper that the closure-based hook delegates to. Each test now passes the captured `state` plist as an explicit argument instead of binding the old global. Test names updated to match the new target.

I dropped two tests that no longer have a target. `revert-on-fail-clears-state` was specific to the wrapper clearing the global on completion, and there is no global to clear now. `revert-on-fail-removes-itself` was specific to the wrapper removing itself from `compilation-finish-functions`. The closure-based hook removes itself differently and is covered by the buffer-local hook tests in `test-dev-fkeys--projectile-around-revert.el`.

The around-revert and capture-cmd tests also lost their `cj/--projectile-revert-state nil` let-bindings since that variable no longer exists.

21 projectile-related tests pass together.

1 files changed, 22 insertions, 43 deletions

diff --git a/tests/test-dev-fkeys--projectile-revert-on-fail.el b/tests/test-dev-fkeys--projectile-revert-on-fail.el
index 6fadd539..78e4c815 100644
--- a/tests/test-dev-fkeys--projectile-revert-on-fail.el
+++ b/tests/test-dev-fkeys--projectile-revert-on-fail.el
@@ -1,11 +1,9 @@
-;;; test-dev-fkeys--projectile-revert-on-fail.el --- Tests for cj/--projectile-revert-on-fail -*- lexical-binding: t -*-
+;;; test-dev-fkeys--projectile-revert-on-fail.el --- Tests for projectile revert decisions -*- lexical-binding: t -*-
 
 ;;; Commentary:
-;; Tests for the compilation-finish hook that reverts projectile's
-;; per-project cache when a build/test failed AND the cmd was modified.
-;; Test-fails-because-of-real-bug (cmd unchanged) leaves the cache alone.
-;; The hook also self-removes from `compilation-finish-functions' on
-;; first invocation and clears `cj/--projectile-revert-state'.
+;; Tests for reverting Projectile's per-project cache when a build/test failed
+;; AND the command was modified. Test-fails-because-of-real-bug (cmd unchanged)
+;; leaves the cache alone.
 
 ;;; Code:
 
@@ -18,87 +16,68 @@
 
 ;;; Normal Cases
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-failure-and-modified-reverts ()
+(ert-deftest test-dev-fkeys-projectile-revert-state-on-fail-failure-and-modified-reverts ()
   "Normal: failure status + cmd modified from prior → revert to prior."
   (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
+         (state
           (list :map 'projectile-compile-cmd-map
                 :root "/p/"
                 :prior "make build")))
     (puthash "/p/" "make buidl" projectile-compile-cmd-map)
-    (cj/--projectile-revert-on-fail nil "exited abnormally with code 2\n")
+    (cj/--projectile-revert-state-on-fail
+     state "exited abnormally with code 2\n")
     (should (string= (gethash "/p/" projectile-compile-cmd-map) "make build"))))
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-success-leaves-cache ()
+(ert-deftest test-dev-fkeys-projectile-revert-state-on-fail-success-leaves-cache ()
   "Normal: success status → no revert, cache keeps the modified cmd."
   (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
+         (state
           (list :map 'projectile-compile-cmd-map
                 :root "/p/"
                 :prior "make build")))
     (puthash "/p/" "make build-fast" projectile-compile-cmd-map)
-    (cj/--projectile-revert-on-fail nil "finished\n")
+    (cj/--projectile-revert-state-on-fail state "finished\n")
     (should (string= (gethash "/p/" projectile-compile-cmd-map) "make build-fast"))))
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-clears-state ()
-  "Normal: hook clears `cj/--projectile-revert-state' regardless of outcome."
-  (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
-          (list :map 'projectile-compile-cmd-map :root "/p/" :prior "x")))
-    (cj/--projectile-revert-on-fail nil "finished\n")
-    (should (null cj/--projectile-revert-state))))
-
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-removes-itself ()
-  "Normal: hook removes itself from `compilation-finish-functions'."
-  (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
-          (list :map 'projectile-compile-cmd-map :root "/p/" :prior "x"))
-         (compilation-finish-functions
-          (list #'cj/--projectile-revert-on-fail)))
-    (cj/--projectile-revert-on-fail nil "finished\n")
-    (should-not (member #'cj/--projectile-revert-on-fail
-                        compilation-finish-functions))))
-
 ;;; Boundary Cases
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-failure-but-unchanged-no-revert ()
+(ert-deftest test-dev-fkeys-projectile-revert-state-on-fail-failure-but-unchanged-no-revert ()
   "Boundary: failure status + cmd unchanged from prior → no revert.
 This is the test-fails-because-of-real-bug case. Don't flap the cache.
 
 Components integrated:
-- `cj/--projectile-revert-on-fail' (unit under test)
-- `cj/--projectile-revert-state' (real, scoped via let)
+- `cj/--projectile-revert-state-on-fail' (unit under test)
 - `projectile-compile-cmd-map' (test stub)"
   (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
+         (state
           (list :map 'projectile-compile-cmd-map
                 :root "/p/"
                 :prior "pytest")))
     (puthash "/p/" "pytest" projectile-compile-cmd-map)
-    (cj/--projectile-revert-on-fail nil "exited abnormally with code 1\n")
+    (cj/--projectile-revert-state-on-fail
+     state "exited abnormally with code 1\n")
     ;; Cache value still equals the prior value (unchanged through the run).
     (should (string= (gethash "/p/" projectile-compile-cmd-map) "pytest"))))
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-failure-with-nil-prior-no-revert ()
+(ert-deftest test-dev-fkeys-projectile-revert-state-on-fail-failure-with-nil-prior-no-revert ()
   "Boundary: failure with no prior cmd cached → don't store nil.
 A nil prior means projectile cached for the first time on this run; even
 if it failed, there's nothing to revert to."
   (let* ((projectile-compile-cmd-map (make-hash-table :test 'equal))
-         (cj/--projectile-revert-state
+         (state
           (list :map 'projectile-compile-cmd-map
                 :root "/p/"
                 :prior nil)))
     (puthash "/p/" "broken-cmd" projectile-compile-cmd-map)
-    (cj/--projectile-revert-on-fail nil "exited abnormally\n")
+    (cj/--projectile-revert-state-on-fail state "exited abnormally\n")
     (should (string= (gethash "/p/" projectile-compile-cmd-map) "broken-cmd"))))
 
 ;;; Error Cases
 
-(ert-deftest test-dev-fkeys-projectile-revert-on-fail-nil-state-is-noop ()
+(ert-deftest test-dev-fkeys-projectile-revert-state-on-fail-nil-state-is-noop ()
   "Error: nil state (capture didn't run) → hook is a no-op, no error."
-  (let ((cj/--projectile-revert-state nil))
-    (cj/--projectile-revert-on-fail nil "exited abnormally\n")
-    (should (null cj/--projectile-revert-state))))
+  (should-not (cj/--projectile-revert-state-on-fail
+               nil "exited abnormally\n")))
 
 (provide 'test-dev-fkeys--projectile-revert-on-fail)
 ;;; test-dev-fkeys--projectile-revert-on-fail.el ends here