diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-24 04:27:54 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-24 04:27:54 -0500 |
| commit | 35e4d70116c8a2a5b82eaf4b8c58889dc02cbe46 (patch) | |
| tree | e3a9a35d84d307b364741423d22221954886ff55 /tests/test-host-environment--platform-predicates.el | |
| parent | 49038c418ead0adc83ffc8fce43c0cb6da9813df (diff) | |
| download | dotemacs-35e4d70116c8a2a5b82eaf4b8c58889dc02cbe46.tar.gz dotemacs-35e4d70116c8a2a5b82eaf4b8c58889dc02cbe46.zip | |
fix(vc): harden clipboard git-clone process and path handling
cj/git-clone-clipboard-url shelled out via shell-command and derived the clone directory with file-name-nondirectory, which mishandles scp-style SSH URLs with no slash (git@host:repo.git became git@host:repo). It also ran git in default-directory and only checked whether the clone dir appeared afterward, so a failed clone was silent.
The clone now runs as a direct git process (call-process, no shell) with clone -- url dir so a URL beginning with - cannot be read as a flag. The destination path comes from cj/--git-clone-dir-name, which takes the last component splitting on / and :, handling HTTPS, scp-style and ssh:// SSH, and local paths. It validates the clipboard is non-empty and the target is a writable directory that does not already contain the destination, and surfaces a non-zero git exit as a user-error with the *git-clone* output. Tests cover the deriver across URL schemes plus the empty-clipboard and clone-failure paths.
Diffstat (limited to 'tests/test-host-environment--platform-predicates.el')
0 files changed, 0 insertions, 0 deletions
