feat(music): always dock the playlist at the bottom

The F10 playlist docked as a right-side column when the frame was wide enough, splitting the frame three ways. That's annoying and often unexpected, so the frame's shape no longer decides where the playlist goes.

I deleted the chooser (cj/--music-playlist-side) and the right-dock width knobs rather than leaving them wired to nothing, and a test asserts they're gone. cj/preferred-dock-direction stays, since ai-term and eat still dock by frame shape.

The old side-chooser test is replaced by one that stubs cj/side-window-display and asserts what the toggle asks for, so it runs headless.

1 files changed, 74 insertions, 0 deletions

diff --git a/tests/test-music-config--playlist-dock.el b/tests/test-music-config--playlist-dock.el
new file mode 100644
index 00000000..69d24cc3
--- /dev/null
+++ b/tests/test-music-config--playlist-dock.el
@@ -0,0 +1,74 @@
+;;; test-music-config--playlist-dock.el --- Tests for the F10 playlist dock -*- lexical-binding: t; -*-
+
+;;; Commentary:
+;; The F10 playlist always docks at the bottom, whatever the frame's shape.
+;; It used to pick `right' on a wide frame via `cj/preferred-dock-direction',
+;; which produced an unwanted three-way split on a wide terminal.
+;;
+;; `cj/side-window-display' is the window-system boundary here, so it is the
+;; thing stubbed (an ordinary defun -- safe to `cl-letf', unlike the frame-*
+;; subrs).  Stubbing it lets these tests assert what the toggle *asks for*
+;; without needing a live frame under `--batch'.
+
+;;; Code:
+
+(require 'ert)
+(require 'cl-lib)
+
+(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(require 'music-config)
+
+(defmacro test-music-dock--with-captured-side (captured &rest body)
+  "Run BODY with the playlist display path stubbed, recording its args in CAPTURED.
+CAPTURED is set to a plist of :side, :size-var and :default-size."
+  (declare (indent 1))
+  `(let ((buffer (generate-new-buffer " *test-playlist*")))
+     (unwind-protect
+         (cl-letf (((symbol-function 'cj/emms--setup) (lambda (&rest _) nil))
+                   ((symbol-function 'cj/music--ensure-playlist-buffer)
+                    (lambda (&rest _) buffer))
+                   ((symbol-function 'emms-playlist-mode-center-current)
+                    (lambda (&rest _) nil))
+                   ((symbol-function 'cj/side-window-display)
+                    (lambda (_buf side size-var default-size)
+                      (setq ,captured (list :side side :size-var size-var
+                                            :default-size default-size))
+                      (selected-window))))
+           ,@body)
+       (kill-buffer buffer))))
+
+(ert-deftest test-music-config-playlist-toggle-docks-bottom-on-wide-frame ()
+  "Normal: a wide frame still docks the playlist at the bottom.
+A wide frame used to dock right, splitting the frame three ways."
+  (let (captured)
+    (test-music-dock--with-captured-side captured
+      (cl-letf (((symbol-function 'frame-width) (lambda (&rest _) 400)))
+        (cj/music-playlist-toggle)))
+    (should (eq 'bottom (plist-get captured :side)))))
+
+(ert-deftest test-music-config-playlist-toggle-docks-bottom-on-narrow-frame ()
+  "Boundary: a narrow frame docks at the bottom, as it always did."
+  (let (captured)
+    (test-music-dock--with-captured-side captured
+      (cl-letf (((symbol-function 'frame-width) (lambda (&rest _) 40)))
+        (cj/music-playlist-toggle)))
+    (should (eq 'bottom (plist-get captured :side)))))
+
+(ert-deftest test-music-config-playlist-toggle-uses-height-memory ()
+  "Normal: the bottom dock carries the height fraction and its memory var."
+  (let (captured)
+    (test-music-dock--with-captured-side captured
+      (cj/music-playlist-toggle))
+    (should (eq 'cj/--music-playlist-height (plist-get captured :size-var)))
+    (should (= cj/music-playlist-window-height (plist-get captured :default-size)))))
+
+(ert-deftest test-music-config-playlist-dock-has-no-width-knobs ()
+  "Error: the right-dock width variables are gone, not merely unused.
+A stale `cj/music-playlist-window-width' would read as a live knob that
+silently does nothing."
+  (should-not (boundp 'cj/music-playlist-window-width))
+  (should-not (boundp 'cj/--music-playlist-width))
+  (should-not (fboundp 'cj/--music-playlist-side)))
+
+(provide 'test-music-config--playlist-dock)
+;;; test-music-config--playlist-dock.el ends here