aboutsummaryrefslogtreecommitdiff
path: root/tests/test-org-capture-config-target-cache.el
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-05-11 18:17:22 -0500
committerCraig Jennings <c@cjennings.net>2026-05-11 18:17:22 -0500
commite0e0ecdb86e3ae1772adcedb50e6c9caa210cf17 (patch)
tree41a16c890b1ffb588635266d45fc484beb85f9de /tests/test-org-capture-config-target-cache.el
parentfc94e5b7101f6677950c414c2822b451351ccc56 (diff)
downloaddotemacs-e0e0ecdb86e3ae1772adcedb50e6c9caa210cf17.tar.gz
dotemacs-e0e0ecdb86e3ae1772adcedb50e6c9caa210cf17.zip
test: close coverage gaps from the preceding batch
Untested paths surfaced while reviewing the preceding feature/fix commits: - calendar-sync: a test that `-L' precedes `-l' in the worker command (separate `member' checks wouldn't catch a swap), plus a `:slow' tag on the real-subprocess worker test so it stays out of the default `make test' run. - org-capture cache: a killed marker buffer invalidates the entry and the next resolution rescans without erroring on the stale marker, `cj/org-capture-clear-target-cache' actually empties the hash, and non-`file+headline' targets (`file', `file+olp', `file+function') fall through to the original `org-capture-set-target-location'. - lorem-optimum: `cj/lipsum-title' on an empty chain returns "", not an error. - calibredb-epub: a negative `cj/nov-margin-percent' is clamped up to 0 (text takes the full window width). - mu4e attachments: the default save directory comes from the part's `:target-dir' and falls back to `~/Downloads/', and asking for the attachment at point on a header line fails with a `user-error'.
Diffstat (limited to 'tests/test-org-capture-config-target-cache.el')
-rw-r--r--tests/test-org-capture-config-target-cache.el48
1 files changed, 48 insertions, 0 deletions
diff --git a/tests/test-org-capture-config-target-cache.el b/tests/test-org-capture-config-target-cache.el
index 7b88975b..f127bfbc 100644
--- a/tests/test-org-capture-config-target-cache.el
+++ b/tests/test-org-capture-config-target-cache.el
@@ -85,5 +85,53 @@ The file-visiting buffer is killed after BODY returns."
(should (cj/org-capture--headline-marker-valid-p marker "Inbox")))))
(test-org-capture-target-cache--reset)))
+(ert-deftest test-org-capture-target-cache-recovers-after-buffer-killed ()
+ "Boundary: killing the marker's buffer invalidates the cache entry.
+The next capture rescans (and refreshes), without crashing on the stale marker."
+ (test-org-capture-target-cache--reset)
+ (unwind-protect
+ (test-org-capture-target-cache--with-temp-org-file
+ "* Inbox\n"
+ (let ((org-capture-plist `(:target (file+headline ,file "Inbox"))))
+ (org-capture-set-target-location)
+ (let* ((key (cj/org-capture--file-headline-cache-key file "Inbox"))
+ (marker (gethash key cj/org-capture--file-headline-target-cache)))
+ (kill-buffer (marker-buffer marker))
+ (should-not (cj/org-capture--headline-marker-valid-p marker "Inbox"))
+ ;; A second resolution must succeed without erroring on the stale marker.
+ (org-capture-set-target-location)
+ (let ((fresh (gethash key cj/org-capture--file-headline-target-cache)))
+ (should (cj/org-capture--headline-marker-valid-p fresh "Inbox"))))))
+ (test-org-capture-target-cache--reset)))
+
+(ert-deftest test-org-capture-target-cache-clear-empties-the-hash ()
+ "Normal: `cj/org-capture-clear-target-cache' actually empties the cache."
+ (test-org-capture-target-cache--reset)
+ (unwind-protect
+ (test-org-capture-target-cache--with-temp-org-file
+ "* Inbox\n"
+ (let ((org-capture-plist `(:target (file+headline ,file "Inbox"))))
+ (org-capture-set-target-location)
+ (should (= 1 (hash-table-count cj/org-capture--file-headline-target-cache)))
+ ;; Suppress the user-facing message during the test.
+ (cl-letf (((symbol-function 'message) (lambda (&rest _) nil)))
+ (cj/org-capture-clear-target-cache))
+ (should (= 0 (hash-table-count cj/org-capture--file-headline-target-cache)))))
+ (test-org-capture-target-cache--reset)))
+
+(ert-deftest test-org-capture-target-cache-falls-through-for-non-file+headline ()
+ "Boundary: targets that aren't `file+headline' (e.g. plain `file', `file+olp',
+`file+function') fall through to the original `org-capture-set-target-location'
+unchanged."
+ (test-org-capture-target-cache--reset)
+ (dolist (target '((file "/tmp/fall-through.org")
+ (file+olp "/tmp/fall-through.org" "Tasks" "Inbox")
+ (file+function "/tmp/fall-through.org" ignore)))
+ (let ((called-with nil))
+ (cj/org-capture--set-target-location-advice
+ (lambda (&optional received) (setq called-with (list :ran received)))
+ target)
+ (should (equal called-with (list :ran target))))))
+
(provide 'test-org-capture-config-target-cache)
;;; test-org-capture-config-target-cache.el ends here